|WARNING| pw130161 [RFC v2] net/sfc: support packet replay in transfer flows

|WARNING| pw130161 [RFC v2] net/sfc: support packet replay in transfer flows

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/130161

_apply patch failure_

Submitter: Ivan Malov <ivan.malov@arknetworks.am>
Date: Fri, 11 Aug 2023 16:03:07 +0400
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 0ae35eceb9e4569b0814fcf671b4455301bb7518

Apply patch set 130161 failed:

Checking patch doc/guides/rel_notes/release_23_11.rst...
error: while searching for:

  * Added support for transfer flow action INDIRECT with subtype VXLAN_ENCAP.


Removed Items
-------------

error: patch failed: doc/guides/rel_notes/release_23_11.rst:59
error: doc/guides/rel_notes/release_23_11.rst: patch does not apply
Checking patch drivers/common/sfc_efx/base/efx.h...
Hunk #1 succeeded at 5318 (offset -9 lines).
Checking patch drivers/common/sfc_efx/base/efx_mae.c...
Hunk #1 succeeded at 4193 (offset -80 lines).
Checking patch drivers/common/sfc_efx/version.map...
Checking patch drivers/net/sfc/sfc_mae.c...
error: while searching for:
			goto fail_mae_alloc_bounce_eh;
		}

		mae->nb_outer_rule_prios_max = limits.eml_max_n_outer_prios;
		mae->nb_action_rule_prios_max = limits.eml_max_n_action_prios;
		mae->encap_types_supported = limits.eml_encap_types_supported;

error: patch failed: drivers/net/sfc/sfc_mae.c:220
error: drivers/net/sfc/sfc_mae.c: patch does not apply
Checking patch drivers/net/sfc/sfc_mae.h...
Hunk #2 succeeded at 106 (offset -1 lines).
Hunk #3 succeeded at 220 (offset -1 lines).
Hunk #4 succeeded at 253 (offset -1 lines).

|WARNING| pw130161 [RFC v2] net/sfc: support packet replay in transfer flows

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/130161

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#173: FILE: drivers/common/sfc_efx/base/efx_mae.c:4286:
+	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec_clone), spec_clone);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#190: FILE: drivers/common/sfc_efx/base/efx_mae.c:4303:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/common/sfc_efx/base/efx_mae.c:4307:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#218: FILE: drivers/common/sfc_efx/base/efx_mae.c:4331:
+	EFX_STATIC_ASSERT(sizeof (aset_list_idp->id) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#242: FILE: drivers/common/sfc_efx/base/efx_mae.c:4355:
+	    aset_ids, n_asets * sizeof (*aset_ids));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#265: FILE: drivers/common/sfc_efx/base/efx_mae.c:4378:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#277: FILE: drivers/common/sfc_efx/base/efx_mae.c:4390:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#335: FILE: drivers/common/sfc_efx/base/efx_mae.c:4448:
+	return (rc);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#490: FILE: drivers/net/sfc/sfc_mae.c:1344:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#504: FILE: drivers/net/sfc/sfc_mae.c:1358:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#782: FILE: drivers/net/sfc/sfc_mae.c:4512:
+					return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#835: FILE: drivers/net/sfc/sfc_mae.c:4717:
+		return ENOSPC;

total: 5 errors, 7 warnings, 0 checks, 1320 lines checked