|FAILURE| pw130984 [PATCH v1] net/axgbe: use CPUID to identify cpu

|FAILURE| pw130984 [PATCH v1] net/axgbe: use CPUID to identify cpu

[qemudev]

Test-Label: loongarch-compilation
Test-Status: FAILURE
http://dpdk.org/patch/130984

_ninja build failure_

Submitter: Selwin Sebastian <selwin.sebastian@amd.com>
Date: Thu, 31 Aug 2023 18:01:31 +0530
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 4150eaad3995178eebcff549f7f79ad8c9b0cbde

130984 --> ninja build failed

Test environment and result as below:

+---------------------+----------------+
|     Environment     | compilation    |
+---------------------+----------------+
| Loongnix-Server 8.3 | FAIL           |
+---------------------+----------------+

Loongnix-Server 8.3
    Kernel: 4.19.190+
    Compiler: gcc 8.3


Ninja build logs:
-------------------------------BEGIN LOGS----------------------------
FAILED: drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_ethdev.c.o
cc -Idrivers/libtmp_rte_net_axgbe.a.p -Idrivers -I../drivers -Idrivers/net/axgbe -I../drivers/net/axgbe -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-ext
 erns -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wno-cast-qual -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.axgbe -MD -MQ drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_ethdev.c.o -MF drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_ethdev.c.o.d -o drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_ethdev.c.o -c ../drivers/net/axgbe/axgbe_ethdev.c
./drivers/net/axgbe/axgbe_ethdev.c:15:10: fatal error: cpuid.h: No such file or directory
#include <cpuid.h>
^~~~~~~~~
compilation terminated.
[706/2352] Generating rte_dma_dpaa.pmd.c with a custom command
[707/2352] Generating rte_dma_cnxk.pmd.c with a custom command
[708/2352] Compiling C object drivers/libtmp_rte_net_atlantic.a.p/net_atlantic_hw_atl_hw_atl_utils_fw2x.c.o
[709/2352] Compiling C object drivers/libtmp_rte_net_atlantic.a.p/net_atlantic_atl_ethdev.c.o
[710/2352] Generating rte_net_avp.pmd.c with a custom command
[711/2352] Compiling C object drivers/libtmp_rte_event_cnxk.a.p/event_cnxk_cn10k_worker.c.o
[712/2352] Compiling C object drivers/libtmp_rte_mempool_ring.a.p/mempool_ring_rte_mempool_ring.c.o
[713/2352] Compiling C object drivers/libtmp_rte_event_cnxk.a.p/event_cnxk_cnxk_tim_evdev.c.o
[714/2352] Generating rte_net_af_packet.pmd.c with a custom command
[715/2352] Compiling C object drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_i2c.c.o
[716/2352] Compiling C object drivers/libtmp_rte_event_cnxk.a.p/event_cnxk_cn9k_worker.c.o
[717/2352] Generating rte_net_ark.pmd.c with a custom command
[718/2352] Compiling C object drivers/libtmp_rte_net_atlantic.a.p/net_atlantic_atl_rxtx.c.o
[719/2352] Compiling C object drivers/libtmp_rte_dma_skeleton.a.p/dma_skeleton_skeleton_dmadev.c.o
[720/2352] Compiling C object drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_mdio.c.o
[721/2352] Compiling C object drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_dev.c.o
[722/2352] Generating rte_mempool_dpaa2.sym_chk with a custom command (wrapped by meson to capture output)
[723/2352] Compiling C object drivers/libtmp_rte_mempool_bucket.a.p/mempool_bucket_rte_mempool_bucket.c.o
[724/2352] Compiling C object drivers/libtmp_rte_common_qat.a.p/crypto_qat_dev_qat_sym_pmd_gen1.c.o
[725/2352] Generating rte_mempool_cnxk.sym_chk with a custom command (wrapped by meson to capture output)
[726/2352] Generating rte_mempool_dpaa.sym_chk with a custom command (wrapped by meson to capture output)
[727/2352] Compiling C object drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_phy_impl.c.o
[728/2352] Compiling C object drivers/libtmp_rte_dma_dpaa2.a.p/dma_dpaa2_dpaa2_qdma.c.o
[729/2352] Compiling C object drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_rxtx.c.o
[730/2352] Generating rte_common_idpf.sym_chk with a custom command (wrapped by meson to capture output)
[731/2352] Generating rte_common_cnxk.pmd.c with a custom command
[732/2352] Compiling C object drivers/libtmp_rte_event_cnxk.a.p/event_cnxk_cn10k_eventdev.c.o
[733/2352] Generating rte_bus_dpaa.sym_chk with a custom command (wrapped by meson to capture output)
[734/2352] Generating rte_bus_fslmc.sym_chk with a custom command (wrapped by meson to capture output)
[735/2352] Compiling C object lib/librte_pipeline.a.p/pipeline_rte_swx_pipeline.c.o
[736/2352] Generating eal.sym_chk with a custom command (wrapped by meson to capture output)
[737/2352] Generating ethdev.sym_chk with a custom command (wrapped by meson to capture output)
[738/2352] Compiling C object lib/librte_vhost.a.p/vhost_virtio_net.c.o
ninja: build stopped: subcommand failed.
-------------------------------END LOGS------------------------------

|WARNING| pw130984 [PATCH v1] net/axgbe: use CPUID to identify cpu

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/130984

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <Fam17h>
#143: FILE: drivers/net/axgbe/axgbe_ethdev.c:178:
+#define	Fam17h	0x17

CHECK:CAMELCASE: Avoid CamelCase: <Fam19h>
#144: FILE: drivers/net/axgbe/axgbe_ethdev.c:179:
+#define	Fam19h	0x19

CHECK:CAMELCASE: Avoid CamelCase: <CPUID_VENDOR_AuthenticAMD_ebx>
#146: FILE: drivers/net/axgbe/axgbe_ethdev.c:181:
+#define	CPUID_VENDOR_AuthenticAMD_ebx	0x68747541

CHECK:CAMELCASE: Avoid CamelCase: <CPUID_VENDOR_AuthenticAMD_ecx>
#147: FILE: drivers/net/axgbe/axgbe_ethdev.c:182:
+#define	CPUID_VENDOR_AuthenticAMD_ecx	0x444d4163

CHECK:CAMELCASE: Avoid CamelCase: <CPUID_VENDOR_AuthenticAMD_edx>
#148: FILE: drivers/net/axgbe/axgbe_ethdev.c:183:
+#define	CPUID_VENDOR_AuthenticAMD_edx	0x69746e65

total: 0 errors, 0 warnings, 5 checks, 135 lines checked

|FAILURE| pw130984 [PATCH v1] net/axgbe: use CPUID to identify cpu

[0-day Robot]

From: robot@bytheb.org

Test-Label: github-robot: build
Test-Status: FAILURE
http://patchwork.dpdk.org/patch/130984/

_github build: failed_
Build URL: https://github.com/ovsrobot/dpdk/actions/runs/6037448960
Build Logs:
-----------------------Summary of failed steps-----------------------
"ubuntu-20.04-gcc-shared-aarch64" failed at step Build and test
"ubuntu-20.04-gcc-ppc64le" failed at step Build and test
"ubuntu-20.04-gcc-riscv64" failed at step Build and test
----------------------End summary of failed steps--------------------

-------------------------------BEGIN LOGS----------------------------
####################################################################################
#### [Begin job log] "ubuntu-20.04-gcc-shared-aarch64" at step Build and test
####################################################################################
[981/3983] Compiling C object 'drivers/a715181@@tmp_rte_net_atlantic@sta/net_atlantic_hw_atl_hw_atl_llh.c.o'.
[982/3983] Compiling C object 'drivers/a715181@@tmp_rte_net_atlantic@sta/net_atlantic_hw_atl_hw_atl_utils_fw2x.c.o'.
[983/3983] Compiling C object 'drivers/a715181@@tmp_rte_net_atlantic@sta/net_atlantic_rte_pmd_atlantic.c.o'.
[984/3983] Compiling C object 'drivers/a715181@@tmp_rte_net_atlantic@sta/net_atlantic_hw_atl_hw_atl_utils.c.o'.
[985/3983] Linking static target drivers/libtmp_rte_net_atlantic.a.
[986/3983] Generating rte_net_atlantic.pmd.c with a custom command.
[987/3983] Compiling C object 'drivers/a715181@@rte_net_atlantic@sha/meson-generated_.._rte_net_atlantic.pmd.c.o'.
[988/3983] Compiling C object 'drivers/a715181@@rte_net_atlantic@sta/meson-generated_.._rte_net_atlantic.pmd.c.o'.
[989/3983] Linking static target drivers/librte_net_atlantic.a.
[990/3983] Generating rte_net_atlantic.sym_chk with a meson_exe.py custom command.
[991/3983] Compiling C object 'drivers/a715181@@tmp_rte_net_avp@sta/net_avp_avp_ethdev.c.o'.
[992/3983] Linking static target drivers/libtmp_rte_net_avp.a.
[993/3983] Linking target drivers/librte_net_atlantic.so.24.0.
[994/3983] Generating rte_net_avp.pmd.c with a custom command.
[995/3983] Compiling C object 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o'.
FAILED: drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o 
ccache aarch64-linux-gnu-gcc -Idrivers/a715181@@tmp_rte_net_axgbe@sta -Idrivers -I../drivers -Idrivers/net/axgbe -I../drivers/net/axgbe -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/arm/include -I../lib/eal/arm/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=armv8-a+crc -moutline-atomics -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wno-cast-qual -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.axgbe -MD -MQ 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o' -MF 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o.d' -o 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o' -c ../drivers/net/axgbe/axgbe_ethdev.c
../drivers/net/axgbe/axgbe_ethdev.c:15:10: fatal error: cpuid.h: No such file or directory
   15 | #include <cpuid.h>
      |          ^~~~~~~~~
compilation terminated.
[996/3983] Generating rte_common_sfc_efx.sym_chk with a meson_exe.py custom command.
[997/3983] Generating rte_common_cnxk.sym_chk with a meson_exe.py custom command.
ninja: build stopped: subcommand failed.
##[error]Process completed with exit code 1.
####################################################################################
#### [End job log] "ubuntu-20.04-gcc-shared-aarch64" at step Build and test
####################################################################################




####################################################################################
#### [Begin job log] "ubuntu-20.04-gcc-ppc64le" at step Build and test
####################################################################################
[899/3290] Compiling C object 'drivers/a715181@@tmp_rte_net_atlantic@sta/net_atlantic_hw_atl_hw_atl_utils.c.o'.
[900/3290] Linking static target drivers/libtmp_rte_net_atlantic.a.
[901/3290] Generating rte_net_ark.pmd.c with a custom command.
[902/3290] Compiling C object 'drivers/a715181@@rte_net_ark@sta/meson-generated_.._rte_net_ark.pmd.c.o'.
[903/3290] Linking static target drivers/librte_net_ark.a.
[904/3290] Compiling C object 'drivers/a715181@@rte_net_ark@sha/meson-generated_.._rte_net_ark.pmd.c.o'.
[905/3290] Linking target drivers/librte_net_ark.so.24.0.
[906/3290] Compiling C object 'drivers/a715181@@tmp_rte_net_avp@sta/net_avp_avp_ethdev.c.o'.
[907/3290] Generating rte_net_atlantic.pmd.c with a custom command.
[908/3290] Compiling C object 'drivers/a715181@@rte_net_atlantic@sta/meson-generated_.._rte_net_atlantic.pmd.c.o'.
[909/3290] Linking static target drivers/libtmp_rte_net_avp.a.
[910/3290] Compiling C object 'drivers/a715181@@rte_net_atlantic@sha/meson-generated_.._rte_net_atlantic.pmd.c.o'.
[911/3290] Linking static target drivers/librte_net_atlantic.a.
[912/3290] Generating rte_net_avp.pmd.c with a custom command.
[913/3290] Compiling C object 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o'.
FAILED: drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o 
ccache powerpc64le-linux-gnu-gcc -Idrivers/a715181@@tmp_rte_net_axgbe@sta -Idrivers -I../drivers -Idrivers/net/axgbe -I../drivers/net/axgbe -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/ppc/include -I../lib/eal/ppc/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -mcpu=power8 -mtune=power8 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wno-cast-qual -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.axgbe -MD -MQ 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o' -MF 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o.d' -o 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o' -c ../drivers/net/axgbe/axgbe_ethdev.c
../drivers/net/axgbe/axgbe_ethdev.c:15:10: fatal error: cpuid.h: No such file or directory
   15 | #include <cpuid.h>
      |          ^~~~~~~~~
compilation terminated.
[914/3290] Generating rte_net_atlantic.sym_chk with a meson_exe.py custom command.
[915/3290] Generating rte_common_cnxk.sym_chk with a meson_exe.py custom command.
ninja: build stopped: subcommand failed.
##[error]Process completed with exit code 1.
####################################################################################
#### [End job log] "ubuntu-20.04-gcc-ppc64le" at step Build and test
####################################################################################




####################################################################################
#### [Begin job log] "ubuntu-20.04-gcc-riscv64" at step Build and test
####################################################################################
[903/3262] Compiling C object 'drivers/a715181@@rte_net_ark@sha/meson-generated_.._rte_net_ark.pmd.c.o'.
[904/3262] Linking static target drivers/librte_net_ark.a.
[905/3262] Linking target drivers/librte_net_ark.so.24.0.
[906/3262] Compiling C object 'drivers/a715181@@tmp_rte_net_avp@sta/net_avp_avp_ethdev.c.o'.
[907/3262] Linking static target drivers/libtmp_rte_net_avp.a.
[908/3262] Generating rte_common_cnxk.pmd.c with a custom command.
[909/3262] Compiling C object 'drivers/a715181@@rte_common_cnxk@sta/meson-generated_.._rte_common_cnxk.pmd.c.o'.
[910/3262] Linking static target drivers/librte_common_cnxk.a.
[911/3262] Generating rte_net_atlantic.pmd.c with a custom command.
[912/3262] Compiling C object 'drivers/a715181@@rte_common_cnxk@sha/meson-generated_.._rte_common_cnxk.pmd.c.o'.
[913/3262] Compiling C object 'drivers/a715181@@rte_net_atlantic@sta/meson-generated_.._rte_net_atlantic.pmd.c.o'.
[914/3262] Linking static target drivers/librte_net_atlantic.a.
[915/3262] Generating rte_net_avp.pmd.c with a custom command.
[916/3262] Compiling C object 'drivers/a715181@@rte_net_atlantic@sha/meson-generated_.._rte_net_atlantic.pmd.c.o'.
[917/3262] Compiling C object 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o'.
FAILED: drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o 
ccache riscv64-linux-gnu-gcc -Idrivers/a715181@@tmp_rte_net_axgbe@sta -Idrivers -I../drivers -Idrivers/net/axgbe -I../drivers/net/axgbe -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/riscv/include -I../lib/eal/riscv/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=rv64gc -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wno-cast-qual -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.axgbe -MD -MQ 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o' -MF 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o.d' -o 'drivers/a715181@@tmp_rte_net_axgbe@sta/net_axgbe_axgbe_ethdev.c.o' -c ../drivers/net/axgbe/axgbe_ethdev.c
../drivers/net/axgbe/axgbe_ethdev.c:15:10: fatal error: cpuid.h: No such file or directory
   15 | #include <cpuid.h>
      |          ^~~~~~~~~
compilation terminated.
[918/3262] Generating rte_net_atlantic.sym_chk with a meson_exe.py custom command.
[919/3262] Generating rte_common_cnxk.sym_chk with a meson_exe.py custom command.
ninja: build stopped: subcommand failed.
##[error]Process completed with exit code 1.
####################################################################################
#### [End job log] "ubuntu-20.04-gcc-riscv64" at step Build and test
####################################################################################
--------------------------------END LOGS-----------------------------