automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>
Subject: |WARNING| pw131004 [RFC v3] net/sfc: support packet replay in transfer flows
Date: Fri,  1 Sep 2023 01:27:59 +0200 (CEST)	[thread overview]
Message-ID: <20230831232759.702E3121090@dpdk.org> (raw)
In-Reply-To: <20230831232657.7400-1-ivan.malov@arknetworks.am>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131004

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#186: FILE: drivers/common/sfc_efx/base/efx_mae.c:4286:
+	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec_clone), spec_clone);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#203: FILE: drivers/common/sfc_efx/base/efx_mae.c:4303:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#207: FILE: drivers/common/sfc_efx/base/efx_mae.c:4307:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#231: FILE: drivers/common/sfc_efx/base/efx_mae.c:4331:
+	EFX_STATIC_ASSERT(sizeof (aset_list_idp->id) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#255: FILE: drivers/common/sfc_efx/base/efx_mae.c:4355:
+	    aset_ids, n_asets * sizeof (*aset_ids));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#278: FILE: drivers/common/sfc_efx/base/efx_mae.c:4378:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#290: FILE: drivers/common/sfc_efx/base/efx_mae.c:4390:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#348: FILE: drivers/common/sfc_efx/base/efx_mae.c:4448:
+	return (rc);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#503: FILE: drivers/net/sfc/sfc_mae.c:1344:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#517: FILE: drivers/net/sfc/sfc_mae.c:1358:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#801: FILE: drivers/net/sfc/sfc_mae.c:4517:
+					return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#841: FILE: drivers/net/sfc/sfc_mae.c:4720:
+		return ENOSPC;

total: 5 errors, 7 warnings, 0 checks, 1449 lines checked

      parent reply	other threads:[~2023-08-31 23:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230831232657.7400-1-ivan.malov@arknetworks.am>
2023-08-31 23:20 ` qemudev
2023-08-31 23:27 ` checkpatch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230831232759.702E3121090@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ivan.malov@arknetworks.am \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).