* |WARNING| pw131004 [RFC v3] net/sfc: support packet replay in transfer flows
[not found] <20230831232657.7400-1-ivan.malov@arknetworks.am>
2023-08-31 23:20 ` |WARNING| pw131004 [RFC v3] net/sfc: support packet replay in transfer flows qemudev
@ 2023-08-31 23:27 ` checkpatch
1 sibling, 0 replies; 2+ messages in thread
From: checkpatch @ 2023-08-31 23:27 UTC (permalink / raw)
To: test-report; +Cc: Ivan Malov
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131004
_coding style issues_
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#186: FILE: drivers/common/sfc_efx/base/efx_mae.c:4286:
+ EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec_clone), spec_clone);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#203: FILE: drivers/common/sfc_efx/base/efx_mae.c:4303:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#207: FILE: drivers/common/sfc_efx/base/efx_mae.c:4307:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#231: FILE: drivers/common/sfc_efx/base/efx_mae.c:4331:
+ EFX_STATIC_ASSERT(sizeof (aset_list_idp->id) ==
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#255: FILE: drivers/common/sfc_efx/base/efx_mae.c:4355:
+ aset_ids, n_asets * sizeof (*aset_ids));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#278: FILE: drivers/common/sfc_efx/base/efx_mae.c:4378:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#290: FILE: drivers/common/sfc_efx/base/efx_mae.c:4390:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#348: FILE: drivers/common/sfc_efx/base/efx_mae.c:4448:
+ return (rc);
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#503: FILE: drivers/net/sfc/sfc_mae.c:1344:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#517: FILE: drivers/net/sfc/sfc_mae.c:1358:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#801: FILE: drivers/net/sfc/sfc_mae.c:4517:
+ return EEXIST;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#841: FILE: drivers/net/sfc/sfc_mae.c:4720:
+ return ENOSPC;
total: 5 errors, 7 warnings, 0 checks, 1449 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread