From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenjing Qiao <wenjing.qiao@intel.com>
Subject: |WARNING| pw131187 [PATCH v3 3/9] net/cpfl: add FXP low level implementation
Date: Wed, 6 Sep 2023 11:36:01 +0200 (CEST) [thread overview]
Message-ID: <20230906093601.A578F1210A9@dpdk.org> (raw)
In-Reply-To: <20230906093407.3635038-4-wenjing.qiao@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131187
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#198: FILE: drivers/net/cpfl/cpfl_actions.h:108:
+#define CPFL_ACT_PREC_CHECK(p) ((p) > 0 && (p) <= CPFL_ACT_PREC_MAX)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#270: FILE: drivers/net/cpfl/cpfl_actions.h:180:
+#define CPFL_ACT_MAKE_8B(prec, idx, val) \
+ ((CPFL_ACT_PREC_SET(prec)) | CPFL_ACT_OP_8B | \
+ (((idx) << CPFL_ACT_8B_A_INDEX_S) & CPFL_ACT_8B_A_INDEX_M) | \
+ (((idx) << CPFL_ACT_8B_B_INDEX_S) & CPFL_ACT_8B_B_INDEX_M) | \
+ (((val) << CPFL_ACT_8B_A_VAL_S) & CPFL_ACT_8B_A_VAL_M) | \
+ (((val) << CPFL_ACT_8B_B_VAL_S) & CPFL_ACT_8B_B_VAL_M))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#270: FILE: drivers/net/cpfl/cpfl_actions.h:180:
+#define CPFL_ACT_MAKE_8B(prec, idx, val) \
+ ((CPFL_ACT_PREC_SET(prec)) | CPFL_ACT_OP_8B | \
+ (((idx) << CPFL_ACT_8B_A_INDEX_S) & CPFL_ACT_8B_A_INDEX_M) | \
+ (((idx) << CPFL_ACT_8B_B_INDEX_S) & CPFL_ACT_8B_B_INDEX_M) | \
+ (((val) << CPFL_ACT_8B_A_VAL_S) & CPFL_ACT_8B_A_VAL_M) | \
+ (((val) << CPFL_ACT_8B_B_VAL_S) & CPFL_ACT_8B_B_VAL_M))
WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1433: FILE: drivers/net/cpfl/cpfl_rules.c:37:
+ context |= SHIFT_VAL64(cmn_cfg->cache_wr_thru,
WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1434: FILE: drivers/net/cpfl/cpfl_rules.c:38:
+ MEV_RULE_CACHE_WR_THRU);
WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1613: FILE: drivers/net/cpfl/cpfl_rules.h:85:
+#define MEV_RULE_CACHE_WR_THRU_S 21
WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1614: FILE: drivers/net/cpfl/cpfl_rules.h:86:
+#define MEV_RULE_CACHE_WR_THRU_M \
WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1615: FILE: drivers/net/cpfl/cpfl_rules.h:87:
+ MAKE_MASK64(0x1, MEV_RULE_CACHE_WR_THRU_S)
WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1754: FILE: drivers/net/cpfl/cpfl_rules.h:226:
+ uint8_t cache_wr_thru;
WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1801: FILE: drivers/net/cpfl/cpfl_rules.h:273:
+ uint8_t cache_wr_thru,
WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1816: FILE: drivers/net/cpfl/cpfl_rules.h:288:
+ cfg_cmn->cache_wr_thru = cache_wr_thru;
WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1816: FILE: drivers/net/cpfl/cpfl_rules.h:288:
+ cfg_cmn->cache_wr_thru = cache_wr_thru;
total: 0 errors, 9 warnings, 3 checks, 1734 lines checked
parent reply other threads:[~2023-09-06 9:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230906093407.3635038-4-wenjing.qiao@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906093601.A578F1210A9@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wenjing.qiao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).