|FAILURE| pw131232 [PATCH v2 2/2] random: make rte_rand() thread safe for non-EAL threads

[0-day Robot <robot@bytheb.org>]

From: robot@bytheb.org

Test-Label: github-robot: build
Test-Status: FAILURE
http://patchwork.dpdk.org/patch/131232/

_github build: failed_
Build URL: https://github.com/ovsrobot/dpdk/actions/runs/6111882830
Build Logs:
-----------------------Summary of failed steps-----------------------
"ubuntu-20.04-clang-asan+doc+tests" failed at step Build and test
"fedora:37-clang" failed at step Build
----------------------End summary of failed steps--------------------

-------------------------------BEGIN LOGS----------------------------
####################################################################################
#### [Begin job log] "ubuntu-20.04-clang-asan+doc+tests" at step Build and test
####################################################################################
[38/3814] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_common_malloc_heap.c.o'.
[39/3814] Generating symbol file 'lib/76b5a35@@rte_log@sha/librte_log.so.24.0.symbols'.
[40/3814] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_common_rte_malloc.c.o'.
[41/3814] Linking target lib/librte_kvargs.so.24.0.
[42/3814] Linking target lib/librte_telemetry.so.24.0.
[43/3814] Generating symbol file 'lib/76b5a35@@rte_telemetry@sha/librte_telemetry.so.24.0.symbols'.
[44/3814] Generating symbol file 'lib/76b5a35@@rte_kvargs@sha/librte_kvargs.so.24.0.symbols'.
[45/3814] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_common_rte_reciprocal.c.o'.
[46/3814] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_common_rte_random.c.o'.
FAILED: lib/76b5a35@@rte_eal@sta/eal_common_rte_random.c.o 
ccache clang -Ilib/76b5a35@@rte_eal@sta -Ilib -I../lib -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Xclang -fcolor-diagnostics -fsanitize=address -fno-omit-frame-pointer -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=corei7 -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API '-DABI_VERSION="24.0"' -DRTE_LOG_DEFAULT_LOGTYPE=lib.eal -DRTE_ANNOTATE_LOCKS -Wthread-safety -MD -MQ 'lib/76b5a35@@rte_eal@sta/eal_common_rte_random.c.o' -MF 'lib/76b5a35@@rte_eal@sta/eal_common_rte_random.c.o.d' -o 'lib/76b5a35@@rte_eal@sta/eal_common_rte_random.c.o' -c ../lib/eal/common/rte_random.c
../lib/eal/common/rte_random.c:136:10: error: mutex 'rte_rand_lock' is not held on every path through here [-Werror,-Wthread-safety-analysis]
        return &rand_states[idx];
                ^
../lib/eal/common/rte_random.c:133:3: note: mutex acquired here
                rte_spinlock_lock(&rte_rand_lock);
                ^
../lib/eal/common/rte_random.c:143:3: error: releasing mutex 'rte_rand_lock' that was not held [-Werror,-Wthread-safety-analysis]
                rte_spinlock_unlock(&rte_rand_lock);
                ^
2 errors generated.
[47/3814] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_common_eal_common_fbarray.c.o'.
[48/3814] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_common_rte_service.c.o'.
ninja: build stopped: subcommand failed.
##[error]Process completed with exit code 1.
####################################################################################
#### [End job log] "ubuntu-20.04-clang-asan+doc+tests" at step Build and test
####################################################################################




####################################################################################
#### [Begin job log] "fedora:37-clang" at step Build
####################################################################################
####################################################################################
#### [End job log] "fedora:37-clang" at step Build
####################################################################################
--------------------------------END LOGS-----------------------------