automatic DPDK test reports
 help / color / mirror / Atom feed
From: qemudev@loongson.cn
To: test-report@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>, zhoumin@loongson.cn
Subject: |WARNING| pw131589 [PATCH] net/mlx5: reuse reformat and modify header actions in a table
Date: Tue, 19 Sep 2023 12:47:06 +0800	[thread overview]
Message-ID: <202309190447.38J4l6p51660690@localhost.localdomain> (raw)
In-Reply-To: <20230919050027.752483-1-getelson@nvidia.com>

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/131589

_apply patch failure_

Submitter: Gregory Etelson <getelson@nvidia.com>
Date: Tue, 19 Sep 2023 08:00:27 +0300
DPDK git baseline: Repo:dpdk
  Branch: main
  CommitID: d83fb967212efa19d272e7fa65d17c9ad94b17c1

Apply patch set 131589 failed:

Checking patch drivers/net/mlx5/mlx5_flow.h...
Checking patch drivers/net/mlx5/mlx5_flow_dv.c...
Checking patch drivers/net/mlx5/mlx5_flow_hw.c...
error: while searching for:
		}
	}
	if (mhdr.pos != UINT16_MAX) {
		struct mlx5dr_action_mh_pattern pattern;
		uint32_t flags;
		uint32_t bulk_size;
		size_t mhdr_len;

		if (flow_hw_validate_compiled_modify_field(dev, cfg, &mhdr, error)) {
			__flow_hw_action_template_destroy(dev, acts);
			return -rte_errno;
		}
		acts->mhdr = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*acts->mhdr),
					 0, SOCKET_ID_ANY);
		if (!acts->mhdr)
			goto err;
		rte_memcpy(acts->mhdr, &mhdr, sizeof(*acts->mhdr));
		mhdr_len = sizeof(struct mlx5_modification_cmd) * acts->mhdr->mhdr_cmds_num;
		flags = mlx5_hw_act_flag[!!attr->group][type];
		if (acts->mhdr->shared) {
			flags |= MLX5DR_ACTION_FLAG_SHARED;
			bulk_size = 0;
		} else {
			bulk_size = rte_log2_u32(table_attr->nb_flows);
		}
		pattern.data = (__be64 *)acts->mhdr->mhdr_cmds;
		pattern.sz = mhdr_len;
		acts->mhdr->action = mlx5dr_action_create_modify_header
				(priv->dr_ctx, 1, &pattern,
				 bulk_size, flags);
		if (!acts->mhdr->action)
			goto err;
		acts->rule_acts[acts->mhdr->pos].action = acts->mhdr->action;
	}
	if (reformat_used) {
		struct mlx5dr_action_reformat_header hdr;
		uint8_t buf[MLX5_ENCAP_MAX_LEN];
		bool shared_rfmt = true;

		MLX5_ASSERT(at->reformat_off != UINT16_MAX);
		if (enc_item) {
			MLX5_ASSERT(!encap_data);
			if (flow_dv_convert_encap_data(enc_item, buf, &data_size, error))
				goto err;
			encap_data = buf;
			if (!enc_item_m)
				shared_rfmt = false;
		} else if (encap_data && !encap_data_m) {
			shared_rfmt = false;
		}
		acts->encap_decap = mlx5_malloc(MLX5_MEM_ZERO,
				    sizeof(*acts->encap_decap) + data_size,
				    0, SOCKET_ID_ANY);
		if (!acts->encap_decap)
			goto err;
		if (data_size) {
			acts->encap_decap->data_size = data_size;
			memcpy(acts->encap_decap->data, encap_data, data_size);
		}

		hdr.sz = data_size;
		hdr.data = encap_data;
		acts->encap_decap->action = mlx5dr_action_create_reformat
				(priv->dr_ctx, refmt_type,
				 1, &hdr,
				 shared_rfmt ? 0 : rte_log2_u32(table_attr->nb_flows),
				 mlx5_hw_act_flag[!!attr->group][type] |
				 (shared_rfmt ? MLX5DR_ACTION_FLAG_SHARED : 0));
		if (!acts->encap_decap->action)
			goto err;
		acts->rule_acts[at->reformat_off].action = acts->encap_decap->action;
		acts->rule_acts[at->reformat_off].reformat.data = acts->encap_decap->data;
		if (shared_rfmt)
			acts->rule_acts[at->reformat_off].reformat.offset = 0;
		else if (__flow_hw_act_data_encap_append(priv, acts,
				 (action_start + reformat_src)->type,
				 reformat_src, at->reformat_off, data_size))
			goto err;
		acts->encap_decap->shared = shared_rfmt;
		acts->encap_decap_pos = at->reformat_off;
	}
	return 0;
err:

error: patch failed: drivers/net/mlx5/mlx5_flow_hw.c:1770
error: drivers/net/mlx5/mlx5_flow_hw.c: patch does not apply


       reply	other threads:[~2023-09-19  5:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230919050027.752483-1-getelson@nvidia.com>
2023-09-19  4:47 ` qemudev [this message]
2023-09-19  5:02 ` checkpatch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309190447.38J4l6p51660690@localhost.localdomain \
    --to=qemudev@loongson.cn \
    --cc=getelson@nvidia.com \
    --cc=test-report@dpdk.org \
    --cc=zhoumin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).