|WARNING| pw131589 [PATCH] net/mlx5: reuse reformat and modify header actions in a table

|WARNING| pw131589 [PATCH] net/mlx5: reuse reformat and modify header actions in a table

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/131589

_apply patch failure_

Submitter: Gregory Etelson <getelson@nvidia.com>
Date: Tue, 19 Sep 2023 08:00:27 +0300
DPDK git baseline: Repo:dpdk
  Branch: main
  CommitID: d83fb967212efa19d272e7fa65d17c9ad94b17c1

Apply patch set 131589 failed:

Checking patch drivers/net/mlx5/mlx5_flow.h...
Checking patch drivers/net/mlx5/mlx5_flow_dv.c...
Checking patch drivers/net/mlx5/mlx5_flow_hw.c...
error: while searching for:
		}
	}
	if (mhdr.pos != UINT16_MAX) {
		struct mlx5dr_action_mh_pattern pattern;
		uint32_t flags;
		uint32_t bulk_size;
		size_t mhdr_len;

		if (flow_hw_validate_compiled_modify_field(dev, cfg, &mhdr, error)) {
			__flow_hw_action_template_destroy(dev, acts);
			return -rte_errno;
		}
		acts->mhdr = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*acts->mhdr),
					 0, SOCKET_ID_ANY);
		if (!acts->mhdr)
			goto err;
		rte_memcpy(acts->mhdr, &mhdr, sizeof(*acts->mhdr));
		mhdr_len = sizeof(struct mlx5_modification_cmd) * acts->mhdr->mhdr_cmds_num;
		flags = mlx5_hw_act_flag[!!attr->group][type];
		if (acts->mhdr->shared) {
			flags |= MLX5DR_ACTION_FLAG_SHARED;
			bulk_size = 0;
		} else {
			bulk_size = rte_log2_u32(table_attr->nb_flows);
		}
		pattern.data = (__be64 *)acts->mhdr->mhdr_cmds;
		pattern.sz = mhdr_len;
		acts->mhdr->action = mlx5dr_action_create_modify_header
				(priv->dr_ctx, 1, &pattern,
				 bulk_size, flags);
		if (!acts->mhdr->action)
			goto err;
		acts->rule_acts[acts->mhdr->pos].action = acts->mhdr->action;
	}
	if (reformat_used) {
		struct mlx5dr_action_reformat_header hdr;
		uint8_t buf[MLX5_ENCAP_MAX_LEN];
		bool shared_rfmt = true;

		MLX5_ASSERT(at->reformat_off != UINT16_MAX);
		if (enc_item) {
			MLX5_ASSERT(!encap_data);
			if (flow_dv_convert_encap_data(enc_item, buf, &data_size, error))
				goto err;
			encap_data = buf;
			if (!enc_item_m)
				shared_rfmt = false;
		} else if (encap_data && !encap_data_m) {
			shared_rfmt = false;
		}
		acts->encap_decap = mlx5_malloc(MLX5_MEM_ZERO,
				    sizeof(*acts->encap_decap) + data_size,
				    0, SOCKET_ID_ANY);
		if (!acts->encap_decap)
			goto err;
		if (data_size) {
			acts->encap_decap->data_size = data_size;
			memcpy(acts->encap_decap->data, encap_data, data_size);
		}

		hdr.sz = data_size;
		hdr.data = encap_data;
		acts->encap_decap->action = mlx5dr_action_create_reformat
				(priv->dr_ctx, refmt_type,
				 1, &hdr,
				 shared_rfmt ? 0 : rte_log2_u32(table_attr->nb_flows),
				 mlx5_hw_act_flag[!!attr->group][type] |
				 (shared_rfmt ? MLX5DR_ACTION_FLAG_SHARED : 0));
		if (!acts->encap_decap->action)
			goto err;
		acts->rule_acts[at->reformat_off].action = acts->encap_decap->action;
		acts->rule_acts[at->reformat_off].reformat.data = acts->encap_decap->data;
		if (shared_rfmt)
			acts->rule_acts[at->reformat_off].reformat.offset = 0;
		else if (__flow_hw_act_data_encap_append(priv, acts,
				 (action_start + reformat_src)->type,
				 reformat_src, at->reformat_off, data_size))
			goto err;
		acts->encap_decap->shared = shared_rfmt;
		acts->encap_decap_pos = at->reformat_off;
	}
	return 0;
err:

error: patch failed: drivers/net/mlx5/mlx5_flow_hw.c:1770
error: drivers/net/mlx5/mlx5_flow_hw.c: patch does not apply

|WARNING| pw131589 [PATCH] net/mlx5: reuse reformat and modify header actions in a table

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131589

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'encap_type' may be better as '(encap_type)' to avoid precedence issues
#189: FILE: drivers/net/mlx5/mlx5_flow_hw.c:61:
+#define MLX5_CONST_ENCAP_ITEM(encap_type, ptr) \
+(((const struct encap_type *)(ptr))->definition)

total: 0 errors, 0 warnings, 1 checks, 733 lines checked
Warning in drivers/net/mlx5/mlx5_flow_hw.c:
Using __atomic_op_fetch, prefer __atomic_fetch_op