From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 911CD42601
	for <public@inbox.dpdk.org>; Tue, 19 Sep 2023 12:11:35 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 897F5406A2;
	Tue, 19 Sep 2023 12:11:35 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 02EB5406A2
 for <test-report@dpdk.org>; Tue, 19 Sep 2023 12:11:35 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id ECC27120802; Tue, 19 Sep 2023 12:11:34 +0200 (CEST)
Subject: |WARNING| pw131619 [PATCH] testpmd: add hairpin-map parameter
In-Reply-To: <20230919101006.19936-1-getelson@nvidia.com>
References: <20230919101006.19936-1-getelson@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Message-Id: <20230919101134.ECC27120802@dpdk.org>
Date: Tue, 19 Sep 2023 12:11:34 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131619

_coding style issues_


ERROR:GLOBAL_INITIALISERS: do not initialise globals to false
#258: FILE: app/test-pmd/testpmd.c:437:
+bool hairpin_multiport_mode = false;

ERROR:SPACING: space required after that ',' (ctx:BxV)
#260: FILE: app/test-pmd/testpmd.c:439:
+static LIST_HEAD(,hairpin_map) hairpin_map_head = LIST_HEAD_INITIALIZER();
                  ^

WARNING:TYPO_SPELLING: 'queus' may be misspelled - perhaps 'queues'?
#375: FILE: app/test-pmd/testpmd.c:2785:
+setup_legacy_hairpin_queus(portid_t pi, portid_t p_pi, uint16_t cnt_pi)

WARNING:TYPO_SPELLING: 'queus' may be misspelled - perhaps 'queues'?
#510: FILE: app/test-pmd/testpmd.c:2867:
+	       setup_legacy_hairpin_queus(pi, p_pi, cnt_pi) :

total: 2 errors, 2 warnings, 379 lines checked