From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6FE4442651
	for <public@inbox.dpdk.org>; Wed, 27 Sep 2023 12:38:01 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6BBC0402C8;
	Wed, 27 Sep 2023 12:38:01 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id EEEF740277
 for <test-report@dpdk.org>; Wed, 27 Sep 2023 12:37:59 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id BA55F120999; Wed, 27 Sep 2023 12:37:59 +0200 (CEST)
Subject: |WARNING| pw131992 [PATCH] net/sfc: support packet replay in transfer
 flows
In-Reply-To: <20230927103605.6022-1-ivan.malov@arknetworks.am>
References: <20230927103605.6022-1-ivan.malov@arknetworks.am>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>
Message-Id: <20230927103759.BA55F120999@dpdk.org>
Date: Wed, 27 Sep 2023 12:37:59 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131992

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#182: FILE: drivers/common/sfc_efx/base/efx_mae.c:4286:
+	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec_clone), spec_clone);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#199: FILE: drivers/common/sfc_efx/base/efx_mae.c:4303:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#203: FILE: drivers/common/sfc_efx/base/efx_mae.c:4307:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#227: FILE: drivers/common/sfc_efx/base/efx_mae.c:4331:
+	EFX_STATIC_ASSERT(sizeof (aset_list_idp->id) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#251: FILE: drivers/common/sfc_efx/base/efx_mae.c:4355:
+	    aset_ids, n_asets * sizeof (*aset_ids));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#274: FILE: drivers/common/sfc_efx/base/efx_mae.c:4378:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#286: FILE: drivers/common/sfc_efx/base/efx_mae.c:4390:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#344: FILE: drivers/common/sfc_efx/base/efx_mae.c:4448:
+	return (rc);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#499: FILE: drivers/net/sfc/sfc_mae.c:1344:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#513: FILE: drivers/net/sfc/sfc_mae.c:1358:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#797: FILE: drivers/net/sfc/sfc_mae.c:4517:
+					return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#837: FILE: drivers/net/sfc/sfc_mae.c:4720:
+		return ENOSPC;

total: 5 errors, 7 warnings, 0 checks, 1449 lines checked