From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9CA9431E2 for ; Mon, 23 Oct 2023 14:44:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4A3442830; Mon, 23 Oct 2023 14:44:28 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id B48F941109 for ; Mon, 23 Oct 2023 14:44:27 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id AF294120A1D; Mon, 23 Oct 2023 14:44:27 +0200 (CEST) Subject: |WARNING| pw133182 [PATCH v4 08/10] net/mlx5: support HWS mirror action In-Reply-To: <20231023124225.141461-9-getelson@nvidia.com> References: <20231023124225.141461-9-getelson@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Gregory Etelson Message-Id: <20231023124427.AF294120A1D@dpdk.org> Date: Mon, 23 Oct 2023 14:44:27 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/133182 _coding style issues_ WARNING:TYPO_SPELLING: 'inplemented' may be misspelled - perhaps 'implemented'? #138: HWS mirror was inplemented with the INDIRECT_LIST flow action. CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #280: FILE: drivers/net/mlx5/mlx5_flow.c:1162: + rte_flow_indir_action_conf *conf, ^ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fops' - possible side-effects? #319: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'drv_cb' may be better as '(drv_cb)' to avoid precedence issues #319: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects? #319: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #319: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} ERROR:CODE_INDENT: code indent should use tabs where possible #321: FILE: drivers/net/mlx5/mlx5_flow.c:10931: + struct rte_flow_attr attr = { .transfer = 0 }; \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #321: FILE: drivers/net/mlx5/mlx5_flow.c:10931: + struct rte_flow_attr attr = { .transfer = 0 }; \$ ERROR:CODE_INDENT: code indent should use tabs where possible #322: FILE: drivers/net/mlx5/mlx5_flow.c:10932: + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #322: FILE: drivers/net/mlx5/mlx5_flow.c:10932: + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \$ ERROR:CODE_INDENT: code indent should use tabs where possible #323: FILE: drivers/net/mlx5/mlx5_flow.c:10933: + if (drv_type == MLX5_FLOW_TYPE_MIN || \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #323: FILE: drivers/net/mlx5/mlx5_flow.c:10933: + if (drv_type == MLX5_FLOW_TYPE_MIN || \$ ERROR:CODE_INDENT: code indent should use tabs where possible #325: FILE: drivers/net/mlx5/mlx5_flow.c:10935: + rte_flow_error_set(error, ENOTSUP, \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #325: FILE: drivers/net/mlx5/mlx5_flow.c:10935: + rte_flow_error_set(error, ENOTSUP, \$ ERROR:CODE_INDENT: code indent should use tabs where possible #327: FILE: drivers/net/mlx5/mlx5_flow.c:10937: + NULL, "invalid driver type"); \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #327: FILE: drivers/net/mlx5/mlx5_flow.c:10937: + NULL, "invalid driver type"); \$ ERROR:CODE_INDENT: code indent should use tabs where possible #328: FILE: drivers/net/mlx5/mlx5_flow.c:10938: + return ret; \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #328: FILE: drivers/net/mlx5/mlx5_flow.c:10938: + return ret; \$ ERROR:CODE_INDENT: code indent should use tabs where possible #329: FILE: drivers/net/mlx5/mlx5_flow.c:10939: + } \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #329: FILE: drivers/net/mlx5/mlx5_flow.c:10939: + } \$ ERROR:CODE_INDENT: code indent should use tabs where possible #330: FILE: drivers/net/mlx5/mlx5_flow.c:10940: + (fops) = flow_get_drv_ops(drv_type); \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #330: FILE: drivers/net/mlx5/mlx5_flow.c:10940: + (fops) = flow_get_drv_ops(drv_type); \$ ERROR:CODE_INDENT: code indent should use tabs where possible #331: FILE: drivers/net/mlx5/mlx5_flow.c:10941: + if (!(fops) || !(fops)->drv_cb) { \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #331: FILE: drivers/net/mlx5/mlx5_flow.c:10941: + if (!(fops) || !(fops)->drv_cb) { \$ ERROR:CODE_INDENT: code indent should use tabs where possible #332: FILE: drivers/net/mlx5/mlx5_flow.c:10942: + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #332: FILE: drivers/net/mlx5/mlx5_flow.c:10942: + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \$ ERROR:CODE_INDENT: code indent should use tabs where possible #333: FILE: drivers/net/mlx5/mlx5_flow.c:10943: + NULL, "no action_list handler"); \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #333: FILE: drivers/net/mlx5/mlx5_flow.c:10943: + NULL, "no action_list handler"); \$ ERROR:CODE_INDENT: code indent should use tabs where possible #334: FILE: drivers/net/mlx5/mlx5_flow.c:10944: + return ret; \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #334: FILE: drivers/net/mlx5/mlx5_flow.c:10944: + return ret; \$ ERROR:CODE_INDENT: code indent should use tabs where possible #335: FILE: drivers/net/mlx5/mlx5_flow.c:10945: + } \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #335: FILE: drivers/net/mlx5/mlx5_flow.c:10945: + } \$ CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #365: FILE: drivers/net/mlx5/mlx5_flow.c:10975: + rte_flow_op_attr *op_attr, ^ CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #367: FILE: drivers/net/mlx5/mlx5_flow.c:10977: + rte_flow_indir_action_conf *conf, ^ WARNING:SPACING: missing space after enum definition #408: FILE: drivers/net/mlx5/mlx5_flow.h:68: +enum mlx5_indirect_type{ ERROR:SPACING: space required before the open parenthesis '(' #780: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9511: + for(i = 0; i < mirror->clones_num; i++) WARNING:LEADING_SPACE: please, no spaces at the start of a line #784: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9515: + if (release)$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 12) #784: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9515: + if (release) + mlx5_free(mirror); ERROR:SPACING: space required before the open parenthesis '(' #823: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9554: + switch(action->type) { ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #887: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9618: + struct mlx5_hrxq* tir_ctx; CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #927: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9658: + struct rte_flow_error __rte_unused *error) ^ CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'encap_type' may be better as '(encap_type)' to avoid precedence issues #936: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9667: +#define MLX5_CONST_ENCAP_ITEM(encap_type, ptr) \ +(((const struct encap_type *)(ptr))->definition) ERROR:CODE_INDENT: code indent should use tabs where possible #941: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9672: + struct mlx5dr_action_dest_attr *dest_attr,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #941: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9672: + struct mlx5dr_action_dest_attr *dest_attr,$ ERROR:CODE_INDENT: code indent should use tabs where possible #942: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9673: + enum mlx5dr_action_type *action_type, bool decap)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #942: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9673: + enum mlx5dr_action_type *action_type, bool decap)$ ERROR:CODE_INDENT: code indent should use tabs where possible #983: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9714: + struct mlx5_mirror_clone *clone,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #983: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9714: + struct mlx5_mirror_clone *clone,$ ERROR:CODE_INDENT: code indent should use tabs where possible #984: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9715: + const struct mlx5_flow_template_table_cfg *table_cfg,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #984: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9715: + const struct mlx5_flow_template_table_cfg *table_cfg,$ ERROR:CODE_INDENT: code indent should use tabs where possible #985: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9716: + const struct rte_flow_action *actions,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #985: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9716: + const struct rte_flow_action *actions,$ ERROR:CODE_INDENT: code indent should use tabs where possible #986: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9717: + struct mlx5dr_action_dest_attr *dest_attr,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #986: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9717: + struct mlx5dr_action_dest_attr *dest_attr,$ ERROR:CODE_INDENT: code indent should use tabs where possible #987: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9718: + struct rte_flow_error *error)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #987: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9718: + struct rte_flow_error *error)$ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1093: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9824: + + } ERROR:CODE_INDENT: code indent should use tabs where possible #1096: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9827: + clones_num,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1096: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9827: + clones_num,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1097: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9828: + mirror_attr,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1097: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9828: + mirror_attr,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1098: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9829: + hws_flags);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1098: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9829: + hws_flags);$ total: 26 errors, 28 warnings, 9 checks, 994 lines checked