automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Subject: |WARNING| pw133293 [PATCH v5 10/10] net/mlx5: support indirect list METER_MARK action
Date: Wed, 25 Oct 2023 12:29:31 +0200 (CEST)	[thread overview]
Message-ID: <20231025102931.BF281120A1D@dpdk.org> (raw)
In-Reply-To: <20231025102727.145493-11-getelson@nvidia.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/133293

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#164: FILE: drivers/net/mlx5/mlx5_flow.c:1187:
+						rte_flow_action_list_handle *handle,
 						                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#210: FILE: drivers/net/mlx5/mlx5_flow.c:11052:
+						rte_flow_action_list_handle *handle,
 						                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#264: FILE: drivers/net/mlx5/mlx5_flow.h:119:
+	LIST_HEAD(, mlx5_indirect_list) *h = head;
 	                                ^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'priv' - possible side-effects?
#374: FILE: drivers/net/mlx5/mlx5_flow_hw.c:64:
+#define MLX5_HW_PORT_IS_PROXY(priv) \
+	(!!((priv)->sh->esw_mode && (priv)->master))

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#375: FILE: drivers/net/mlx5/mlx5_flow_hw.c:65:
+	(!!((priv)->sh->esw_mode && (priv)->master))

CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#534: FILE: drivers/net/mlx5/mlx5_flow_hw.c:1547:
+			rte_flow_indirect_update_flow_meter_mark **flow_conf =
 			                                         ^

ERROR:SPACING: space required before the open parenthesis '('
#747: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9698:
+	for(i = 0; i < mirror->clones_num; i++)

total: 1 errors, 2 warnings, 5 checks, 824 lines checked

      parent reply	other threads:[~2023-10-25 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231025102727.145493-11-getelson@nvidia.com>
2023-10-25 10:11 ` |SUCCESS| pw133284-133293 " qemudev
2023-10-25 10:15 ` qemudev
2023-10-25 10:29 ` checkpatch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231025102931.BF281120A1D@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=getelson@nvidia.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).