From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 993A9431FB
	for <public@inbox.dpdk.org>; Wed, 25 Oct 2023 12:29:32 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 93DBD41104;
	Wed, 25 Oct 2023 12:29:32 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id CD91B41104
 for <test-report@dpdk.org>; Wed, 25 Oct 2023 12:29:31 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id BF281120A1D; Wed, 25 Oct 2023 12:29:31 +0200 (CEST)
Subject: |WARNING| pw133293 [PATCH v5 10/10] net/mlx5: support indirect list
 METER_MARK action
In-Reply-To: <20231025102727.145493-11-getelson@nvidia.com>
References: <20231025102727.145493-11-getelson@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Gregory Etelson <getelson@nvidia.com>
Message-Id: <20231025102931.BF281120A1D@dpdk.org>
Date: Wed, 25 Oct 2023 12:29:31 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/133293

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#164: FILE: drivers/net/mlx5/mlx5_flow.c:1187:
+						rte_flow_action_list_handle *handle,
 						                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#210: FILE: drivers/net/mlx5/mlx5_flow.c:11052:
+						rte_flow_action_list_handle *handle,
 						                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#264: FILE: drivers/net/mlx5/mlx5_flow.h:119:
+	LIST_HEAD(, mlx5_indirect_list) *h = head;
 	                                ^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'priv' - possible side-effects?
#374: FILE: drivers/net/mlx5/mlx5_flow_hw.c:64:
+#define MLX5_HW_PORT_IS_PROXY(priv) \
+	(!!((priv)->sh->esw_mode && (priv)->master))

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#375: FILE: drivers/net/mlx5/mlx5_flow_hw.c:65:
+	(!!((priv)->sh->esw_mode && (priv)->master))

CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#534: FILE: drivers/net/mlx5/mlx5_flow_hw.c:1547:
+			rte_flow_indirect_update_flow_meter_mark **flow_conf =
 			                                         ^

ERROR:SPACING: space required before the open parenthesis '('
#747: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9698:
+	for(i = 0; i < mirror->clones_num; i++)

total: 1 errors, 2 warnings, 5 checks, 824 lines checked