From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CE9E431FB for ; Wed, 25 Oct 2023 13:25:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47A344029A; Wed, 25 Oct 2023 13:25:56 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 670314029A for ; Wed, 25 Oct 2023 13:25:54 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 62746120A1D; Wed, 25 Oct 2023 13:25:54 +0200 (CEST) Subject: |WARNING| pw133301 [PATCH v6 08/10] net/mlx5: support HWS mirror action In-Reply-To: <20231025112232.201606-9-getelson@nvidia.com> References: <20231025112232.201606-9-getelson@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Gregory Etelson Message-Id: <20231025112554.62746120A1D@dpdk.org> Date: Wed, 25 Oct 2023 13:25:54 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/133301 _coding style issues_ CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #307: FILE: drivers/net/mlx5/mlx5_flow.c:1162: + rte_flow_indir_action_conf *conf, ^ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fops' - possible side-effects? #346: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'drv_cb' may be better as '(drv_cb)' to avoid precedence issues #346: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ret' - possible side-effects? #346: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #346: FILE: drivers/net/mlx5/mlx5_flow.c:10929: +#define MLX5_DRV_FOPS_OR_ERR(dev, fops, drv_cb, ret) \ +{ \ + struct rte_flow_attr attr = { .transfer = 0 }; \ + enum mlx5_flow_drv_type drv_type = flow_get_drv_type((dev), &attr); \ + if (drv_type == MLX5_FLOW_TYPE_MIN || \ + drv_type == MLX5_FLOW_TYPE_MAX) { \ + rte_flow_error_set(error, ENOTSUP, \ + RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "invalid driver type"); \ + return ret; \ + } \ + (fops) = flow_get_drv_ops(drv_type); \ + if (!(fops) || !(fops)->drv_cb) { \ + rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, \ + NULL, "no action_list handler"); \ + return ret; \ + } \ +} CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #392: FILE: drivers/net/mlx5/mlx5_flow.c:10975: + rte_flow_op_attr *op_attr, ^ CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #394: FILE: drivers/net/mlx5/mlx5_flow.c:10977: + rte_flow_indir_action_conf *conf, ^ CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #954: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9658: + struct rte_flow_error __rte_unused *error) ^ CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'encap_type' may be better as '(encap_type)' to avoid precedence issues #963: FILE: drivers/net/mlx5/mlx5_flow_hw.c:9667: +#define MLX5_CONST_ENCAP_ITEM(encap_type, ptr) \ +(((const struct encap_type *)(ptr))->definition) total: 0 errors, 1 warnings, 8 checks, 1007 lines checked