From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E60F43256 for ; Tue, 31 Oct 2023 23:46:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A376410D5; Tue, 31 Oct 2023 23:46:40 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 4B5E940285 for ; Tue, 31 Oct 2023 23:46:37 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 45890120A24; Tue, 31 Oct 2023 23:46:37 +0100 (CET) Subject: |WARNING| pw133686 [PATCH v5 1/3] net/tap: support infrastructure to build the BPF filter In-Reply-To: <20231031224429.150002-2-stephen@networkplumber.org> References: <20231031224429.150002-2-stephen@networkplumber.org> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Stephen Hemminger Message-Id: <20231031224637.45890120A24@dpdk.org> Date: Tue, 31 Oct 2023 23:46:37 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/133686 _coding style issues_ CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #210: FILE: drivers/net/tap/bpf/bpf_api.h:31: +#define __uint(name, val) int (*name)[val] ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #211: FILE: drivers/net/tap/bpf/bpf_api.h:32: +#define __type(name, val) typeof(val) *name CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #211: FILE: drivers/net/tap/bpf/bpf_api.h:32: +#define __type(name, val) typeof(val) *name ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #212: FILE: drivers/net/tap/bpf/bpf_api.h:33: +#define __array(name, val) typeof(val) *name[] CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #212: FILE: drivers/net/tap/bpf/bpf_api.h:33: +#define __array(name, val) typeof(val) *name[] WARNING:CONSTANT_CONVERSION: __constant_htons should be htons #237: FILE: drivers/net/tap/bpf/bpf_api.h:58: +# define htons(X) __constant_htons((X)) WARNING:CONSTANT_CONVERSION: __constant_ntohs should be ntohs #241: FILE: drivers/net/tap/bpf/bpf_api.h:62: +# define ntohs(X) __constant_ntohs((X)) WARNING:INLINE: plain inline is preferred over __inline__ #252: FILE: drivers/net/tap/bpf/bpf_api.h:73: +#ifndef __inline__ WARNING:INLINE: plain inline is preferred over __inline__ #253: FILE: drivers/net/tap/bpf/bpf_api.h:74: +# define __inline__ __attribute__((always_inline)) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #314: FILE: drivers/net/tap/bpf/bpf_api.h:135: +# define __BPF_FUNC(NAME, ...) \ + (* NAME)(__VA_ARGS__) __maybe_unused CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'NAME' may be better as '(NAME)' to avoid precedence issues #314: FILE: drivers/net/tap/bpf/bpf_api.h:135: +# define __BPF_FUNC(NAME, ...) \ + (* NAME)(__VA_ARGS__) __maybe_unused ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #319: FILE: drivers/net/tap/bpf/bpf_api.h:140: +# define BPF_FUNC(NAME, ...) \ + __BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME CHECK:SPACING: No space is necessary after a cast #320: FILE: drivers/net/tap/bpf/bpf_api.h:141: + __BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME WARNING:TRACE_PRINTK: Do not use trace_printk() in production code (this can be ignored if built only with a debug config option) #345: FILE: drivers/net/tap/bpf/bpf_api.h:166: + trace_printk(____fmt, sizeof(____fmt), ##__VA_ARGS__); \ CHECK:SPACING: No space is necessary after a cast #398: FILE: drivers/net/tap/bpf/bpf_api.h:219: + (void *) BPF_FUNC_perf_event_output; CHECK:SPACING: No space is necessary after a cast #420: FILE: drivers/net/tap/bpf/bpf_api.h:241: +# define lock_xadd(ptr, val) ((void) __sync_fetch_and_add(ptr, val)) WARNING:TYPO_SPELLING: 'useable' may be misspelled - perhaps 'usable'? #435: FILE: drivers/net/tap/bpf/bpf_api.h:256: +/* FIXME: __builtin_memcmp() is not yet fully useable unless llvm bug WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #439: FILE: drivers/net/tap/bpf/bpf_api.h:260: +#if 0 WARNING:PREFER_SECTION: __section(.maps.) is preferred over __attribute__((section(".maps."))) #510: FILE: drivers/net/tap/bpf/bpf_elf.h:50: + __attribute__ ((section(".maps." #name), used)) \ total: 4 errors, 8 warnings, 7 checks, 494 lines checked Warning in drivers/net/tap/bpf/bpf_api.h: Using compiler attribute directly Warning in drivers/net/tap/bpf/bpf_api.h: Using __sync_xxx builtins