From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw133732 [PATCH v6 1/3] net/tap: support infrastructure to build the BPF filter
Date: Wed, 1 Nov 2023 19:08:09 +0100 (CET) [thread overview]
Message-ID: <20231101180809.57A81120A24@dpdk.org> (raw)
In-Reply-To: <20231101180526.214773-2-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/133732
_coding style issues_
WARNING:TYPO_SPELLING: 'stap' may be misspelled - perhaps 'step'?
#173: FILE: drivers/net/tap/bpf/Makefile:18:
+ python3 bpf_extract.py -stap_bpf_program.c -o $@ $<
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#210: FILE: drivers/net/tap/bpf/bpf_api.h:31:
+#define __uint(name, val) int (*name)[val]
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#211: FILE: drivers/net/tap/bpf/bpf_api.h:32:
+#define __type(name, val) typeof(val) *name
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#211: FILE: drivers/net/tap/bpf/bpf_api.h:32:
+#define __type(name, val) typeof(val) *name
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#212: FILE: drivers/net/tap/bpf/bpf_api.h:33:
+#define __array(name, val) typeof(val) *name[]
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#212: FILE: drivers/net/tap/bpf/bpf_api.h:33:
+#define __array(name, val) typeof(val) *name[]
WARNING:CONSTANT_CONVERSION: __constant_htons should be htons
#237: FILE: drivers/net/tap/bpf/bpf_api.h:58:
+# define htons(X) __constant_htons((X))
WARNING:CONSTANT_CONVERSION: __constant_ntohs should be ntohs
#241: FILE: drivers/net/tap/bpf/bpf_api.h:62:
+# define ntohs(X) __constant_ntohs((X))
WARNING:INLINE: plain inline is preferred over __inline__
#252: FILE: drivers/net/tap/bpf/bpf_api.h:73:
+#ifndef __inline__
WARNING:INLINE: plain inline is preferred over __inline__
#253: FILE: drivers/net/tap/bpf/bpf_api.h:74:
+# define __inline__ __attribute__((always_inline))
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#314: FILE: drivers/net/tap/bpf/bpf_api.h:135:
+# define __BPF_FUNC(NAME, ...) \
+ (* NAME)(__VA_ARGS__) __maybe_unused
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'NAME' may be better as '(NAME)' to avoid precedence issues
#314: FILE: drivers/net/tap/bpf/bpf_api.h:135:
+# define __BPF_FUNC(NAME, ...) \
+ (* NAME)(__VA_ARGS__) __maybe_unused
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#319: FILE: drivers/net/tap/bpf/bpf_api.h:140:
+# define BPF_FUNC(NAME, ...) \
+ __BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME
CHECK:SPACING: No space is necessary after a cast
#320: FILE: drivers/net/tap/bpf/bpf_api.h:141:
+ __BPF_FUNC(NAME, __VA_ARGS__) = (void *) BPF_FUNC_##NAME
WARNING:TRACE_PRINTK: Do not use trace_printk() in production code (this can be ignored if built only with a debug config option)
#345: FILE: drivers/net/tap/bpf/bpf_api.h:166:
+ trace_printk(____fmt, sizeof(____fmt), ##__VA_ARGS__); \
CHECK:SPACING: No space is necessary after a cast
#398: FILE: drivers/net/tap/bpf/bpf_api.h:219:
+ (void *) BPF_FUNC_perf_event_output;
CHECK:SPACING: No space is necessary after a cast
#420: FILE: drivers/net/tap/bpf/bpf_api.h:241:
+# define lock_xadd(ptr, val) ((void) __sync_fetch_and_add(ptr, val))
WARNING:TYPO_SPELLING: 'useable' may be misspelled - perhaps 'usable'?
#435: FILE: drivers/net/tap/bpf/bpf_api.h:256:
+/* FIXME: __builtin_memcmp() is not yet fully useable unless llvm bug
WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#439: FILE: drivers/net/tap/bpf/bpf_api.h:260:
+#if 0
WARNING:PREFER_SECTION: __section(.maps.) is preferred over __attribute__((section(".maps.")))
#510: FILE: drivers/net/tap/bpf/bpf_elf.h:50:
+ __attribute__ ((section(".maps." #name), used)) \
total: 4 errors, 9 warnings, 7 checks, 494 lines checked
Warning in drivers/net/tap/bpf/bpf_api.h:
Using compiler attribute directly
Warning in drivers/net/tap/bpf/bpf_api.h:
Using __sync_xxx builtins
parent reply other threads:[~2023-11-01 18:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20231101180526.214773-2-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101180809.57A81120A24@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).