From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 070E2432E1 for ; Thu, 9 Nov 2023 08:34:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00B8A42D97; Thu, 9 Nov 2023 08:34:39 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id CA97E4021E for ; Thu, 9 Nov 2023 08:34:36 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id BBD6B120DB4; Thu, 9 Nov 2023 08:34:36 +0100 (CET) Subject: |WARNING| pw134006 [PATCH] drivers: use stdatomic API In-Reply-To: <1699515243-29413-1-git-send-email-roretzla@linux.microsoft.com> References: <1699515243-29413-1-git-send-email-roretzla@linux.microsoft.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Tyler Retzlaff Message-Id: <20231109073436.BBD6B120DB4@dpdk.org> Date: Thu, 9 Nov 2023 08:34:36 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/134006 _coding style issues_ CHECK:SPACING: No space is necessary after a cast #551: FILE: drivers/net/mlx5/mlx5.h:373: + RTE_ATOMIC(uint16_t) refcnt; /* Reference count for representors. */ CHECK:SPACING: No space is necessary after a cast #560: FILE: drivers/net/mlx5/mlx5.h:476: + RTE_ATOMIC(uint16_t) state; /**< Age state (atomically accessed). */ CHECK:SPACING: No space is necessary after a cast #564: FILE: drivers/net/mlx5/mlx5.h:479: + RTE_ATOMIC(uint32_t) sec_since_last_hit; CHECK:SPACING: No space is necessary after a cast #573: FILE: drivers/net/mlx5/mlx5.h:492: + RTE_ATOMIC(uint32_t) refcnt; /* Only for shared action management. */ CHECK:SPACING: No space is necessary after a cast #582: FILE: drivers/net/mlx5/mlx5.h:583: + volatile RTE_ATOMIC(uint16_t) n_valid; /* Number of valid pools. */ CHECK:SPACING: No space is necessary after a cast #591: FILE: drivers/net/mlx5/mlx5.h:649: + RTE_ATOMIC(uint32_t) refcnt; CHECK:SPACING: No space is necessary after a cast #600: FILE: drivers/net/mlx5/mlx5.h:683: + RTE_ATOMIC(uint32_t) refcnt; /* geneve tlv object reference counter */ CHECK:SPACING: No space is necessary after a cast #609: FILE: drivers/net/mlx5/mlx5.h:898: + RTE_ATOMIC(uint32_t) ref_cnt; CHECK:SPACING: No space is necessary after a cast #618: FILE: drivers/net/mlx5/mlx5.h:1033: + RTE_ATOMIC(uint32_t) ref_cnt; /**< Use count. */ CHECK:SPACING: No space is necessary after a cast #627: FILE: drivers/net/mlx5/mlx5.h:1073: + RTE_ATOMIC(uint8_t) state; /**< ASO flow meter state. */ CHECK:SPACING: No space is necessary after a cast #636: FILE: drivers/net/mlx5/mlx5.h:1119: + RTE_ATOMIC(uint32_t) def_policy_ref_cnt; CHECK:SPACING: No space is necessary after a cast #646: FILE: drivers/net/mlx5/mlx5.h:1192: + RTE_ATOMIC(uint64_t) ci_ts; CHECK:SPACING: No space is necessary after a cast #647: FILE: drivers/net/mlx5/mlx5.h:1193: + RTE_ATOMIC(uint64_t) ts; CHECK:SPACING: No space is necessary after a cast #661: FILE: drivers/net/mlx5/mlx5.h:1216: + RTE_ATOMIC(uint64_t) err_miss_int; /* Missed service interrupt. */ CHECK:SPACING: No space is necessary after a cast #662: FILE: drivers/net/mlx5/mlx5.h:1217: + RTE_ATOMIC(uint64_t) err_rearm_queue; /* Rearm Queue errors. */ CHECK:SPACING: No space is necessary after a cast #663: FILE: drivers/net/mlx5/mlx5.h:1218: + RTE_ATOMIC(uint64_t) err_clock_queue; /* Clock Queue errors. */ CHECK:SPACING: No space is necessary after a cast #664: FILE: drivers/net/mlx5/mlx5.h:1219: + RTE_ATOMIC(uint64_t) err_ts_past; /* Timestamp in the past. */ CHECK:SPACING: No space is necessary after a cast #665: FILE: drivers/net/mlx5/mlx5.h:1220: + RTE_ATOMIC(uint64_t) err_ts_future; /* Timestamp in the distant future. */ CHECK:SPACING: No space is necessary after a cast #666: FILE: drivers/net/mlx5/mlx5.h:1221: + RTE_ATOMIC(uint64_t) err_ts_order; /* Timestamp not in ascending order. */ CHECK:SPACING: No space is necessary after a cast #675: FILE: drivers/net/mlx5/mlx5.h:1282: + RTE_ATOMIC(uint32_t) refcnt; /* Action used count in device flows. */ CHECK:SPACING: No space is necessary after a cast #679: FILE: drivers/net/mlx5/mlx5.h:1285: + RTE_ATOMIC(enum mlx5_aso_ct_state) state; /* ASO CT state. */ CHECK:SPACING: No space is necessary after a cast #695: FILE: drivers/net/mlx5/mlx5.h:1365: + RTE_ATOMIC(uint32_t) refcnt; /* Atomically accessed refcnt by flows. */ CHECK:SPACING: No space is necessary after a cast #704: FILE: drivers/net/mlx5/mlx5.h:1378: + RTE_ATOMIC(uint32_t) refcnt; CHECK:SPACING: No space is necessary after a cast #715: FILE: drivers/net/mlx5/mlx5.h:1477: + RTE_ATOMIC(struct mlx5_hlist *) encaps_decaps; /* Encap/decap action hash list. */ CHECK:SPACING: No space is necessary after a cast #716: FILE: drivers/net/mlx5/mlx5.h:1478: + RTE_ATOMIC(struct mlx5_hlist *) modify_cmds; CHECK:SPACING: No space is necessary after a cast #717: FILE: drivers/net/mlx5/mlx5.h:1479: + RTE_ATOMIC(struct mlx5_hlist *) tag_table; CHECK:SPACING: No space is necessary after a cast #726: FILE: drivers/net/mlx5/mlx5.h:1490: + RTE_ATOMIC(struct mlx5_indexed_pool *) mdh_ipools[MLX5_MAX_MODIFY_NUM]; CHECK:SPACING: No space is necessary after a cast #735: FILE: drivers/net/mlx5/mlx5.h:1533: + RTE_ATOMIC(void *) hca_bar; CHECK:SPACING: No space is necessary after a cast #744: FILE: drivers/net/mlx5/mlx5.h:1598: + RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */ CHECK:SPACING: No space is necessary after a cast #753: FILE: drivers/net/mlx5/mlx5.h:1749: + RTE_ATOMIC(uint8_t) state; /* object state */ CHECK:SPACING: No space is necessary after a cast #762: FILE: drivers/net/mlx5/mlx5.h:1880: + RTE_ATOMIC(uint32_t) hws_mark_refcnt; /* HWS mark action reference counter. */ CHECK:SPACING: No space is necessary after a cast #771: FILE: drivers/net/mlx5/mlx5.h:1920: + RTE_ATOMIC(uint16_t) shared_refcnt; /* HW steering host reference counter. */ CHECK:SPACING: No space is necessary after a cast #888: FILE: drivers/net/mlx5/mlx5_flow.h:1021: + RTE_ATOMIC(uint32_t) refctn; CHECK:SPACING: No space is necessary after a cast #897: FILE: drivers/net/mlx5/mlx5_flow.h:1341: + RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */ CHECK:SPACING: No space is necessary after a cast #906: FILE: drivers/net/mlx5/mlx5_flow.h:1371: + RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */ CHECK:SPACING: No space is necessary after a cast #915: FILE: drivers/net/mlx5/mlx5_flow.h:1391: + volatile RTE_ATOMIC(uint32_t) *multi_pattern_refcnt; CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #915: FILE: drivers/net/mlx5/mlx5_flow.h:1391: + volatile RTE_ATOMIC(uint32_t) *multi_pattern_refcnt; ^ CHECK:SPACING: No space is necessary after a cast #924: FILE: drivers/net/mlx5/mlx5_flow.h:1414: + volatile RTE_ATOMIC(uint32_t) *multi_pattern_refcnt; CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #924: FILE: drivers/net/mlx5/mlx5_flow.h:1414: + volatile RTE_ATOMIC(uint32_t) *multi_pattern_refcnt; ^ CHECK:SPACING: No space is necessary after a cast #933: FILE: drivers/net/mlx5/mlx5_flow.h:1570: + RTE_ATOMIC(uint32_t) refcnt; /**< Atomically accessed refcnt. */ CHECK:SPACING: No space is necessary after a cast #1062: FILE: drivers/net/mlx5/mlx5_flow_dv.c:288: +flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, RTE_ATOMIC(struct mlx5_hlist *) *phl, CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #1062: FILE: drivers/net/mlx5/mlx5_flow_dv.c:288: +flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, RTE_ATOMIC(struct mlx5_hlist *) *phl, ^ CHECK:SPACING: No space is necessary after a cast #1503: FILE: drivers/net/mlx5/mlx5_flow_hw.c:4070: + RTE_ATOMIC(uint32_t) *reformat_refcnt; CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #1503: FILE: drivers/net/mlx5/mlx5_flow_hw.c:4070: + RTE_ATOMIC(uint32_t) *reformat_refcnt; ^ CHECK:SPACING: No space is necessary after a cast #1512: FILE: drivers/net/mlx5/mlx5_flow_hw.c:4107: + RTE_ATOMIC(uint32_t) *mh_refcnt = mlx5_malloc(MLX5_MEM_ZERO, sizeof(uint32_t), CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #1512: FILE: drivers/net/mlx5/mlx5_flow_hw.c:4107: + RTE_ATOMIC(uint32_t) *mh_refcnt = mlx5_malloc(MLX5_MEM_ZERO, sizeof(uint32_t), ^ CHECK:SPACING: No space is necessary after a cast #2047: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:103: + RTE_ATOMIC(uint32_t) query_gen __rte_cache_aligned; CHECK:SPACING: No space is necessary after a cast #2057: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:135: + RTE_ATOMIC(uint32_t) timeout; /* Aging timeout in seconds (atomically accessed). */ CHECK:SPACING: No space is necessary after a cast #2058: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:136: + RTE_ATOMIC(uint32_t) sec_since_last_hit; CHECK:SPACING: No space is necessary after a cast #2061: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:138: + RTE_ATOMIC(uint16_t) state; /* AGE state (atomically accessed). */ CHECK:SPACING: No space is necessary after a cast #2083: FILE: drivers/net/mlx5/mlx5_rx.h:176: + RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */ CHECK:SPACING: No space is necessary after a cast #2092: FILE: drivers/net/mlx5/mlx5_rx.h:191: + RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */ CHECK:SPACING: No space is necessary after a cast #2267: FILE: drivers/net/mlx5/mlx5_tx.h:181: + RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */ CHECK:SPACING: No space is necessary after a cast #2589: FILE: drivers/net/mlx5/mlx5_utils.h:243: + volatile RTE_ATOMIC(uint32_t) n_trunk_valid; /* Trunks allocated. */ CHECK:SPACING: No space is necessary after a cast #2598: FILE: drivers/net/mlx5/mlx5_utils.h:269: + RTE_ATOMIC(struct mlx5_indexed_cache *) gc; ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2682: FILE: drivers/vdpa/mlx5/mlx5_vdpa.h:96: + RTE_ATOMIC(uint32_t) *remaining_cnt; ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2683: FILE: drivers/vdpa/mlx5/mlx5_vdpa.h:97: + RTE_ATOMIC(uint32_t) *err_cnt; ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2710: FILE: drivers/vdpa/mlx5/mlx5_vdpa.h:584: + RTE_ATOMIC(uint32_t) *remaining_cnt, RTE_ATOMIC(uint32_t) *err_cnt, ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2710: FILE: drivers/vdpa/mlx5/mlx5_vdpa.h:584: + RTE_ATOMIC(uint32_t) *remaining_cnt, RTE_ATOMIC(uint32_t) *err_cnt, ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2717: FILE: drivers/vdpa/mlx5/mlx5_vdpa.h:589: +mlx5_vdpa_c_thread_wait_bulk_tasks_done(RTE_ATOMIC(uint32_t) *remaining_cnt, ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2718: FILE: drivers/vdpa/mlx5/mlx5_vdpa.h:590: + RTE_ATOMIC(uint32_t) *err_cnt, uint32_t sleep_time); ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2731: FILE: drivers/vdpa/mlx5/mlx5_vdpa_cthread.c:51: + RTE_ATOMIC(uint32_t) *remaining_cnt, RTE_ATOMIC(uint32_t) *err_cnt, ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2731: FILE: drivers/vdpa/mlx5/mlx5_vdpa_cthread.c:51: + RTE_ATOMIC(uint32_t) *remaining_cnt, RTE_ATOMIC(uint32_t) *err_cnt, ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2752: FILE: drivers/vdpa/mlx5/mlx5_vdpa_cthread.c:83: +mlx5_vdpa_c_thread_wait_bulk_tasks_done(RTE_ATOMIC(uint32_t) *remaining_cnt, ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #2753: FILE: drivers/vdpa/mlx5/mlx5_vdpa_cthread.c:84: + RTE_ATOMIC(uint32_t) *err_cnt, uint32_t sleep_time) ^ total: 10 errors, 0 warnings, 2430 lines checked