From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 228D8436AC
for <public@inbox.dpdk.org>; Fri, 8 Dec 2023 18:54:40 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1C9FF432A4;
Fri, 8 Dec 2023 18:54:40 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
by mails.dpdk.org (Postfix) with ESMTP id 13E3443001
for <test-report@dpdk.org>; Fri, 8 Dec 2023 18:54:38 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
id 0268F120D36; Fri, 8 Dec 2023 18:54:37 +0100 (CET)
Subject: |WARNING| pw134976 [PATCH v6] gro: fix reordering of packets in GRO
layer
In-Reply-To: <20231208175400.22388-1-kumaraparamesh92@gmail.com>
References: <20231208175400.22388-1-kumaraparamesh92@gmail.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Message-Id: <20231208175438.0268F120D36@dpdk.org>
Date: Fri, 8 Dec 2023 18:54:37 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
<mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
<mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/134976
_coding style issues_
WARNING:TYPO_SPELLING: 'beloging' may be misspelled - perhaps 'belonging'?
#86:
beloging to the same flow but not handled.
WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#91:
Co-authored-by: Kumara Parameshwaran <krathinavel@microsoft.com>
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#147: FILE: lib/gro/gro_tcp.h:195:
+ merged_tcp_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_tcp_hdr *, pkt->l2_len + pkt->l3_len);
WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#215: FILE: lib/gro/gro_tcp4.c:206:
+ delete_tcp_item(tbl->items, item_idx, &tbl->item_num, INVALID_ARRAY_INDEX);
WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns
#231: FILE: lib/gro/gro_tcp4.c:215:
+ * Any packet with additional flags like PSH,FIN should be processed and flushed immediately.
WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#232: FILE: lib/gro/gro_tcp4.c:216:
+ * Hence marking the start time to 0, so that the packets will be flushed immediately in timer
WARNING:BRACES: braces {} are not necessary for single statement blocks
#236: FILE: lib/gro/gro_tcp4.c:220:
+ if (tcp_hdr->tcp_flags != RTE_TCP_ACK_FLAG) {
+ tbl->items[item_start_idx].start_time = 0;
+ }
WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#239: FILE: lib/gro/gro_tcp4.c:223:
+ return process_tcp_item(pkt, tcp_hdr, tcp_dl, tbl->items, tbl->flows[i].start_index,
total: 0 errors, 8 warnings, 108 lines checked