From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bing Zhao <bingz@nvidia.com>
Subject: |WARNING| pw136925 [PATCH v2 1/5] net/mlx5/hws: support NAT64 action
Date: Tue, 20 Feb 2024 15:12:48 +0100 (CET) [thread overview]
Message-ID: <20240220141248.3ED75121F0C@dpdk.org> (raw)
In-Reply-To: <20240220141008.292641-2-bingz@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136925
_coding style issues_
WARNING:TYPO_SPELLING: 'attiribute' may be misspelled - perhaps 'attribute'?
#171: FILE: drivers/net/mlx5/hws/mlx5dr.h:839:
+ * The relevant attiribute of the NAT action.
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#171: FILE: drivers/net/mlx5/hws/mlx5dr.h:839:
+ * ^IThe relevant attiribute of the NAT action.$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#172: FILE: drivers/net/mlx5/hws/mlx5dr.h:840:
+ * The relevant attiribute of the NAT action.
+ * @param[in] flags
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#173: FILE: drivers/net/mlx5/hws/mlx5dr.h:841:
+ * @param[in] flags
+ * Action creation flags. (enum mlx5dr_action_flags)
CHECK:SPACING: No space is necessary after a cast
#246: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:282:
+ action_ptr = (uint8_t *) modify_action_data;
CHECK:SPACING: No space is necessary after a cast
#309: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:345:
+ pat[0].sz = (action_ptr - (uint8_t *) modify_action_data);
CHECK:SPACING: No space is necessary after a cast
#356: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:392:
+ action_ptr = (uint8_t *) modify_action_data;
CHECK:SPACING: No space is necessary after a cast
#396: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:432:
+ pat[0].sz = action_ptr - (uint8_t *) modify_action_data;
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#441: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:477:
+
+ }
CHECK:SPACING: No space is necessary after a cast
#444: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:480:
+ action_ptr = (uint8_t *) modify_action_data;
CHECK:SPACING: No space is necessary after a cast
#509: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:545:
+ pat[0].sz = action_ptr - (uint8_t *) modify_action_data;
total: 0 errors, 4 warnings, 7 checks, 598 lines checked
parent reply other threads:[~2024-02-20 14:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240220141008.292641-2-bingz@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220141248.3ED75121F0C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bingz@nvidia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).