From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27A2443C3A for ; Sat, 2 Mar 2024 15:03:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BB4442D7A; Sat, 2 Mar 2024 15:03:10 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 0D41942DD3 for ; Sat, 2 Mar 2024 15:03:09 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id EC9C6122335; Sat, 2 Mar 2024 15:03:08 +0100 (CET) Subject: |WARNING| pw137806 [RFC 6/7] eal: add generic atomic bit operations In-Reply-To: <20240302135328.531940-7-mattias.ronnblom@ericsson.com> References: <20240302135328.531940-7-mattias.ronnblom@ericsson.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= Message-Id: <20240302140308.EC9C6122335@dpdk.org> Date: Sat, 2 Mar 2024 15:03:08 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/137806 _coding style issues_ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #148: FILE: lib/eal/include/rte_bitops.h:311: + uint32_t *: rte_bit_atomic_test32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #148: FILE: lib/eal/include/rte_bitops.h:311: + uint32_t *: rte_bit_atomic_test32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #149: FILE: lib/eal/include/rte_bitops.h:312: + uint64_t *: rte_bit_atomic_test64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #149: FILE: lib/eal/include/rte_bitops.h:312: + uint64_t *: rte_bit_atomic_test64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #167: FILE: lib/eal/include/rte_bitops.h:330: + uint32_t *: rte_bit_atomic_set32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #167: FILE: lib/eal/include/rte_bitops.h:330: + uint32_t *: rte_bit_atomic_set32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #168: FILE: lib/eal/include/rte_bitops.h:331: + uint64_t *: rte_bit_atomic_set64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #168: FILE: lib/eal/include/rte_bitops.h:331: + uint64_t *: rte_bit_atomic_set64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #186: FILE: lib/eal/include/rte_bitops.h:349: + uint32_t *: rte_bit_atomic_clear32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #186: FILE: lib/eal/include/rte_bitops.h:349: + uint32_t *: rte_bit_atomic_clear32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #187: FILE: lib/eal/include/rte_bitops.h:350: + uint64_t *: rte_bit_atomic_clear64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #187: FILE: lib/eal/include/rte_bitops.h:350: + uint64_t *: rte_bit_atomic_clear64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #207: FILE: lib/eal/include/rte_bitops.h:370: + uint32_t *: rte_bit_atomic_assign32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #207: FILE: lib/eal/include/rte_bitops.h:370: + uint32_t *: rte_bit_atomic_assign32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #208: FILE: lib/eal/include/rte_bitops.h:371: + uint64_t *: rte_bit_atomic_assign64)(addr, nr, value, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #208: FILE: lib/eal/include/rte_bitops.h:371: + uint64_t *: rte_bit_atomic_assign64)(addr, nr, value, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #227: FILE: lib/eal/include/rte_bitops.h:390: +#define rte_bit_atomic_test_and_set(addr, nr, memory_order) \ + _Generic((addr), \ + uint32_t *: rte_bit_atomic_test_and_set32, \ + uint64_t *: rte_bit_atomic_test_and_set64)(addr, nr, \ + memory_order)) ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #229: FILE: lib/eal/include/rte_bitops.h:392: + uint32_t *: rte_bit_atomic_test_and_set32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #229: FILE: lib/eal/include/rte_bitops.h:392: + uint32_t *: rte_bit_atomic_test_and_set32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #230: FILE: lib/eal/include/rte_bitops.h:393: + uint64_t *: rte_bit_atomic_test_and_set64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #230: FILE: lib/eal/include/rte_bitops.h:393: + uint64_t *: rte_bit_atomic_test_and_set64)(addr, nr, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #249: FILE: lib/eal/include/rte_bitops.h:412: +#define rte_bit_atomic_test_and_clear(addr, nr, memory_order) \ + _Generic((addr), \ + uint32_t *: rte_bit_atomic_test_and_clear32, \ + uint64_t *: rte_bit_atomic_test_and_clear64)(addr, nr, \ + memory_order)) ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #251: FILE: lib/eal/include/rte_bitops.h:414: + uint32_t *: rte_bit_atomic_test_and_clear32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #251: FILE: lib/eal/include/rte_bitops.h:414: + uint32_t *: rte_bit_atomic_test_and_clear32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #252: FILE: lib/eal/include/rte_bitops.h:415: + uint64_t *: rte_bit_atomic_test_and_clear64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #252: FILE: lib/eal/include/rte_bitops.h:415: + uint64_t *: rte_bit_atomic_test_and_clear64)(addr, nr, \ ^ total: 26 errors, 0 warnings, 131 lines checked