* |WARNING| pw137805 [RFC 5/7] eal: add atomic bit operations
[not found] <20240302135328.531940-6-mattias.ronnblom@ericsson.com>
@ 2024-03-02 14:03 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-03-02 14:03 UTC (permalink / raw)
To: test-report; +Cc: Mattias Rönnblom
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/137805
_coding style issues_
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#397: FILE: lib/eal/include/rte_bitops.h:967:
+ rte_bit_atomic_test ## size(const uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#408: FILE: lib/eal/include/rte_bitops.h:978:
+ rte_bit_atomic_set ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#419: FILE: lib/eal/include/rte_bitops.h:989:
+ rte_bit_atomic_clear ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#430: FILE: lib/eal/include/rte_bitops.h:1000:
+ rte_bit_atomic_assign ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#442: FILE: lib/eal/include/rte_bitops.h:1012:
+ __rte_bit_atomic_test_and_assign ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: space required before the open parenthesis '('
#456: FILE: lib/eal/include/rte_bitops.h:1026:
+ } while(!__atomic_compare_exchange_n(addr, &before, after, \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#466: FILE: lib/eal/include/rte_bitops.h:1036:
+#define __RTE_GEN_BIT_ATOMIC_OPS(size) \
+ __RTE_GEN_BIT_ATOMIC_TEST(size) \
+ __RTE_GEN_BIT_ATOMIC_SET(size) \
+ __RTE_GEN_BIT_ATOMIC_CLEAR(size) \
+ __RTE_GEN_BIT_ATOMIC_ASSIGN(size) \
+ __RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(size)
total: 7 errors, 0 warnings, 349 lines checked
Warning in lib/eal/include/rte_bitops.h:
Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-02 14:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240302135328.531940-6-mattias.ronnblom@ericsson.com>
2024-03-02 14:03 ` |WARNING| pw137805 [RFC 5/7] eal: add atomic bit operations checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).