From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5429643C3A
	for <public@inbox.dpdk.org>; Sat,  2 Mar 2024 15:03:16 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3A1DB42DA7;
	Sat,  2 Mar 2024 15:03:16 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8675942DD5
 for <test-report@dpdk.org>; Sat,  2 Mar 2024 15:03:14 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 81460122335; Sat,  2 Mar 2024 15:03:14 +0100 (CET)
Subject: |WARNING| pw137805 [RFC 5/7] eal: add atomic bit operations
In-Reply-To: <20240302135328.531940-6-mattias.ronnblom@ericsson.com>
References: <20240302135328.531940-6-mattias.ronnblom@ericsson.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
Message-Id: <20240302140314.81460122335@dpdk.org>
Date: Sat,  2 Mar 2024 15:03:14 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/137805

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#397: FILE: lib/eal/include/rte_bitops.h:967:
+	rte_bit_atomic_test ## size(const uint ## size ## _t *addr,	\
 	                                                     ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#408: FILE: lib/eal/include/rte_bitops.h:978:
+	rte_bit_atomic_set ## size(uint ## size ## _t *addr,		\
 	                                              ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#419: FILE: lib/eal/include/rte_bitops.h:989:
+	rte_bit_atomic_clear ## size(uint ## size ## _t *addr,		\
 	                                                ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#430: FILE: lib/eal/include/rte_bitops.h:1000:
+	rte_bit_atomic_assign ## size(uint ## size ## _t *addr,		\
 	                                                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#442: FILE: lib/eal/include/rte_bitops.h:1012:
+	__rte_bit_atomic_test_and_assign ## size(uint ## size ## _t *addr, \
 	                                                            ^

ERROR:SPACING: space required before the open parenthesis '('
#456: FILE: lib/eal/include/rte_bitops.h:1026:
+		} while(!__atomic_compare_exchange_n(addr, &before, after, \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#466: FILE: lib/eal/include/rte_bitops.h:1036:
+#define __RTE_GEN_BIT_ATOMIC_OPS(size)			\
+	__RTE_GEN_BIT_ATOMIC_TEST(size)			\
+	__RTE_GEN_BIT_ATOMIC_SET(size)			\
+	__RTE_GEN_BIT_ATOMIC_CLEAR(size)		\
+	__RTE_GEN_BIT_ATOMIC_ASSIGN(size)		\
+	__RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(size)

total: 7 errors, 0 warnings, 349 lines checked
Warning in lib/eal/include/rte_bitops.h:
Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx