From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBFE143CEE for ; Tue, 19 Mar 2024 17:18:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43371410E8; Tue, 19 Mar 2024 17:18:44 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 3402C410E6 for ; Tue, 19 Mar 2024 17:18:43 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 156D01223F7; Tue, 19 Mar 2024 17:18:43 +0100 (CET) Subject: |WARNING| pw138484 [PATCH] net/ixgbe: using dpdk-dumpcap capture packet coredump In-Reply-To: <1710865092-2796-1-git-send-email-junwang01@cestc.cn> References: <1710865092-2796-1-git-send-email-junwang01@cestc.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Jun Wang Message-Id: <20240319161843.156D01223F7@dpdk.org> Date: Tue, 19 Mar 2024 17:18:43 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/138484 _coding style issues_ WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one ERROR:CODE_INDENT: code indent should use tabs where possible #96: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4329: +^I ^I!ad->sdp3_no_tx_disable) {$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #96: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4329: +^I ^I!ad->sdp3_no_tx_disable) {$ WARNING:LONG_LINE: line length of 105 exceeds 100 columns #126: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4339: + if (!__atomic_test_and_set(&ad->link_thread_running, __ATOMIC_SEQ_CST)) { ERROR:CODE_INDENT: code indent should use tabs where possible #128: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4341: +^I^I^I^I ^I* the IXGBE_FLAG_NEED_LINK_CONFIG flag only$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #128: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4341: +^I^I^I^I ^I* the IXGBE_FLAG_NEED_LINK_CONFIG flag only$ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #128: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4341: + /* To avoid race condition between threads, set + * the IXGBE_FLAG_NEED_LINK_CONFIG flag only ERROR:CODE_INDENT: code indent should use tabs where possible #129: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4342: +^I^I^I^I ^I* when there is no link thread running.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #129: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4342: +^I^I^I^I ^I* when there is no link thread running.$ ERROR:CODE_INDENT: code indent should use tabs where possible #130: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4343: +^I^I^I^I ^I*/$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #130: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4343: +^I^I^I^I ^I*/$ WARNING:LONG_LINE: line length of 104 exceeds 100 columns #134: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4347: + ixgbe_dev_setup_link_thread_handler, dev) < 0) { WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 100 columns #137: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4350: + /* NOTE: review for potential ordering optimization */ WARNING:LONG_LINE: line length of 107 exceeds 100 columns #138: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4351: + __atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST); total: 4 errors, 10 warnings, 0 checks, 86 lines checked