automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: |WARNING| pw138882 [PATCH v3 06/45] net/hns3: use rte stdatomic API
Date: Wed, 27 Mar 2024 23:40:04 +0100 (CET)	[thread overview]
Message-ID: <20240327224004.CFB8F1223FA@dpdk.org> (raw)
In-Reply-To: <1711579078-10624-7-git-send-email-roretzla@linux.microsoft.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/138882

_coding style issues_


CHECK:SPACING: No space is necessary after a cast
#126: FILE: drivers/net/hns3/hns3_cmd.c:47:
+	static RTE_ATOMIC(uint64_t) hns3_dma_memzone_id;

CHECK:SPACING: No space is necessary after a cast
#214: FILE: drivers/net/hns3/hns3_ethdev.c:102:
+						 RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#214: FILE: drivers/net/hns3/hns3_ethdev.c:102:
+						 RTE_ATOMIC(uint64_t) *levels);
 						                      ^

CHECK:SPACING: No space is necessary after a cast
#304: FILE: drivers/net/hns3/hns3_ethdev.c:5680:
+hns3_get_reset_level(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#304: FILE: drivers/net/hns3/hns3_ethdev.c:5680:
+hns3_get_reset_level(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                     ^

CHECK:SPACING: No space is necessary after a cast
#367: FILE: drivers/net/hns3/hns3_ethdev.h:404:
+	RTE_ATOMIC(uint16_t) schedule;

CHECK:SPACING: No space is necessary after a cast
#370: FILE: drivers/net/hns3/hns3_ethdev.h:406:
+	RTE_ATOMIC(uint16_t) resetting;

CHECK:SPACING: No space is necessary after a cast
#373: FILE: drivers/net/hns3/hns3_ethdev.h:408:
+	RTE_ATOMIC(uint16_t) disable_cmd;

CHECK:SPACING: No space is necessary after a cast
#378: FILE: drivers/net/hns3/hns3_ethdev.h:412:
+	RTE_ATOMIC(uint64_t) pending;

CHECK:SPACING: No space is necessary after a cast
#381: FILE: drivers/net/hns3/hns3_ethdev.h:414:
+	RTE_ATOMIC(uint64_t) request;

CHECK:SPACING: No space is necessary after a cast
#390: FILE: drivers/net/hns3/hns3_ethdev.h:502:
+	RTE_ATOMIC(unsigned int) secondary_cnt; /* Number of secondary processes init'd. */

CHECK:SPACING: No space is necessary after a cast
#399: FILE: drivers/net/hns3/hns3_ethdev.h:847:
+	RTE_ATOMIC(uint16_t) pf_push_lsc_cap;

CHECK:SPACING: No space is necessary after a cast
#408: FILE: drivers/net/hns3/hns3_ethdev.h:856:
+	RTE_ATOMIC(uint16_t) poll_job_started; /* whether poll job is started */

CHECK:SPACING: No space is necessary after a cast
#417: FILE: drivers/net/hns3/hns3_ethdev.h:1000:
+hns3_atomic_test_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#417: FILE: drivers/net/hns3/hns3_ethdev.h:1000:
+hns3_atomic_test_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                     ^

CHECK:SPACING: No space is necessary after a cast
#428: FILE: drivers/net/hns3/hns3_ethdev.h:1009:
+hns3_atomic_set_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#428: FILE: drivers/net/hns3/hns3_ethdev.h:1009:
+hns3_atomic_set_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                    ^

CHECK:SPACING: No space is necessary after a cast
#436: FILE: drivers/net/hns3/hns3_ethdev.h:1015:
+hns3_atomic_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#436: FILE: drivers/net/hns3/hns3_ethdev.h:1015:
+hns3_atomic_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                      ^

CHECK:SPACING: No space is necessary after a cast
#444: FILE: drivers/net/hns3/hns3_ethdev.h:1021:
+hns3_test_and_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#444: FILE: drivers/net/hns3/hns3_ethdev.h:1021:
+hns3_test_and_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                        ^

CHECK:SPACING: No space is necessary after a cast
#462: FILE: drivers/net/hns3/hns3_ethdev_vf.c:40:
+						    RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#462: FILE: drivers/net/hns3/hns3_ethdev_vf.c:40:
+						    RTE_ATOMIC(uint64_t) *levels);
 						                         ^

CHECK:SPACING: No space is necessary after a cast
#646: FILE: drivers/net/hns3/hns3_ethdev_vf.c:2033:
+hns3vf_get_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#646: FILE: drivers/net/hns3/hns3_ethdev_vf.c:2033:
+hns3vf_get_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)
                                                                 ^

CHECK:SPACING: No space is necessary after a cast
#691: FILE: drivers/net/hns3/hns3_intr.c:2036:
+		     int num, RTE_ATOMIC(uint64_t) *levels,

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#691: FILE: drivers/net/hns3/hns3_intr.c:2036:
+		     int num, RTE_ATOMIC(uint64_t) *levels,
 		                                   ^

CHECK:SPACING: No space is necessary after a cast
#700: FILE: drivers/net/hns3/hns3_intr.c:2107:
+hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#700: FILE: drivers/net/hns3/hns3_intr.c:2107:
+hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                       ^

CHECK:SPACING: No space is necessary after a cast
#709: FILE: drivers/net/hns3/hns3_intr.c:2154:
+hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#709: FILE: drivers/net/hns3/hns3_intr.c:2154:
+hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                      ^

CHECK:SPACING: No space is necessary after a cast
#773: FILE: drivers/net/hns3/hns3_intr.c:2540:
+hns3_clear_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#773: FILE: drivers/net/hns3/hns3_intr.c:2540:
+hns3_clear_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)
                                                                 ^

CHECK:SPACING: No space is necessary after a cast
#823: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#823: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);
                                                                            ^

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#823: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: No space is necessary after a cast
#824: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#824: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);
                                                                           ^

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#824: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

total: 0 errors, 2 warnings, 37 checks, 722 lines checked

           reply	other threads:[~2024-03-27 22:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1711579078-10624-7-git-send-email-roretzla@linux.microsoft.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240327224004.CFB8F1223FA@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).