From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: |WARNING| pw138878 [PATCH v3 01/45] net/mlx5: use rte stdatomic API
Date: Wed, 27 Mar 2024 23:40:22 +0100 (CET) [thread overview]
Message-ID: <20240327224022.B41F71223FA@dpdk.org> (raw)
In-Reply-To: <1711579078-10624-2-git-send-email-roretzla@linux.microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/138878
_coding style issues_
CHECK:SPACING: No space is necessary after a cast
#222: FILE: drivers/net/mlx5/mlx5.h:381:
+ RTE_ATOMIC(uint16_t) refcnt; /* Reference count for representors. */
CHECK:SPACING: No space is necessary after a cast
#231: FILE: drivers/net/mlx5/mlx5.h:484:
+ RTE_ATOMIC(uint16_t) state; /**< Age state (atomically accessed). */
CHECK:SPACING: No space is necessary after a cast
#235: FILE: drivers/net/mlx5/mlx5.h:487:
+ RTE_ATOMIC(uint32_t) sec_since_last_hit;
CHECK:SPACING: No space is necessary after a cast
#244: FILE: drivers/net/mlx5/mlx5.h:500:
+ RTE_ATOMIC(uint32_t) refcnt; /* Only for shared action management. */
CHECK:SPACING: No space is necessary after a cast
#253: FILE: drivers/net/mlx5/mlx5.h:591:
+ volatile RTE_ATOMIC(uint16_t) n_valid; /* Number of valid pools. */
CHECK:SPACING: No space is necessary after a cast
#262: FILE: drivers/net/mlx5/mlx5.h:657:
+ RTE_ATOMIC(uint32_t) refcnt;
CHECK:SPACING: No space is necessary after a cast
#271: FILE: drivers/net/mlx5/mlx5.h:691:
+ RTE_ATOMIC(uint32_t) refcnt; /* geneve tlv object reference counter */
CHECK:SPACING: No space is necessary after a cast
#280: FILE: drivers/net/mlx5/mlx5.h:906:
+ RTE_ATOMIC(uint32_t) ref_cnt;
CHECK:SPACING: No space is necessary after a cast
#289: FILE: drivers/net/mlx5/mlx5.h:1041:
+ RTE_ATOMIC(uint32_t) ref_cnt; /**< Use count. */
CHECK:SPACING: No space is necessary after a cast
#298: FILE: drivers/net/mlx5/mlx5.h:1081:
+ RTE_ATOMIC(uint8_t) state; /**< ASO flow meter state. */
CHECK:SPACING: No space is necessary after a cast
#307: FILE: drivers/net/mlx5/mlx5.h:1127:
+ RTE_ATOMIC(uint32_t) def_policy_ref_cnt;
CHECK:SPACING: No space is necessary after a cast
#317: FILE: drivers/net/mlx5/mlx5.h:1200:
+ RTE_ATOMIC(uint64_t) ci_ts;
CHECK:SPACING: No space is necessary after a cast
#318: FILE: drivers/net/mlx5/mlx5.h:1201:
+ RTE_ATOMIC(uint64_t) ts;
CHECK:SPACING: No space is necessary after a cast
#332: FILE: drivers/net/mlx5/mlx5.h:1224:
+ RTE_ATOMIC(uint64_t) err_miss_int; /* Missed service interrupt. */
CHECK:SPACING: No space is necessary after a cast
#333: FILE: drivers/net/mlx5/mlx5.h:1225:
+ RTE_ATOMIC(uint64_t) err_rearm_queue; /* Rearm Queue errors. */
CHECK:SPACING: No space is necessary after a cast
#334: FILE: drivers/net/mlx5/mlx5.h:1226:
+ RTE_ATOMIC(uint64_t) err_clock_queue; /* Clock Queue errors. */
CHECK:SPACING: No space is necessary after a cast
#335: FILE: drivers/net/mlx5/mlx5.h:1227:
+ RTE_ATOMIC(uint64_t) err_ts_past; /* Timestamp in the past. */
CHECK:SPACING: No space is necessary after a cast
#336: FILE: drivers/net/mlx5/mlx5.h:1228:
+ RTE_ATOMIC(uint64_t) err_ts_future; /* Timestamp in the distant future. */
CHECK:SPACING: No space is necessary after a cast
#337: FILE: drivers/net/mlx5/mlx5.h:1229:
+ RTE_ATOMIC(uint64_t) err_ts_order; /* Timestamp not in ascending order. */
CHECK:SPACING: No space is necessary after a cast
#346: FILE: drivers/net/mlx5/mlx5.h:1290:
+ RTE_ATOMIC(uint32_t) refcnt; /* Action used count in device flows. */
CHECK:SPACING: No space is necessary after a cast
#350: FILE: drivers/net/mlx5/mlx5.h:1293:
+ RTE_ATOMIC(enum mlx5_aso_ct_state) state; /* ASO CT state. */
CHECK:SPACING: No space is necessary after a cast
#366: FILE: drivers/net/mlx5/mlx5.h:1373:
+ RTE_ATOMIC(uint32_t) refcnt; /* Atomically accessed refcnt by flows. */
CHECK:SPACING: No space is necessary after a cast
#375: FILE: drivers/net/mlx5/mlx5.h:1386:
+ RTE_ATOMIC(uint32_t) refcnt;
CHECK:SPACING: No space is necessary after a cast
#386: FILE: drivers/net/mlx5/mlx5.h:1515:
+ RTE_ATOMIC(struct mlx5_hlist *) encaps_decaps; /* Encap/decap action hash list. */
CHECK:SPACING: No space is necessary after a cast
#387: FILE: drivers/net/mlx5/mlx5.h:1516:
+ RTE_ATOMIC(struct mlx5_hlist *) modify_cmds;
CHECK:SPACING: No space is necessary after a cast
#388: FILE: drivers/net/mlx5/mlx5.h:1517:
+ RTE_ATOMIC(struct mlx5_hlist *) tag_table;
CHECK:SPACING: No space is necessary after a cast
#397: FILE: drivers/net/mlx5/mlx5.h:1528:
+ RTE_ATOMIC(struct mlx5_indexed_pool *) mdh_ipools[MLX5_MAX_MODIFY_NUM];
CHECK:SPACING: No space is necessary after a cast
#406: FILE: drivers/net/mlx5/mlx5.h:1573:
+ RTE_ATOMIC(void *) hca_bar;
CHECK:SPACING: No space is necessary after a cast
#415: FILE: drivers/net/mlx5/mlx5.h:1638:
+ RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */
CHECK:SPACING: No space is necessary after a cast
#424: FILE: drivers/net/mlx5/mlx5.h:1829:
+ RTE_ATOMIC(uint8_t) state; /* object state */
CHECK:SPACING: No space is necessary after a cast
#433: FILE: drivers/net/mlx5/mlx5.h:1958:
+ RTE_ATOMIC(uint32_t) hws_mark_refcnt; /* HWS mark action reference counter. */
CHECK:SPACING: No space is necessary after a cast
#442: FILE: drivers/net/mlx5/mlx5.h:2010:
+ RTE_ATOMIC(uint16_t) shared_refcnt; /* HW steering host reference counter. */
CHECK:SPACING: No space is necessary after a cast
#559: FILE: drivers/net/mlx5/mlx5_flow.h:1052:
+ RTE_ATOMIC(uint32_t) refctn;
CHECK:SPACING: No space is necessary after a cast
#568: FILE: drivers/net/mlx5/mlx5_flow.h:1473:
+ RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */
CHECK:SPACING: No space is necessary after a cast
#577: FILE: drivers/net/mlx5/mlx5_flow.h:1505:
+ RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */
CHECK:SPACING: No space is necessary after a cast
#586: FILE: drivers/net/mlx5/mlx5_flow.h:1858:
+ RTE_ATOMIC(uint32_t) refcnt; /**< Atomically accessed refcnt. */
CHECK:SPACING: No space is necessary after a cast
#734: FILE: drivers/net/mlx5/mlx5_flow_dv.c:316:
+flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, RTE_ATOMIC(struct mlx5_hlist *) *phl,
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#734: FILE: drivers/net/mlx5/mlx5_flow_dv.c:316:
+flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, RTE_ATOMIC(struct mlx5_hlist *) *phl,
^
CHECK:SPACING: No space is necessary after a cast
#1679: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:104:
+ RTE_ATOMIC(uint32_t) query_gen __rte_cache_aligned;
CHECK:SPACING: No space is necessary after a cast
#1689: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:137:
+ RTE_ATOMIC(uint32_t) timeout; /* Aging timeout in seconds (atomically accessed). */
CHECK:SPACING: No space is necessary after a cast
#1690: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:138:
+ RTE_ATOMIC(uint32_t) sec_since_last_hit;
CHECK:SPACING: No space is necessary after a cast
#1693: FILE: drivers/net/mlx5/mlx5_hws_cnt.h:140:
+ RTE_ATOMIC(uint16_t) state; /* AGE state (atomically accessed). */
CHECK:SPACING: No space is necessary after a cast
#1715: FILE: drivers/net/mlx5/mlx5_rx.h:176:
+ RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */
CHECK:SPACING: No space is necessary after a cast
#1724: FILE: drivers/net/mlx5/mlx5_rx.h:191:
+ RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */
CHECK:SPACING: No space is necessary after a cast
#1899: FILE: drivers/net/mlx5/mlx5_tx.h:182:
+ RTE_ATOMIC(uint32_t) refcnt; /* Reference counter. */
CHECK:SPACING: No space is necessary after a cast
#2221: FILE: drivers/net/mlx5/mlx5_utils.h:243:
+ volatile RTE_ATOMIC(uint32_t) n_trunk_valid; /* Trunks allocated. */
CHECK:SPACING: No space is necessary after a cast
#2230: FILE: drivers/net/mlx5/mlx5_utils.h:269:
+ RTE_ATOMIC(struct mlx5_indexed_cache *) gc;
total: 0 errors, 0 warnings, 47 checks, 1840 lines checked
Please use __rte_cache_aligned only for struct or union types alignment.
parent reply other threads:[~2024-03-27 22:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1711579078-10624-2-git-send-email-roretzla@linux.microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327224022.B41F71223FA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).