From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw138993 [PATCH v19 13/15] log: add optional support of syslog
Date: Sat, 30 Mar 2024 04:08:08 +0100 (CET) [thread overview]
Message-ID: <20240330030808.11E111223FC@dpdk.org> (raw)
In-Reply-To: <20240330030429.4630-14-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/138993
_coding style issues_
WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#114: FILE: app/test/test_eal_flags.c:990:
+ const char *argv4[] = {prgname, prefix, mp_flag, "--syslog=both"};
WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#117: FILE: app/test/test_eal_flags.c:992:
+ const char *argv5[] = {prgname, prefix, mp_flag, "--syslog=invalid"};
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#263: FILE: lib/log/log.c:520:
+ else
[...]
if (log_timestamp_enabled())
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#291: FILE: lib/log/log_stubs.c:5:
+#include <stdio.h>
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#323: FILE: lib/log/log_syslog.c:3:
+#include <stdio.h>
total: 0 errors, 5 warnings, 243 lines checked
parent reply other threads:[~2024-03-30 3:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240330030429.4630-14-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240330030808.11E111223FC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).