From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6EB2D43D8B
	for <public@inbox.dpdk.org>; Sat, 30 Mar 2024 04:08:11 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5E46140A6B;
	Sat, 30 Mar 2024 04:08:11 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 2E72E402C6
 for <test-report@dpdk.org>; Sat, 30 Mar 2024 04:08:08 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 11E111223FC; Sat, 30 Mar 2024 04:08:08 +0100 (CET)
Subject: |WARNING| pw138993 [PATCH v19 13/15] log: add optional support of
 syslog
In-Reply-To: <20240330030429.4630-14-stephen@networkplumber.org>
References: <20240330030429.4630-14-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20240330030808.11E111223FC@dpdk.org>
Date: Sat, 30 Mar 2024 04:08:08 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/138993

_coding style issues_


WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#114: FILE: app/test/test_eal_flags.c:990:
+	const char *argv4[] = {prgname, prefix, mp_flag, "--syslog=both"};

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#117: FILE: app/test/test_eal_flags.c:992:
+	const char *argv5[] = {prgname, prefix, mp_flag, "--syslog=invalid"};

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#263: FILE: lib/log/log.c:520:
+	else
[...]
 	if (log_timestamp_enabled())

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#291: FILE: lib/log/log_stubs.c:5:
+#include <stdio.h>

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#323: FILE: lib/log/log_syslog.c:3:
+#include <stdio.h>

total: 0 errors, 5 warnings, 243 lines checked