From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gongming Chen <chengongming1900@outlook.com>
Subject: |WARNING| pw139065 [PATCH] vhost: fix crash caused by accessing a freed vsocket
Date: Wed, 3 Apr 2024 04:32:01 +0200 (CEST) [thread overview]
Message-ID: <20240403023201.BB9C91223FE@dpdk.org> (raw)
In-Reply-To: <TYAP286MB0649F3ED07287A216D85E18CD83D2@TYAP286MB0649.JPNP286.PROD.OUTLOOK.COM>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139065
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#153: FILE: lib/vhost/fd_man.c:254:
+ vhost_thread_read_lock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: lib/vhost/fd_man.c:254:
+ vhost_thread_read_lock();$
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: lib/vhost/fd_man.c:308:
+ vhost_thread_read_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: lib/vhost/fd_man.c:308:
+ vhost_thread_read_unlock();$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#192: FILE: lib/vhost/socket.c:466:
while (1) {
+ vhost_thread_read_lock();
ERROR:CODE_INDENT: code indent should use tabs where possible
#193: FILE: lib/vhost/socket.c:467:
+ vhost_thread_read_lock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#193: FILE: lib/vhost/socket.c:467:
+ vhost_thread_read_lock();$
ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: lib/vhost/socket.c:499:
+ vhost_thread_read_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: lib/vhost/socket.c:499:
+ vhost_thread_read_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#210: FILE: lib/vhost/socket.c:1077:
+ vhost_thread_write_lock();$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#216: FILE: lib/vhost/socket.c:1087:
} else if (vsocket->is_server) {
[...]
+ fdset_del(&vhost_user.fdset, vsocket->socket_fd);
ERROR:CODE_INDENT: code indent should use tabs where possible
#221: FILE: lib/vhost/socket.c:1089:
+ * The vhost thread write lock has been acquired,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: lib/vhost/socket.c:1090:
+ * and fd must be deleted from fdset.$
ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: lib/vhost/socket.c:1092:
+ fdset_del(&vhost_user.fdset, vsocket->socket_fd);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: lib/vhost/socket.c:1092:
+ fdset_del(&vhost_user.fdset, vsocket->socket_fd);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: lib/vhost/socket.c:1104:
+ * The vhost thread write lock has been acquired,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#241: FILE: lib/vhost/socket.c:1105:
+ * and fd must be deleted from fdset.$
ERROR:CODE_INDENT: code indent should use tabs where possible
#249: FILE: lib/vhost/socket.c:1107:
+ fdset_del(&vhost_user.fdset, conn->connfd);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: lib/vhost/socket.c:1107:
+ fdset_del(&vhost_user.fdset, conn->connfd);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#257: FILE: lib/vhost/socket.c:1129:
+ vhost_thread_write_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#257: FILE: lib/vhost/socket.c:1129:
+ vhost_thread_write_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: lib/vhost/socket.c:1133:
+ vhost_thread_write_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#284: FILE: lib/vhost/vhost_thread.c:14:
+ rte_rwlock_read_lock(&vhost_thread_lock);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#290: FILE: lib/vhost/vhost_thread.c:20:
+ rte_rwlock_read_unlock(&vhost_thread_lock);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#296: FILE: lib/vhost/vhost_thread.c:26:
+ rte_rwlock_write_lock(&vhost_thread_lock);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: lib/vhost/vhost_thread.c:32:
+ rte_rwlock_write_unlock(&vhost_thread_lock);$
WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Gongming Chen <chengongming1900@outlook.com>' != 'Signed-off-by: Gongming Chen <chengm11@chinatelecom.cn>'
total: 11 errors, 16 warnings, 154 lines checked
next prev parent reply other threads:[~2024-04-03 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <TYAP286MB0649F3ED07287A216D85E18CD83D2@TYAP286MB0649.JPNP286.PROD.OUTLOOK.COM>
2024-04-03 2:07 ` qemudev
2024-04-03 2:32 ` checkpatch [this message]
2024-04-03 2:53 ` dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403023201.BB9C91223FE@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=chengongming1900@outlook.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).