|WARNING| pw139066 [PATCH] vhost: fix crash caused by accessing a freed vsocket

|WARNING| pw139066 [PATCH] vhost: fix crash caused by accessing a freed vsocket

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/139066

_apply patch failure_

Submitter: Gongming Chen <chengongming1900@outlook.com>
Date: Wed, 3 Apr 2024 02:57:18 +0000
DPDK git baseline: Repo:dpdk-next-virtio
  Branch: main
  CommitID: deedfb86a7a6e10064d3cccd593f62072de96e36

Apply patch set 139066 failed:

Checking patch lib/vhost/fd_man.c...
error: while searching for:
                if (val < 0)
                        continue;

                need_shrink = 0;
                for (i = 0; i < numfds; i++) {
                        pthread_mutex_lock(&pfdset->fd_mutex);

error: patch failed: lib/vhost/fd_man.c:250
error: lib/vhost/fd_man.c: patch does not apply
Checking patch lib/vhost/meson.build...
Checking patch lib/vhost/socket.c...
error: while searching for:
        struct vhost_user_reconnect *reconn, *next;

        while (1) {
                pthread_mutex_lock(&reconn_list.mutex);

                /*

error: patch failed: lib/vhost/socket.c:463
error: lib/vhost/socket.c: patch does not apply
Checking patch lib/vhost/vhost_thread.c...
Checking patch lib/vhost/vhost_thread.h...

|WARNING| pw139066 [PATCH] vhost: fix crash caused by accessing a freed vsocket

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139066

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/vhost/fd_man.c:254:
+               vhost_thread_read_lock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: lib/vhost/fd_man.c:254:
+               vhost_thread_read_lock();$

ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: lib/vhost/fd_man.c:308:
+               vhost_thread_read_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: lib/vhost/fd_man.c:308:
+               vhost_thread_read_unlock();$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#194: FILE: lib/vhost/socket.c:466:
         while (1) {
+               vhost_thread_read_lock();

ERROR:CODE_INDENT: code indent should use tabs where possible
#195: FILE: lib/vhost/socket.c:467:
+               vhost_thread_read_lock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: lib/vhost/socket.c:467:
+               vhost_thread_read_lock();$

ERROR:CODE_INDENT: code indent should use tabs where possible
#203: FILE: lib/vhost/socket.c:499:
+               vhost_thread_read_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: lib/vhost/socket.c:499:
+               vhost_thread_read_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#212: FILE: lib/vhost/socket.c:1077:
+       vhost_thread_write_lock();$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#218: FILE: lib/vhost/socket.c:1087:
                 } else if (vsocket->is_server) {
[...]
+                       fdset_del(&vhost_user.fdset, vsocket->socket_fd);

ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: lib/vhost/socket.c:1089:
+                        * The vhost thread write lock has been acquired,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: lib/vhost/socket.c:1090:
+                        * and fd must be deleted from fdset.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: lib/vhost/socket.c:1092:
+                       fdset_del(&vhost_user.fdset, vsocket->socket_fd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: lib/vhost/socket.c:1092:
+                       fdset_del(&vhost_user.fdset, vsocket->socket_fd);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#242: FILE: lib/vhost/socket.c:1104:
+                        * The vhost thread write lock has been acquired,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#243: FILE: lib/vhost/socket.c:1105:
+                        * and fd must be deleted from fdset.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#251: FILE: lib/vhost/socket.c:1107:
+                       fdset_del(&vhost_user.fdset, conn->connfd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: lib/vhost/socket.c:1107:
+                       fdset_del(&vhost_user.fdset, conn->connfd);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#259: FILE: lib/vhost/socket.c:1129:
+               vhost_thread_write_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#259: FILE: lib/vhost/socket.c:1129:
+               vhost_thread_write_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: lib/vhost/socket.c:1133:
+       vhost_thread_write_unlock();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: lib/vhost/vhost_thread.c:14:
+       rte_rwlock_read_lock(&vhost_thread_lock);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#292: FILE: lib/vhost/vhost_thread.c:20:
+       rte_rwlock_read_unlock(&vhost_thread_lock);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: lib/vhost/vhost_thread.c:26:
+       rte_rwlock_write_lock(&vhost_thread_lock);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: lib/vhost/vhost_thread.c:32:
+       rte_rwlock_write_unlock(&vhost_thread_lock);$

total: 11 errors, 15 warnings, 154 lines checked

|WARNING| pw139066 [PATCH] vhost: fix crash caused by accessing a freed vsocket

[dpdklab]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/139066

_apply patch failure_

Submitter: Gongming Chen <chengongming1900@outlook.com>
Date: Wednesday, April 03 2024 02:57:18 
Applied on: CommitID:e2e546ab5bf5e024986ccb5310ab43982f3bb40c
Apply patch set 139066 failed:

Cloning the DPDK mirror at: https://github.com/DPDK/dpdk.git (Attempt 1 of 3)
Trying to checkout branch: origin/main
Checked out to main (e2e546ab5bf5e024986ccb5310ab43982f3bb40c)
Done: main commit e2e546ab5bf5e024986ccb5310ab43982f3bb40c
Trying to checkout branch: origin/next-virtio-for-next-net
Checked out to next-virtio-for-next-net (deedfb86a7a6e10064d3cccd593f62072de96e36)
Applying patch...

Failed to apply patch:
Applying: vhost: fix crash caused by accessing a freed vsocket
error: patch failed: lib/vhost/fd_man.c:250
error: lib/vhost/fd_man.c: patch does not apply
error: patch failed: lib/vhost/socket.c:463
error: lib/vhost/socket.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Using index info to reconstruct a base tree...
Patch failed at 0001 vhost: fix crash caused by accessing a freed vsocket
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Trying to checkout branch: origin/main
Checked out to main (e2e546ab5bf5e024986ccb5310ab43982f3bb40c)
Applying patch...

Failed to apply patch:
Applying: vhost: fix crash caused by accessing a freed vsocket
error: patch failed: lib/vhost/fd_man.c:250
error: lib/vhost/fd_man.c: patch does not apply
error: patch failed: lib/vhost/socket.c:463
error: lib/vhost/socket.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Using index info to reconstruct a base tree...
Patch failed at 0001 vhost: fix crash caused by accessing a freed vsocket
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


https://lab.dpdk.org/results/dashboard/patchsets/29697/

UNH-IOL DPDK Community Lab