* |WARNING| pw139282 [PATCH v4] net/netvsc: fix number Tx queues > Rx queues
[not found] <PA4PR83MB05261AB024A2F6A286CBF22E97092@PA4PR83MB0526.EURPRD83.prod.outlook.com>
2024-04-15 14:16 ` |WARNING| pw139282 [PATCH v4] net/netvsc: fix number Tx queues > Rx queues qemudev
@ 2024-04-15 14:41 ` checkpatch
1 sibling, 0 replies; 2+ messages in thread
From: checkpatch @ 2024-04-15 14:41 UTC (permalink / raw)
To: test-report; +Cc: Alan Elder
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139282
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#116:
The previous code allowed the number of Tx queues to be set higher than the number of Rx queues. If a packet was sent on a Tx queue with index
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#159: FILE: :316:
+ /*
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#160: FILE: :317:
+ * If there are more Tx queues than Rx queues, allocate rx_queues
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#161: FILE: :318:
+ * with event buffer so that Tx completion messages can still be
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#162: FILE: :319:
+ * received
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#163: FILE: :320:
+ */
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#164: FILE: :321:
+ if (queue_idx >= dev->data->nb_rx_queues) {
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#165: FILE: :322:
+ rxq = hn_rx_queue_alloc(hv, queue_idx, socket_id);
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#166: FILE: :323:
+
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#167: FILE: :324:
+ if (!rxq) {
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#168: FILE: :325:
+ err = -ENOMEM;
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#169: FILE: :326:
+ goto error;
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#170: FILE: :327:
+ }
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#171: FILE: :328:
+
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#172: FILE: :329:
+ /*
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#173: FILE: :330:
+ * Don't allocate mbuf pool or rx ring. RSS is always configured
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#174: FILE: :331:
+ * to ensure packets aren't received by this Rx queue.
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#175: FILE: :332:
+ */
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#176: FILE: :333:
+ rxq->mb_pool = NULL;
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#177: FILE: :334:
+ rxq->rx_ring = NULL;
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#178: FILE: :335:
+ }
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#179: FILE: :336:
+
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#202: FILE: :403:
+ /*
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#203: FILE: :404:
+ * Free any Rx queues allocated for a Tx queue without a corresponding
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#204: FILE: :405:
+ * Rx queue
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#205: FILE: :406:
+ */
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#206: FILE: :407:
+ if (qid >= dev->data->nb_rx_queues)
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#207: FILE: :408:
+ hn_rx_queue_free_common(dev->data->rx_queues[qid]);
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#208: FILE: :409:
+
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#217: FILE: :598:
+ struct rte_mbuf *m = NULL;
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#221: FILE: :601:
+ if (likely(rxq->mb_pool != NULL))
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#222: FILE: :602:
+ m = rte_pktmbuf_alloc(rxq->mb_pool);
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#223: FILE: :603:
+
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#232: FILE: :990:
+ /*
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#233: FILE: :991:
+ * If the number of Tx queues was previously greater than the
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#234: FILE: :992:
+ * number of Rx queues, we may already have allocated an rxq.
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#235: FILE: :993:
+ */
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#236: FILE: :994:
+ if (!dev->data->rx_queues[queue_idx])
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#237: FILE: :995:
+ rxq = hn_rx_queue_alloc(hv, queue_idx, socket_id);
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#238: FILE: :996:
+ else
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#239: FILE: :997:
+ rxq = dev->data->rx_queues[queue_idx];
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#240: FILE: :998:
+
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#251: FILE: :1031:
+ /* Only free rxq if it was created in this function. */
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#252: FILE: :1032:
+ if (!dev->data->rx_queues[queue_idx])
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#253: FILE: :1033:
+ hn_rx_queue_free_common(rxq);
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#254: FILE: :1034:
+
WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#265: FILE: :1055:
+ hn_rx_queue_free_common(rxq);
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#297: FILE: drivers/net/netvsc/hn_rxtx.c:237:
+static void
+hn_rx_queue_free_common(struct hn_rx_queue *rxq) {
total: 1 errors, 47 warnings, 0 checks, 125 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread