From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CC36343EDA
	for <public@inbox.dpdk.org>; Mon, 22 Apr 2024 15:51:19 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C6353402D9;
	Mon, 22 Apr 2024 15:51:19 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8B4054021F
 for <test-report@dpdk.org>; Mon, 22 Apr 2024 15:51:18 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 75850121EF1; Mon, 22 Apr 2024 15:51:18 +0200 (CEST)
Subject: |WARNING| pw139608 [PATCH] eal/linux: enhanced error handling for
 affinity
In-Reply-To: <20240422134917.3740545-1-ferruh.yigit@amd.com>
References: <20240422134917.3740545-1-ferruh.yigit@amd.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>
Message-Id: <20240422135118.75850121EF1@dpdk.org>
Date: Mon, 22 Apr 2024 15:51:18 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139608

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#166: FILE: lib/eal/unix/rte_thread.c:119:
+static void cpuset_to_string(const cpu_set_t *cpuset,
+			char *cpus_str, size_t cpus_str_size) {

ERROR:C99_COMMENTS: do not use C99 // comments
#169: FILE: lib/eal/unix/rte_thread.c:122:
+	// Track the current position in the string

ERROR:C99_COMMENTS: do not use C99 // comments
#172: FILE: lib/eal/unix/rte_thread.c:125:
+	// Clear the string buffer

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#174: FILE: lib/eal/unix/rte_thread.c:127:
+	cpus_str_size = RTE_MAX_LCORE < cpus_str_size ?

ERROR:C99_COMMENTS: do not use C99 // comments
#177: FILE: lib/eal/unix/rte_thread.c:130:
+	// Iterate over each CPU core, and check if it is included in the set

ERROR:C99_COMMENTS: do not use C99 // comments
#180: FILE: lib/eal/unix/rte_thread.c:133:
+			// Append the current CPU number to the string

ERROR:C99_COMMENTS: do not use C99 // comments
#190: FILE: lib/eal/unix/rte_thread.c:143:
+	// Ensure the string is properly terminated

total: 6 errors, 1 warnings, 76 lines checked