From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A16743F76 for ; Fri, 3 May 2024 16:03:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24E7C402DE; Fri, 3 May 2024 16:03:45 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id B3455402D6 for ; Fri, 3 May 2024 16:03:43 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 9EA64122141; Fri, 3 May 2024 16:03:43 +0200 (CEST) Subject: |WARNING| pw139854 [PATCH v2 26/27] net/ixgbe/base: enable E610 device support In-Reply-To: References: To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20240503140343.9EA64122141@dpdk.org> Date: Fri, 3 May 2024 16:03:43 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/139854 _coding style issues_ ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #229: FILE: drivers/net/ixgbe/base/ixgbe_api.c:1738: +s32 ixgbe_get_nvm_ver(struct ixgbe_hw* hw, struct ixgbe_nvm_info *nvm) CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #249: FILE: drivers/net/ixgbe/base/ixgbe_api.h:21: +extern s32 ixgbe_init_ops_E610(struct ixgbe_hw *hw); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #376: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:408: + * ixgbe_aci_get_fw_ver - get the firmware version WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #379: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:411: + * Get the firmware version using ACI command (0x0001). WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #383: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:415: +s32 ixgbe_aci_get_fw_ver(struct ixgbe_hw *hw) WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #385: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:417: + struct ixgbe_aci_cmd_get_ver *resp; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #386: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:418: + struct ixgbe_aci_desc desc; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #391: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:423: + ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_get_ver); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #393: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:425: + status = ixgbe_aci_send_cmd(hw, &desc, NULL, 0); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #411: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:443: + * ixgbe_aci_send_driver_ver - send the driver version to firmware WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #416: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:448: + * using the ACI command (0x0002). WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #421: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:453: +s32 ixgbe_aci_send_driver_ver(struct ixgbe_hw *hw, struct ixgbe_driver_ver *dv) WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #423: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:455: + struct ixgbe_aci_cmd_driver_ver *cmd; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #424: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:456: + struct ixgbe_aci_desc desc; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #432: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:464: + ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_driver_ver); WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #434: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:466: + desc.flags |= IXGBE_CPU_TO_LE16(IXGBE_ACI_FLAG_RD); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #445: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:477: + return ixgbe_aci_send_cmd(hw, &desc, dv->driver_string, len); WARNING:LEADING_SPACE: please, no spaces at the start of a line #505: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1949: + }$ WARNING:BRACES: braces {} are not necessary for single statement blocks #548: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1992: + if (!start) { + return IXGBE_ERR_PARAM; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #709: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2153: + if (status) { + return status; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #718: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2162: + if (status) { + return status; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #723: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2167: + if (status) { + return status; + } WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #757: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2219: + * ixgbe_read_sr_buf_aci - Reads Shadow RAM buf via ACI WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #757: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2219: + * ixgbe_read_sr_buf_aci - Reads Shadow RAM buf via ACI WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #768: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2230: +s32 ixgbe_read_sr_buf_aci(struct ixgbe_hw *hw, u16 offset, u16 *words, WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #829: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2351: + mac->ops.get_fw_version = ixgbe_aci_get_fw_ver; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #842: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2364: + eeprom->ops.read = ixgbe_read_ee_aci_E610; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #843: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2365: + eeprom->ops.read_buffer = ixgbe_read_ee_aci_buffer_E610; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1016: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2601: + struct ixgbe_aci_cmd_get_phy_caps_data pcaps; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1020: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2605: + rc = ixgbe_aci_get_phy_caps(hw, false, IXGBE_ACI_REPORT_TOPO_CAP_MEDIA, WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1020: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2605: + rc = ixgbe_aci_get_phy_caps(hw, false, IXGBE_ACI_REPORT_TOPO_CAP_MEDIA, ERROR:SPACING: space required before the open parenthesis '(' #1026: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2611: + if(phy_type & IXGBE_PHY_TYPE_LOW_10GBASE_T) ERROR:SPACING: space required before the open parenthesis '(' #1028: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2613: + if(phy_type & IXGBE_PHY_TYPE_LOW_1000BASE_T) ERROR:SPACING: space required before the open parenthesis '(' #1030: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2615: + if(phy_type & IXGBE_PHY_TYPE_LOW_100BASE_TX) ERROR:SPACING: space required before the open parenthesis '(' #1032: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2617: + if(phy_type & IXGBE_PHY_TYPE_LOW_10GBASE_LR) ERROR:SPACING: space required before the open parenthesis '(' #1034: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2619: + if(phy_type & IXGBE_PHY_TYPE_LOW_10GBASE_SR) ERROR:SPACING: space required before the open parenthesis '(' #1036: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2621: + if(phy_type & IXGBE_PHY_TYPE_LOW_1000BASE_KX) ERROR:SPACING: space required before the open parenthesis '(' #1038: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2623: + if(phy_type & IXGBE_PHY_TYPE_LOW_10GBASE_KR_CR1) ERROR:SPACING: space required before the open parenthesis '(' #1040: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2625: + if(phy_type & IXGBE_PHY_TYPE_LOW_1000BASE_SX) ERROR:SPACING: space required before the open parenthesis '(' #1042: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2627: + if(phy_type & IXGBE_PHY_TYPE_LOW_2500BASE_KX) ERROR:SPACING: space required before the open parenthesis '(' #1044: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2629: + if(phy_type & IXGBE_PHY_TYPE_LOW_2500BASE_T) ERROR:SPACING: space required before the open parenthesis '(' #1046: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2631: + if(phy_type & IXGBE_PHY_TYPE_LOW_5GBASE_T) ERROR:SPACING: space required before the open parenthesis '(' #1050: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2635: + if(phy_type & IXGBE_PHY_TYPE_HIGH_10BASE_T) WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1073: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2919: + * Send driver version number to Firmware using ACI command (0x0002). WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1078: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2924: + * IXGBE_ERR_ACI_ERROR - encountered an error during sending the command WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1079: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2925: + * IXGBE_ERR_ACI_TIMEOUT - a timeout occurred WARNING:MINMAX: min() should probably be min_t(u16, len, IXGBE_DRV_VER_STR_LEN_E610) #1085: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2931: + size_t limited_len = min(len, (u16)IXGBE_DRV_VER_STR_LEN_E610); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1101: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2947: + return ixgbe_aci_send_driver_ver(hw, &dv); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1122: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3002: + struct ixgbe_aci_cmd_get_phy_caps_data phy_caps = { 0 }; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1123: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3003: + struct ixgbe_aci_cmd_set_phy_cfg_data phy_cfg = { 0 }; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1127: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3007: + status = ixgbe_aci_get_phy_caps(hw, false, WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1128: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3008: + IXGBE_ACI_REPORT_ACTIVE_CFG, &phy_caps); WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1134: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3014: + phy_cfg.caps |= IXGBE_ACI_PHY_ENA_LINK; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1135: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3015: + phy_cfg.caps |= IXGBE_ACI_PHY_ENA_AUTO_LINK_UPDT; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1139: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3019: + eee_cap |= IXGBE_ACI_PHY_EEE_EN_100BASE_TX; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1141: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3021: + eee_cap |= IXGBE_ACI_PHY_EEE_EN_1000BASE_T; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1143: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3023: + eee_cap |= IXGBE_ACI_PHY_EEE_EN_1000BASE_KX; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1145: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3025: + eee_cap |= IXGBE_ACI_PHY_EEE_EN_10GBASE_T; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1147: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3027: + eee_cap |= IXGBE_ACI_PHY_EEE_EN_10GBASE_KR; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1151: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3031: + eee_cap |= IXGBE_ACI_PHY_EEE_EN_25GBASE_KR; WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1154: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3034: + eee_cap |= IXGBE_ACI_PHY_EEE_EN_10BASE_T; WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1160: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3040: + status = ixgbe_aci_set_phy_cfg(hw, &phy_cfg); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1244: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3606: + * ixgbe_read_ee_aci_buffer_E610- Read EEPROM word(s) using admin commands. WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1250: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3612: + * Reads a 16 bit word(s) from the EEPROM using the ACI. WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1257: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3619: +s32 ixgbe_read_ee_aci_buffer_E610(struct ixgbe_hw *hw, u16 offset, WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1272: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3634: + status = ixgbe_read_sr_buf_aci(hw, offset, &words, data); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1320: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3682: + status = ixgbe_read_sr_word_aci(hw, E610_SR_VPD_PTR, &vpd_module); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1325: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3687: + status = ixgbe_read_sr_word_aci(hw, E610_SR_PCIE_ALT_AUTO_LOAD_PTR, WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1338: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3700: + status = ixgbe_read_sr_buf_aci(hw, i, &words, data); ERROR:SPACING: space required before the open parenthesis '(' #1361: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3723: + if(nvm_acquired) ERROR:SPACING: space required before the open parenthesis '(' #1365: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3727: + if(!status) WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1399: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3798: + status = ixgbe_read_ee_aci_E610(hw, E610_SR_PFA_PTR, &pfa_ptr); WARNING:BRACES: braces {} are not necessary for single statement blocks #1400: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3799: + if (status != IXGBE_SUCCESS) { + return status; + } WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1403: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3802: + status = ixgbe_read_ee_aci_E610(hw, pfa_ptr, &pfa_len); WARNING:BRACES: braces {} are not necessary for single statement blocks #1404: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3803: + if (status != IXGBE_SUCCESS) { + return status; + } WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1416: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3815: + status = ixgbe_read_ee_aci_E610(hw, next_tlv, WARNING:BRACES: braces {} are not necessary for single statement blocks #1418: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3817: + if (status != IXGBE_SUCCESS) { + break; + } WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1422: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3821: + status = ixgbe_read_ee_aci_E610(hw, next_tlv + 1, &tlv_len); WARNING:BRACES: braces {} are not necessary for single statement blocks #1423: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3822: + if (status != IXGBE_SUCCESS) { + break; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1463: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3862: + if (status != IXGBE_SUCCESS) { + return status; + } WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1468: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3867: + status = ixgbe_read_ee_aci_E610(hw, (pba_tlv + 2), &pba_size); WARNING:BRACES: braces {} are not necessary for single statement blocks #1469: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3868: + if (status != IXGBE_SUCCESS) { + return status; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1473: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3872: + if (pba_tlv_len < pba_size) { + return IXGBE_ERR_INVAL_SIZE; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1481: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3880: + if (pba_num_size < (((u32)pba_size * 2) + 1)) { + return IXGBE_ERR_PARAM; + } WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1486: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3885: + status = ixgbe_read_ee_aci_E610(hw, (pba_tlv + 2 + 1) + i, WARNING:BRACES: braces {} are not necessary for single statement blocks #1488: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3887: + if (status != IXGBE_SUCCESS) { + return status; + } WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1507: FILE: drivers/net/ixgbe/base/ixgbe_e610.h:22: +s32 ixgbe_aci_send_driver_ver(struct ixgbe_hw *hw, struct ixgbe_driver_ver *dv); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1517: FILE: drivers/net/ixgbe/base/ixgbe_e610.h:60: +s32 ixgbe_read_sr_buf_aci(struct ixgbe_hw *hw, u16 offset, u16 *words, u16 *data); WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''? #1545: FILE: drivers/net/ixgbe/base/ixgbe_e610.h:106: +s32 ixgbe_read_ee_aci_buffer_E610(struct ixgbe_hw *hw, u16 offset, CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type == ixgbe_mac_X550' #1624: FILE: drivers/net/ixgbe/base/ixgbe_phy.c:803: + if ((hw->mac.type == ixgbe_mac_X550) || + (hw->mac.type == ixgbe_mac_E610)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type == ixgbe_mac_E610' #1624: FILE: drivers/net/ixgbe/base/ixgbe_phy.c:803: + if ((hw->mac.type == ixgbe_mac_X550) || + (hw->mac.type == ixgbe_mac_E610)) { WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ixgbe_hw *' should also have an identifier name #1661: FILE: drivers/net/ixgbe/base/ixgbe_type.h:3947: + s32 (*read_pba_string)(struct ixgbe_hw *, u8 *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name #1661: FILE: drivers/net/ixgbe/base/ixgbe_type.h:3947: + s32 (*read_pba_string)(struct ixgbe_hw *, u8 *, u32); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name #1661: FILE: drivers/net/ixgbe/base/ixgbe_type.h:3947: + s32 (*read_pba_string)(struct ixgbe_hw *, u8 *, u32); ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1709: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:113: +#define E610_GET_PFA_POINTER_IN_WORDS(offset) \ + ((offset & E610_SR_POINTER_TYPE_BIT) == E610_SR_POINTER_TYPE_BIT) ? \ + ((offset & E610_SR_POINTER_MASK) * E610_SR_HALF_4KB_SECTOR_UNITS) : \ + (offset & E610_SR_POINTER_MASK) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects? #1709: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:113: +#define E610_GET_PFA_POINTER_IN_WORDS(offset) \ + ((offset & E610_SR_POINTER_TYPE_BIT) == E610_SR_POINTER_TYPE_BIT) ? \ + ((offset & E610_SR_POINTER_MASK) * E610_SR_HALF_4KB_SECTOR_UNITS) : \ + (offset & E610_SR_POINTER_MASK) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues #1709: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:113: +#define E610_GET_PFA_POINTER_IN_WORDS(offset) \ + ((offset & E610_SR_POINTER_TYPE_BIT) == E610_SR_POINTER_TYPE_BIT) ? \ + ((offset & E610_SR_POINTER_MASK) * E610_SR_HALF_4KB_SECTOR_UNITS) : \ + (offset & E610_SR_POINTER_MASK) WARNING:LEADING_SPACE: please, no spaces at the start of a line #1710: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:114: + ((offset & E610_SR_POINTER_TYPE_BIT) == E610_SR_POINTER_TYPE_BIT) ? \$ ERROR:CODE_INDENT: code indent should use tabs where possible #1711: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:115: + ((offset & E610_SR_POINTER_MASK) * E610_SR_HALF_4KB_SECTOR_UNITS) : \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1711: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:115: + ((offset & E610_SR_POINTER_MASK) * E610_SR_HALF_4KB_SECTOR_UNITS) : \$ ERROR:CODE_INDENT: code indent should use tabs where possible #1712: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:116: + (offset & E610_SR_POINTER_MASK)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1712: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:116: + (offset & E610_SR_POINTER_MASK)$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1737: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:141: +/* These macros strip from NVM Image Revision the particular part of NVM ver: + major ver, minor ver and image id */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1737: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:141: + major ver, minor ver and image id */ CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #1738: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:142: +#define E610_NVM_MAJOR_VER(x) ((x & 0xF000) >> 12) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #1739: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:143: +#define E610_NVM_MINOR_VER(x) (x & 0x00FF) WARNING:TYPO_SPELLING: 'PRES' may be misspelled - perhaps 'PRESS'? #1766: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:214: +#define GLNVM_GENS_NVM_PRES_S 0 WARNING:TYPO_SPELLING: 'PRES' may be misspelled - perhaps 'PRESS'? #1767: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:215: +#define GLNVM_GENS_NVM_PRES_M BIT(0) WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''? #1784: FILE: drivers/net/ixgbe/base/ixgbe_type_e610.h:241: +/* Admin Command Interface (ACI) defines */ total: 18 errors, 84 warnings, 7 checks, 1617 lines checked