From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: |WARNING| pw139875 [RFC v6 1/6] eal: add static per-lcore memory allocation facility
Date: Mon, 6 May 2024 20:51:43 +0200 (CEST) [thread overview]
Message-ID: <20240506185143.B50E1121E57@dpdk.org> (raw)
In-Reply-To: <20240506082721.120666-2-mattias.ronnblom@ericsson.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139875
_coding style issues_
WARNING:TYPO_SPELLING: 'consistenly' may be misspelled - perhaps 'consistently'?
#176:
* In Doxygen, consistenly use @<cmd> (and not \<cmd>).
WARNING:TYPO_SPELLING: 'convience' may be misspelled - perhaps 'convince'?
#177:
* The RTE_LCORE_VAR_GET() and SET() convience access macros
WARNING:TYPO_SPELLING: 'varible' may be misspelled - perhaps 'variable'?
#248: FILE: doc/api/doxy-api-index.md:102:
+ [lcore-varible](@ref rte_lcore_var.h),
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#574: FILE: lib/eal/include/rte_lcore_var.h:218:
+#define RTE_LCORE_VAR_HANDLE_TYPE(type) \
+ type *
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#590: FILE: lib/eal/include/rte_lcore_var.h:234:
+#define RTE_LCORE_VAR_HANDLE(type, name) \
+ RTE_LCORE_VAR_HANDLE_TYPE(type) name
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#598: FILE: lib/eal/include/rte_lcore_var.h:242:
+#define RTE_LCORE_VAR_ALLOC_SIZE_ALIGN(handle, size, align) \
+ handle = rte_lcore_var_alloc(size, align)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#626: FILE: lib/eal/include/rte_lcore_var.h:270:
+#define RTE_LCORE_VAR_INIT_SIZE_ALIGN(name, size, align) \
+ RTE_INIT(rte_lcore_var_init_ ## name) \
+ { \
+ RTE_LCORE_VAR_ALLOC_SIZE_ALIGN(name, size, align); \
+ }
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#646: FILE: lib/eal/include/rte_lcore_var.h:290:
+#define RTE_LCORE_VAR_INIT(name) \
+ RTE_INIT(rte_lcore_var_init_ ## name) \
+ { \
+ RTE_LCORE_VAR_ALLOC(name); \
+ }
WARNING:TYPO_SPELLING: 'identifer' may be misspelled - perhaps 'identifier'?
#710: FILE: lib/eal/include/rte_lcore_var.h:354:
+ * The pointer returned is only an opaque identifer of the variable. To
total: 5 errors, 4 warnings, 490 lines checked
Please use __rte_cache_aligned only for struct or union types alignment.
parent reply other threads:[~2024-05-06 18:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240506082721.120666-2-mattias.ronnblom@ericsson.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506185143.B50E1121E57@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).