From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E7DCE43F5C
	for <public@inbox.dpdk.org>; Mon,  6 May 2024 20:51:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E3D16410E4;
	Mon,  6 May 2024 20:51:44 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id BCF6A40EDF
 for <test-report@dpdk.org>; Mon,  6 May 2024 20:51:43 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id B50E1121E57; Mon,  6 May 2024 20:51:43 +0200 (CEST)
Subject: |WARNING| pw139875 [RFC v6 1/6] eal: add static per-lcore memory
 allocation facility
In-Reply-To: <20240506082721.120666-2-mattias.ronnblom@ericsson.com>
References: <20240506082721.120666-2-mattias.ronnblom@ericsson.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
Message-Id: <20240506185143.B50E1121E57@dpdk.org>
Date: Mon,  6 May 2024 20:51:43 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139875

_coding style issues_


WARNING:TYPO_SPELLING: 'consistenly' may be misspelled - perhaps 'consistently'?
#176: 
 * In Doxygen, consistenly use @<cmd> (and not \<cmd>).

WARNING:TYPO_SPELLING: 'convience' may be misspelled - perhaps 'convince'?
#177: 
 * The RTE_LCORE_VAR_GET() and SET() convience access macros

WARNING:TYPO_SPELLING: 'varible' may be misspelled - perhaps 'variable'?
#248: FILE: doc/api/doxy-api-index.md:102:
+  [lcore-varible](@ref rte_lcore_var.h),

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#574: FILE: lib/eal/include/rte_lcore_var.h:218:
+#define RTE_LCORE_VAR_HANDLE_TYPE(type)		\
+	type *

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#590: FILE: lib/eal/include/rte_lcore_var.h:234:
+#define RTE_LCORE_VAR_HANDLE(type, name)	\
+	RTE_LCORE_VAR_HANDLE_TYPE(type) name

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#598: FILE: lib/eal/include/rte_lcore_var.h:242:
+#define RTE_LCORE_VAR_ALLOC_SIZE_ALIGN(handle, size, align)	\
+	handle = rte_lcore_var_alloc(size, align)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#626: FILE: lib/eal/include/rte_lcore_var.h:270:
+#define RTE_LCORE_VAR_INIT_SIZE_ALIGN(name, size, align)		\
+	RTE_INIT(rte_lcore_var_init_ ## name)				\
+	{								\
+		RTE_LCORE_VAR_ALLOC_SIZE_ALIGN(name, size, align);	\
+	}

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#646: FILE: lib/eal/include/rte_lcore_var.h:290:
+#define RTE_LCORE_VAR_INIT(name)					\
+	RTE_INIT(rte_lcore_var_init_ ## name)				\
+	{								\
+		RTE_LCORE_VAR_ALLOC(name);				\
+	}

WARNING:TYPO_SPELLING: 'identifer' may be misspelled - perhaps 'identifier'?
#710: FILE: lib/eal/include/rte_lcore_var.h:354:
+ * The pointer returned is only an opaque identifer of the variable. To

total: 5 errors, 4 warnings, 490 lines checked
Please use __rte_cache_aligned only for struct or union types alignment.