From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: |WARNING| pw139870 [RFC v7 5/6] eal: add atomic bit operations
Date: Mon, 6 May 2024 20:53:01 +0200 (CEST) [thread overview]
Message-ID: <20240506185301.108AF121E57@dpdk.org> (raw)
In-Reply-To: <20240505083737.118649-6-mattias.ronnblom@ericsson.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139870
_coding style issues_
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#214: FILE: lib/eal/include/rte_bitops.h:428:
+ uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#214: FILE: lib/eal/include/rte_bitops.h:428:
+ uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#215: FILE: lib/eal/include/rte_bitops.h:429:
+ const uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#215: FILE: lib/eal/include/rte_bitops.h:429:
+ const uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#216: FILE: lib/eal/include/rte_bitops.h:430:
+ uint64_t *: __rte_bit_atomic_test64, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#216: FILE: lib/eal/include/rte_bitops.h:430:
+ uint64_t *: __rte_bit_atomic_test64, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#217: FILE: lib/eal/include/rte_bitops.h:431:
+ const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#217: FILE: lib/eal/include/rte_bitops.h:431:
+ const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#239: FILE: lib/eal/include/rte_bitops.h:453:
+ uint32_t *: __rte_bit_atomic_set32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#239: FILE: lib/eal/include/rte_bitops.h:453:
+ uint32_t *: __rte_bit_atomic_set32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#240: FILE: lib/eal/include/rte_bitops.h:454:
+ uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#240: FILE: lib/eal/include/rte_bitops.h:454:
+ uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#261: FILE: lib/eal/include/rte_bitops.h:475:
+ uint32_t *: __rte_bit_atomic_clear32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#261: FILE: lib/eal/include/rte_bitops.h:475:
+ uint32_t *: __rte_bit_atomic_clear32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#262: FILE: lib/eal/include/rte_bitops.h:476:
+ uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#262: FILE: lib/eal/include/rte_bitops.h:476:
+ uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#285: FILE: lib/eal/include/rte_bitops.h:499:
+ uint32_t *: __rte_bit_atomic_assign32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#285: FILE: lib/eal/include/rte_bitops.h:499:
+ uint32_t *: __rte_bit_atomic_assign32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#286: FILE: lib/eal/include/rte_bitops.h:500:
+ uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#286: FILE: lib/eal/include/rte_bitops.h:500:
+ uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#309: FILE: lib/eal/include/rte_bitops.h:523:
+ uint32_t *: __rte_bit_atomic_flip32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#309: FILE: lib/eal/include/rte_bitops.h:523:
+ uint32_t *: __rte_bit_atomic_flip32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#310: FILE: lib/eal/include/rte_bitops.h:524:
+ uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#310: FILE: lib/eal/include/rte_bitops.h:524:
+ uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#333: FILE: lib/eal/include/rte_bitops.h:547:
+ uint32_t *: __rte_bit_atomic_test_and_set32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#333: FILE: lib/eal/include/rte_bitops.h:547:
+ uint32_t *: __rte_bit_atomic_test_and_set32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#334: FILE: lib/eal/include/rte_bitops.h:548:
+ uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#334: FILE: lib/eal/include/rte_bitops.h:548:
+ uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#358: FILE: lib/eal/include/rte_bitops.h:572:
+ uint32_t *: __rte_bit_atomic_test_and_clear32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#358: FILE: lib/eal/include/rte_bitops.h:572:
+ uint32_t *: __rte_bit_atomic_test_and_clear32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#359: FILE: lib/eal/include/rte_bitops.h:573:
+ uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#359: FILE: lib/eal/include/rte_bitops.h:573:
+ uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#386: FILE: lib/eal/include/rte_bitops.h:600:
+ uint32_t *: __rte_bit_atomic_test_and_assign32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#386: FILE: lib/eal/include/rte_bitops.h:600:
+ uint32_t *: __rte_bit_atomic_test_and_assign32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#387: FILE: lib/eal/include/rte_bitops.h:601:
+ uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#387: FILE: lib/eal/include/rte_bitops.h:601:
+ uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#401: FILE: lib/eal/include/rte_bitops.h:692:
+ __rte_bit_atomic_test ## size(const uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#406: FILE: lib/eal/include/rte_bitops.h:697:
+ const RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#415: FILE: lib/eal/include/rte_bitops.h:706:
+ __rte_bit_atomic_set ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#420: FILE: lib/eal/include/rte_bitops.h:711:
+ RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#429: FILE: lib/eal/include/rte_bitops.h:720:
+ __rte_bit_atomic_clear ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#434: FILE: lib/eal/include/rte_bitops.h:725:
+ RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#443: FILE: lib/eal/include/rte_bitops.h:734:
+ __rte_bit_atomic_flip ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#448: FILE: lib/eal/include/rte_bitops.h:739:
+ RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#457: FILE: lib/eal/include/rte_bitops.h:748:
+ __rte_bit_atomic_assign ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#471: FILE: lib/eal/include/rte_bitops.h:762:
+ __rte_bit_atomic_test_and_set ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#477: FILE: lib/eal/include/rte_bitops.h:768:
+ RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#491: FILE: lib/eal/include/rte_bitops.h:782:
+ __rte_bit_atomic_test_and_clear ## size(uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#497: FILE: lib/eal/include/rte_bitops.h:788:
+ RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#502: FILE: lib/eal/include/rte_bitops.h:793:
+^I prev = rte_atomic_fetch_and_explicit(a_addr, ~mask,^I\$
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#511: FILE: lib/eal/include/rte_bitops.h:802:
+ __rte_bit_atomic_test_and_assign ## size(uint ## size ## _t *addr, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#524: FILE: lib/eal/include/rte_bitops.h:815:
+#define __RTE_GEN_BIT_ATOMIC_OPS(size) \
+ __RTE_GEN_BIT_ATOMIC_TEST(size) \
+ __RTE_GEN_BIT_ATOMIC_SET(size) \
+ __RTE_GEN_BIT_ATOMIC_CLEAR(size) \
+ __RTE_GEN_BIT_ATOMIC_ASSIGN(size) \
+ __RTE_GEN_BIT_ATOMIC_TEST_AND_SET(size) \
+ __RTE_GEN_BIT_ATOMIC_TEST_AND_CLEAR(size) \
+ __RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(size) \
+ __RTE_GEN_BIT_ATOMIC_FLIP(size)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#559: FILE: lib/eal/include/rte_bitops.h:1580:
+#define __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, size, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name) \
+ static inline ret_type \
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
+ arg2_type arg2_name) \
+ { \
+ return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name); \
+ }
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#562: FILE: lib/eal/include/rte_bitops.h:1583:
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#568: FILE: lib/eal/include/rte_bitops.h:1589:
+#define __RTE_BIT_OVERLOAD_3R(fun, qualifier, ret_type, arg1_type, arg1_name, \
+ arg2_type, arg2_name) \
+ __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 32, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name) \
+ __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 64, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name)
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#578: FILE: lib/eal/include/rte_bitops.h:1599:
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#585: FILE: lib/eal/include/rte_bitops.h:1606:
+#define __RTE_BIT_OVERLOAD_4(fun, qualifier, arg1_type, arg1_name, arg2_type, \
+ arg2_name, arg3_type, arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 32, arg1_type, arg1_name, \
+ arg2_type, arg2_name, arg3_type, arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 64, arg1_type, arg1_name, \
+ arg2_type, arg2_name, arg3_type, arg3_name)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#592: FILE: lib/eal/include/rte_bitops.h:1613:
+#define __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, size, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name, arg3_type, \
+ arg3_name) \
+ static inline ret_type \
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
+ arg2_type arg2_name, arg3_type arg3_name) \
+ { \
+ return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name, \
+ arg3_name); \
+ }
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#596: FILE: lib/eal/include/rte_bitops.h:1617:
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#603: FILE: lib/eal/include/rte_bitops.h:1624:
+#define __RTE_BIT_OVERLOAD_4R(fun, qualifier, ret_type, arg1_type, arg1_name, \
+ arg2_type, arg2_name, arg3_type, arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 32, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name, arg3_type, \
+ arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 64, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name, arg3_type, \
+ arg3_name)
ERROR:SPACING: space required after that ',' (ctx:VxO)
#621: FILE: lib/eal/include/rte_bitops.h:1647:
+__RTE_BIT_OVERLOAD_3(atomic_set,, unsigned int, nr, int, memory_order)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#622: FILE: lib/eal/include/rte_bitops.h:1648:
+__RTE_BIT_OVERLOAD_3(atomic_clear,, unsigned int, nr, int, memory_order)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#623: FILE: lib/eal/include/rte_bitops.h:1649:
+__RTE_BIT_OVERLOAD_4(atomic_assign,, unsigned int, nr, bool, value,
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#625: FILE: lib/eal/include/rte_bitops.h:1651:
+__RTE_BIT_OVERLOAD_3(atomic_flip,, unsigned int, nr, int, memory_order)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#626: FILE: lib/eal/include/rte_bitops.h:1652:
+__RTE_BIT_OVERLOAD_3R(atomic_test_and_set,, bool, unsigned int, nr,
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#628: FILE: lib/eal/include/rte_bitops.h:1654:
+__RTE_BIT_OVERLOAD_3R(atomic_test_and_clear,, bool, unsigned int, nr,
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#630: FILE: lib/eal/include/rte_bitops.h:1656:
+__RTE_BIT_OVERLOAD_4R(atomic_test_and_assign,, bool, unsigned int, nr,
^
total: 67 errors, 0 warnings, 449 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
parent reply other threads:[~2024-05-06 18:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240505083737.118649-6-mattias.ronnblom@ericsson.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506185301.108AF121E57@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).