automatic DPDK test reports
 help / color / mirror / Atom feed
* |WARNING| pw139867 [RFC v7 1/6] eal: extend bit manipulation functionality
       [not found] <20240505083737.118649-2-mattias.ronnblom@ericsson.com>
@ 2024-05-06 18:53 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-05-06 18:53 UTC (permalink / raw)
  To: test-report; +Cc: Mattias Rönnblom

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139867

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#220: FILE: lib/eal/include/rte_bitops.h:131:
+		uint32_t *: __rte_bit_test32,			\
 		         ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#220: FILE: lib/eal/include/rte_bitops.h:131:
+		uint32_t *: __rte_bit_test32,			\
 		          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#221: FILE: lib/eal/include/rte_bitops.h:132:
+		const uint32_t *: __rte_bit_test32,		\
 		               ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#221: FILE: lib/eal/include/rte_bitops.h:132:
+		const uint32_t *: __rte_bit_test32,		\
 		                ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#222: FILE: lib/eal/include/rte_bitops.h:133:
+		uint64_t *: __rte_bit_test64,			\
 		         ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#222: FILE: lib/eal/include/rte_bitops.h:133:
+		uint64_t *: __rte_bit_test64,			\
 		          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#223: FILE: lib/eal/include/rte_bitops.h:134:
+		const uint64_t *: __rte_bit_test64)(addr, nr)
 		               ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#223: FILE: lib/eal/include/rte_bitops.h:134:
+		const uint64_t *: __rte_bit_test64)(addr, nr)
 		                ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#245: FILE: lib/eal/include/rte_bitops.h:156:
+		 uint32_t *: __rte_bit_set32,		\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#245: FILE: lib/eal/include/rte_bitops.h:156:
+		 uint32_t *: __rte_bit_set32,		\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#246: FILE: lib/eal/include/rte_bitops.h:157:
+		 uint64_t *: __rte_bit_set64)(addr, nr)
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#246: FILE: lib/eal/include/rte_bitops.h:157:
+		 uint64_t *: __rte_bit_set64)(addr, nr)
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#268: FILE: lib/eal/include/rte_bitops.h:179:
+		 uint32_t *: __rte_bit_clear32,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#268: FILE: lib/eal/include/rte_bitops.h:179:
+		 uint32_t *: __rte_bit_clear32,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#269: FILE: lib/eal/include/rte_bitops.h:180:
+		 uint64_t *: __rte_bit_clear64)(addr, nr)
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#269: FILE: lib/eal/include/rte_bitops.h:180:
+		 uint64_t *: __rte_bit_clear64)(addr, nr)
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#292: FILE: lib/eal/include/rte_bitops.h:203:
+		 uint32_t *: __rte_bit_assign32,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#292: FILE: lib/eal/include/rte_bitops.h:203:
+		 uint32_t *: __rte_bit_assign32,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#293: FILE: lib/eal/include/rte_bitops.h:204:
+		 uint64_t *: __rte_bit_assign64)(addr, nr, value)
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#293: FILE: lib/eal/include/rte_bitops.h:204:
+		 uint64_t *: __rte_bit_assign64)(addr, nr, value)
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#315: FILE: lib/eal/include/rte_bitops.h:226:
+		 uint32_t *: __rte_bit_flip32,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#315: FILE: lib/eal/include/rte_bitops.h:226:
+		 uint32_t *: __rte_bit_flip32,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#316: FILE: lib/eal/include/rte_bitops.h:227:
+		 uint64_t *: __rte_bit_flip64)(addr, nr)
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#316: FILE: lib/eal/include/rte_bitops.h:227:
+		 uint64_t *: __rte_bit_flip64)(addr, nr)
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#321: FILE: lib/eal/include/rte_bitops.h:232:
+	__rte_bit_ ## family ## fun ## size(const qualifier uint ## size ## _t *addr, \
 	                                                                       ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#333: FILE: lib/eal/include/rte_bitops.h:244:
+	__rte_bit_ ## family ## fun ## size(qualifier uint ## size ## _t *addr, \
 	                                                                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#345: FILE: lib/eal/include/rte_bitops.h:256:
+	__rte_bit_ ## family ## fun ## size(qualifier uint ## size ## _t *addr, \
 	                                                                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#357: FILE: lib/eal/include/rte_bitops.h:268:
+	__rte_bit_ ## family ## fun ## size(qualifier uint ## size ## _t *addr, \
 	                                                                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#369: FILE: lib/eal/include/rte_bitops.h:280:
+	__rte_bit_ ## family ## fun ## size(qualifier uint ## size ## _t *addr, \
 	                                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#378: FILE: lib/eal/include/rte_bitops.h:289:
+__RTE_GEN_BIT_TEST(, test,, 32)
                          ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#379: FILE: lib/eal/include/rte_bitops.h:290:
+__RTE_GEN_BIT_SET(, set,, 32)
                        ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#380: FILE: lib/eal/include/rte_bitops.h:291:
+__RTE_GEN_BIT_CLEAR(, clear,, 32)
                            ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#381: FILE: lib/eal/include/rte_bitops.h:292:
+__RTE_GEN_BIT_ASSIGN(, assign,, 32)
                              ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#382: FILE: lib/eal/include/rte_bitops.h:293:
+__RTE_GEN_BIT_FLIP(, flip,, 32)
                          ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#384: FILE: lib/eal/include/rte_bitops.h:295:
+__RTE_GEN_BIT_TEST(, test,, 64)
                          ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#385: FILE: lib/eal/include/rte_bitops.h:296:
+__RTE_GEN_BIT_SET(, set,, 64)
                        ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#386: FILE: lib/eal/include/rte_bitops.h:297:
+__RTE_GEN_BIT_CLEAR(, clear,, 64)
                            ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#387: FILE: lib/eal/include/rte_bitops.h:298:
+__RTE_GEN_BIT_ASSIGN(, assign,, 64)
                              ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#388: FILE: lib/eal/include/rte_bitops.h:299:
+__RTE_GEN_BIT_FLIP(, flip,, 64)
                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#412: FILE: lib/eal/include/rte_bitops.h:998:
+	rte_bit_ ## fun(qualifier uint ## size ## _t *addr,		\
 	                                             ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#418: FILE: lib/eal/include/rte_bitops.h:1004:
+#define __RTE_BIT_OVERLOAD_2(fun, qualifier, arg1_type, arg1_name)	\
+	__RTE_BIT_OVERLOAD_SZ_2(fun, qualifier, 32, arg1_type, arg1_name) \
+	__RTE_BIT_OVERLOAD_SZ_2(fun, qualifier, 64, arg1_type, arg1_name)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#422: FILE: lib/eal/include/rte_bitops.h:1008:
+#define __RTE_BIT_OVERLOAD_SZ_2R(fun, qualifier, size, ret_type, arg1_type, \
+				 arg1_name)				\
+	static inline ret_type						\
+	rte_bit_ ## fun(qualifier uint ## size ## _t *addr,		\
+			arg1_type arg1_name)				\
+	{								\
+		return __rte_bit_ ## fun ## size(addr, arg1_name);	\
+	}

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#425: FILE: lib/eal/include/rte_bitops.h:1011:
+	rte_bit_ ## fun(qualifier uint ## size ## _t *addr,		\
 	                                             ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#431: FILE: lib/eal/include/rte_bitops.h:1017:
+#define __RTE_BIT_OVERLOAD_2R(fun, qualifier, ret_type, arg1_type, arg1_name) \
+	__RTE_BIT_OVERLOAD_SZ_2R(fun, qualifier, 32, ret_type, arg1_type, \
+				 arg1_name)				\
+	__RTE_BIT_OVERLOAD_SZ_2R(fun, qualifier, 64, ret_type, arg1_type, \
+				 arg1_name)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#440: FILE: lib/eal/include/rte_bitops.h:1026:
+	rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name,	\
 	                                   ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#446: FILE: lib/eal/include/rte_bitops.h:1032:
+#define __RTE_BIT_OVERLOAD_3(fun, qualifier, arg1_type, arg1_name, arg2_type, \
+			     arg2_name)					\
+	__RTE_BIT_OVERLOAD_SZ_3(fun, qualifier, 32, arg1_type, arg1_name, \
+				arg2_type, arg2_name)			\
+	__RTE_BIT_OVERLOAD_SZ_3(fun, qualifier, 64, arg1_type, arg1_name, \
+				arg2_type, arg2_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#454: FILE: lib/eal/include/rte_bitops.h:1040:
+__RTE_BIT_OVERLOAD_2(set,, unsigned int, nr)
                         ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#455: FILE: lib/eal/include/rte_bitops.h:1041:
+__RTE_BIT_OVERLOAD_2(clear,, unsigned int, nr)
                           ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#456: FILE: lib/eal/include/rte_bitops.h:1042:
+__RTE_BIT_OVERLOAD_3(assign,, unsigned int, nr, bool, value)
                            ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#457: FILE: lib/eal/include/rte_bitops.h:1043:
+__RTE_BIT_OVERLOAD_2(flip,, unsigned int, nr)
                          ^

total: 50 errors, 0 warnings, 287 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-05-06 18:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20240505083737.118649-2-mattias.ronnblom@ericsson.com>
2024-05-06 18:53 ` |WARNING| pw139867 [RFC v7 1/6] eal: extend bit manipulation functionality checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).