|WARNING| pw140367 [PATCH 11/25] common/idpf: support added for xn transactions

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Soumyadeep Hore <soumyadeep.hore@intel.com>
Subject: |WARNING| pw140367 [PATCH 11/25] common/idpf: support added for xn transactions
Date: Tue, 28 May 2024 10:18:58 +0200 (CEST)	[thread overview]
Message-ID: <20240528081858.3536412367B@dpdk.org> (raw)
In-Reply-To: <20240528073559.867121-2-soumyadeep.hore@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/140367

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EPERM)
#101: FILE: drivers/common/idpf/base/idpf_osdep.c:14:
+		return EPERM;

ERROR:SPACING: space required after that ',' (ctx:VxV)
#113: FILE: drivers/common/idpf/base/idpf_osdep.c:26:
+	fd = eventfd(0,0);
 	              ^

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EPERM)
#116: FILE: drivers/common/idpf/base/idpf_osdep.c:29:
+		return EPERM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EPERM)
#125: FILE: drivers/common/idpf/base/idpf_osdep.c:38:
+		return EPERM;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: drivers/common/idpf/base/idpf_osdep.h:372:
+  {$

ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#197: FILE: drivers/common/idpf/base/idpf_osdep.h:372:
+struct iovec
+  {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: drivers/common/idpf/base/idpf_osdep.h:373:
+    void *iov_base;^I/* Pointer to data.  */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: drivers/common/idpf/base/idpf_osdep.h:374:
+    size_t iov_len;^I/* Length of data.  */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: drivers/common/idpf/base/idpf_osdep.h:375:
+  };$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#208: FILE: drivers/common/idpf/base/idpf_osdep.h:383:
+#define IDPF_LIST_ENTRY(type) ^I^I^I^ISLIST_ENTRY(type)$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#209: FILE: drivers/common/idpf/base/idpf_osdep.h:384:
+#define IDPF_LIST_ADD(head, node) ^I^I^ISLIST_INSERT_HEAD(head, node, entry)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#226: FILE: drivers/common/idpf/base/idpf_osdep.h:401:
+        ({                                                                     \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: drivers/common/idpf/base/idpf_osdep.h:401:
+        ({                                                                     \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#227: FILE: drivers/common/idpf/base/idpf_osdep.h:402:
+                ((typeof(_mask))(_val) << __bf_shf(_mask)) & (_mask);          \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: drivers/common/idpf/base/idpf_osdep.h:402:
+                ((typeof(_mask))(_val) << __bf_shf(_mask)) & (_mask);          \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: drivers/common/idpf/base/idpf_osdep.h:403:
+        })$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: drivers/common/idpf/base/idpf_osdep.h:403:
+        })$

ERROR:CODE_INDENT: code indent should use tabs where possible
#231: FILE: drivers/common/idpf/base/idpf_osdep.h:406:
+        ({                                                                     \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#231: FILE: drivers/common/idpf/base/idpf_osdep.h:406:
+        ({                                                                     \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#232: FILE: drivers/common/idpf/base/idpf_osdep.h:407:
+                (typeof(_mask))(((_reg) & (_mask)) >> __bf_shf(_mask));        \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#232: FILE: drivers/common/idpf/base/idpf_osdep.h:407:
+                (typeof(_mask))(((_reg) & (_mask)) >> __bf_shf(_mask));        \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#233: FILE: drivers/common/idpf/base/idpf_osdep.h:408:
+        })$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#233: FILE: drivers/common/idpf/base/idpf_osdep.h:408:
+        })$

WARNING:RETURN_VOID: void function return statements are not generally useful
#343: FILE: drivers/common/idpf/base/idpf_xn.c:78:
+	return;
+}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#373: FILE: drivers/common/idpf/base/idpf_xn.c:108:
+	if (i < MAX_XN_ENTRIES) {
+  	idpf_ctlq_xn_deinit_dma(hw, xnm);

ERROR:CODE_INDENT: code indent should use tabs where possible
#374: FILE: drivers/common/idpf/base/idpf_xn.c:109:
+  ^Iidpf_ctlq_xn_deinit_dma(hw, xnm);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#374: FILE: drivers/common/idpf/base/idpf_xn.c:109:
+  ^Iidpf_ctlq_xn_deinit_dma(hw, xnm);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#374: FILE: drivers/common/idpf/base/idpf_xn.c:109:
+  ^Iidpf_ctlq_xn_deinit_dma(hw, xnm);$

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#388: FILE: drivers/common/idpf/base/idpf_xn.c:123:
+static int idpf_ctlq_xn_process_recv(struct idpf_ctlq_xn_recv_params *params, struct idpf_ctlq_msg *ctlq_msg)

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#413: FILE: drivers/common/idpf/base/idpf_xn.c:148:
+		IDPF_DEBUG_PRINT("Transaction cookie does not match (%02x != %02x)
", xn->cookie, msg_cookie);

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#429: FILE: drivers/common/idpf/base/idpf_xn.c:164:
+		IDPF_DEBUG_PRINT("Async message failure (op %d)
", ctlq_msg->cookie.mbx.chnl_opcode);

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#495: FILE: drivers/common/idpf/base/idpf_xn.c:230:
+static int idpf_ctlq_xn_process_send(struct idpf_ctlq_xn_send_params *params, struct idpf_ctlq_xn *xn)

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#505: FILE: drivers/common/idpf/base/idpf_xn.c:240:
+		idpf_memcpy(xn->dma_mem->va, params->send_buf.iov_base, params->send_buf.iov_len, IDPF_NONDMA_TO_DMA);

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#508: FILE: drivers/common/idpf/base/idpf_xn.c:243:
+	cookie = FIELD_PREP(IDPF_CTLQ_XN_COOKIE_M, xn->cookie) | FIELD_PREP(IDPF_CTLQ_XN_INDEX_M, xn->index);

total: 9 errors, 25 warnings, 704 lines checked
Warning in drivers/common/idpf/base/idpf_osdep.c:
Writing to stdout or stderr

          parent reply	other threads:[~2024-05-28  8:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20240528073559.867121-2-soumyadeep.hore@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528081858.3536412367B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=soumyadeep.hore@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).