From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: |WARNING| pw140462 [PATCH v3 24/30] net/ixgbe/base: add support for NVM handling in E610 device
Date: Thu, 30 May 2024 13:21:21 +0200 (CEST) [thread overview]
Message-ID: <20240530112121.B960412367B@dpdk.org> (raw)
In-Reply-To: <5578167c8ed177a6fba5e559e132990f8107bc60.1717067519.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/140462
_coding style issues_
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#105: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1845:
+ enum ixgbe_aci_res_access_type access)
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#138: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1878:
+ * ixgbe_aci_read_nvm - read NVM
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#147: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1887:
+ * Read the NVM using ACI command (0x0701).
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#151: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1891:
+s32 ixgbe_aci_read_nvm(struct ixgbe_hw *hw, u16 module_typeid, u32 offset,
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#155: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1895:
+ struct ixgbe_aci_desc desc;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#156: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1896:
+ struct ixgbe_aci_cmd_nvm *cmd;
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#160: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1900:
+ if (offset > IXGBE_ACI_NVM_MAX_OFFSET)
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#163: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1903:
+ ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_nvm_read);
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#165: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1905:
+ if (!read_shadow_ram && module_typeid == IXGBE_ACI_NVM_START_POINT)
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#166: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1906:
+ cmd->cmd_flags |= IXGBE_ACI_NVM_FLASH_ONLY;
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#170: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1910:
+ cmd->cmd_flags |= IXGBE_ACI_NVM_LAST_CMD;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#176: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1916:
+ return ixgbe_aci_send_cmd(hw, &desc, data, length);
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#183: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1923:
+ * Verify NVM PFA checksum validity using ACI command (0x0706).
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#191: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1931:
+ struct ixgbe_aci_cmd_nvm_checksum *cmd;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#192: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1932:
+ struct ixgbe_aci_desc desc;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#201: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1941:
+ ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_nvm_checksum);
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#202: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1942:
+ cmd->flags = IXGBE_ACI_NVM_CHECKSUM_VERIFY;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#204: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1944:
+ status = ixgbe_aci_send_cmd(hw, &desc, NULL, 0);
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#210: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1950:
+ IXGBE_ACI_NVM_CHECKSUM_CORRECT) {
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#223: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1963:
+ * Recalculate NVM PFA checksum using ACI command (0x0706).
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#230: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1970:
+ struct ixgbe_aci_cmd_nvm_checksum *cmd;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#231: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1971:
+ struct ixgbe_aci_desc desc;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#240: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1980:
+ ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_nvm_checksum);
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#241: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1981:
+ cmd->flags = IXGBE_ACI_NVM_CHECKSUM_RECALC;
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#243: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1983:
+ status = ixgbe_aci_send_cmd(hw, &desc, NULL, 0);
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#251: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1991:
+ * ixgbe_read_sr_word_aci - Reads Shadow RAM via ACI
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#251: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:1991:
+ * ixgbe_read_sr_word_aci - Reads Shadow RAM via ACI
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#260: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2000:
+s32 ixgbe_read_sr_word_aci(struct ixgbe_hw *hw, u16 offset, u16 *data)
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#312: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2052:
+ /* ixgbe_aci_read_nvm cannot read more than 4KB at a time.
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#316: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2056:
+ sector_offset = offset % IXGBE_ACI_MAX_BUFFER_SIZE;
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#318: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2058:
+ IXGBE_ACI_MAX_BUFFER_SIZE - sector_offset,
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#323: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2063:
+ /* ixgbe_aci_read_nvm takes the length as a u16. Our read_size
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#324: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2064:
+ * is calculated using a u32, but the IXGBE_ACI_MAX_BUFFER_SIZE
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#327: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2067:
+ status = ixgbe_aci_read_nvm(hw, IXGBE_ACI_NVM_START_POINT,
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#327: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2067:
+ status = ixgbe_aci_read_nvm(hw, IXGBE_ACI_NVM_START_POINT,
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#351: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2980:
+ * ixgbe_read_ee_aci_E610 - Read EEPROM word using the admin command.
WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#356: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2985:
+ * Reads a 16 bit word from the EEPROM using the ACI.
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#363: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:2992:
+s32 ixgbe_read_ee_aci_E610(struct ixgbe_hw *hw, u16 offset, u16 *data)
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#377: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3006:
+ status = ixgbe_read_sr_word_aci(hw, offset, data);
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#417: FILE: drivers/net/ixgbe/base/ixgbe_e610.c:3046:
+ status = ixgbe_read_sr_word_aci(hw, E610_SR_SW_CHECKSUM_WORD,
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#436: FILE: drivers/net/ixgbe/base/ixgbe_e610.h:60:
+ enum ixgbe_aci_res_access_type access);
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#439: FILE: drivers/net/ixgbe/base/ixgbe_e610.h:63:
+s32 ixgbe_aci_read_nvm(struct ixgbe_hw *hw, u16 module_typeid, u32 offset,
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#446: FILE: drivers/net/ixgbe/base/ixgbe_e610.h:70:
+s32 ixgbe_read_sr_word_aci(struct ixgbe_hw *hw, u16 offset, u16 *data);
WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#456: FILE: drivers/net/ixgbe/base/ixgbe_e610.h:107:
+s32 ixgbe_read_ee_aci_E610(struct ixgbe_hw *hw, u16 offset, u16 *data);
total: 0 errors, 44 warnings, 0 checks, 361 lines checked
parent reply other threads:[~2024-05-30 11:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5578167c8ed177a6fba5e559e132990f8107bc60.1717067519.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530112121.B960412367B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).