From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
Subject: |WARNING| pw142498 [PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY
Date: Thu, 18 Jul 2024 07:35:06 +0200 (CEST) [thread overview]
Message-ID: <20240718053506.71E95127EE2@dpdk.org> (raw)
In-Reply-To: <CA++LmPWP+fAn_uB=mGNuB_9jG16sZc4gTrEpoAm-aUYw8kF70Q@mail.gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/142498
_coding style issues_
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fatal: bad o ("a3033eb06fd6b1852")'
#74:
From 9fa6f7d425d66a00c3f63c7a3033eb06fd6b1852 Mon Sep 17 00:00:00 2001
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#104: FILE: drivers/net/gve/gve_ethdev.c:1176:
+ if (rte_eal_process_type() != RTE_PROC_PRIMARY) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1)
#104: FILE: drivers/net/gve/gve_ethdev.c:1176:
+ if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+ if (gve_is_gqi(priv)) {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: drivers/net/gve/gve_ethdev.c:1177:
+ if (gve_is_gqi(priv)) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1)
#105: FILE: drivers/net/gve/gve_ethdev.c:1177:
+ if (gve_is_gqi(priv)) {
+ gve_set_rx_function(eth_dev);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#106: FILE: drivers/net/gve/gve_ethdev.c:1178:
+ gve_set_rx_function(eth_dev);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#107: FILE: drivers/net/gve/gve_ethdev.c:1179:
+ gve_set_tx_function(eth_dev);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: drivers/net/gve/gve_ethdev.c:1180:
+ eth_dev->dev_ops = &gve_eth_dev_ops;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#109: FILE: drivers/net/gve/gve_ethdev.c:1181:
+ } else {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1)
#109: FILE: drivers/net/gve/gve_ethdev.c:1181:
+ } else {
+ gve_set_rx_function_dqo(eth_dev);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: drivers/net/gve/gve_ethdev.c:1182:
+ gve_set_rx_function_dqo(eth_dev);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: drivers/net/gve/gve_ethdev.c:1183:
+ gve_set_tx_function_dqo(eth_dev);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#112: FILE: drivers/net/gve/gve_ethdev.c:1184:
+ eth_dev->dev_ops = &gve_eth_dev_ops_dqo;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: drivers/net/gve/gve_ethdev.c:1185:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: drivers/net/gve/gve_ethdev.c:1187:
+ }$
WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: priyadarshitathagat <tathagat.dpdk@gmail.com>' != 'Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>'
total: 1 errors, 15 warnings, 0 checks, 19 lines checked
next prev parent reply other threads:[~2024-07-18 5:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA++LmPWP+fAn_uB=mGNuB_9jG16sZc4gTrEpoAm-aUYw8kF70Q@mail.gmail.com>
2024-07-18 5:06 ` qemudev
2024-07-18 5:35 ` checkpatch [this message]
2024-07-18 6:23 ` |SUCCESS| " 0-day Robot
2024-07-18 7:07 ` |WARNING| " dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718053506.71E95127EE2@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=tathagat.dpdk@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).