|WARNING| pw142652 [PATCH v2 1/3] net: add new packet dissector

[checkpatch@dpdk.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/142652

_coding style issues_


WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#139: FILE: lib/net/rte_dissect.c:9:
+#include <stdio.h>

WARNING:TYPO_SPELLING: 'tha' may be misspelled - perhaps 'than'?
#211: FILE: lib/net/rte_dissect.c:81:
+		rte_ether_format_addr(buf, sizeof(buf), &arp->arp_data.arp_tha);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#268: FILE: lib/net/rte_dissect.c:138:
+		fprintf(f, "UDP %u %u → %u ", rte_be_to_cpu_16(udph->dgram_len), src_port, dst_port);

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#290: FILE: lib/net/rte_dissect.c:160:
+#define PRINT_TCP_FLAG(flag) \
+	if (tcph->tcp_flags & RTE_TCP_ ## flag ## _FLAG) \
+		fprintf(f, " [" #flag" ]")

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#505: FILE: lib/net/rte_dissect.h:12:
+#include <stdio.h>

total: 1 errors, 4 warnings, 421 lines checked