From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 664304568C
	for <public@inbox.dpdk.org>; Tue, 23 Jul 2024 04:47:24 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6259C40E5E;
	Tue, 23 Jul 2024 04:47:24 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id B2CE340289
 for <test-report@dpdk.org>; Tue, 23 Jul 2024 04:47:19 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id A8EA1127EE2; Tue, 23 Jul 2024 04:47:19 +0200 (CEST)
Subject: |WARNING| pw142652 [PATCH v2 1/3] net: add new packet dissector
In-Reply-To: <20240723024537.980016-2-stephen@networkplumber.org>
References: <20240723024537.980016-2-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20240723024719.A8EA1127EE2@dpdk.org>
Date: Tue, 23 Jul 2024 04:47:19 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/142652

_coding style issues_


WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#139: FILE: lib/net/rte_dissect.c:9:
+#include <stdio.h>

WARNING:TYPO_SPELLING: 'tha' may be misspelled - perhaps 'than'?
#211: FILE: lib/net/rte_dissect.c:81:
+		rte_ether_format_addr(buf, sizeof(buf), &arp->arp_data.arp_tha);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#268: FILE: lib/net/rte_dissect.c:138:
+		fprintf(f, "UDP %u %u → %u ", rte_be_to_cpu_16(udph->dgram_len), src_port, dst_port);

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#290: FILE: lib/net/rte_dissect.c:160:
+#define PRINT_TCP_FLAG(flag) \
+	if (tcph->tcp_flags & RTE_TCP_ ## flag ## _FLAG) \
+		fprintf(f, " [" #flag" ]")

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#505: FILE: lib/net/rte_dissect.h:12:
+#include <stdio.h>

total: 1 errors, 4 warnings, 421 lines checked