From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9F9745777 for ; Fri, 9 Aug 2024 11:16:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4F3342DC9; Fri, 9 Aug 2024 11:16:56 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 818B1402A5 for ; Fri, 9 Aug 2024 11:16:55 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 7B89C123EF6; Fri, 9 Aug 2024 11:16:55 +0200 (CEST) Subject: |WARNING| pw143040 [PATCH 3/5] eal: add atomic bit operations In-Reply-To: <20240809090439.589295-4-mattias.ronnblom@ericsson.com> References: <20240809090439.589295-4-mattias.ronnblom@ericsson.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= Message-Id: <20240809091655.7B89C123EF6@dpdk.org> Date: Fri, 9 Aug 2024 11:16:55 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/143040 _coding style issues_ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #218: FILE: lib/eal/include/rte_bitops.h:251: + uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #218: FILE: lib/eal/include/rte_bitops.h:251: + uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #219: FILE: lib/eal/include/rte_bitops.h:252: + const uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #219: FILE: lib/eal/include/rte_bitops.h:252: + const uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #220: FILE: lib/eal/include/rte_bitops.h:253: + uint64_t *: __rte_bit_atomic_test64, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #220: FILE: lib/eal/include/rte_bitops.h:253: + uint64_t *: __rte_bit_atomic_test64, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #221: FILE: lib/eal/include/rte_bitops.h:254: + const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #221: FILE: lib/eal/include/rte_bitops.h:254: + const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #243: FILE: lib/eal/include/rte_bitops.h:276: + uint32_t *: __rte_bit_atomic_set32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #243: FILE: lib/eal/include/rte_bitops.h:276: + uint32_t *: __rte_bit_atomic_set32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #244: FILE: lib/eal/include/rte_bitops.h:277: + uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #244: FILE: lib/eal/include/rte_bitops.h:277: + uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #265: FILE: lib/eal/include/rte_bitops.h:298: + uint32_t *: __rte_bit_atomic_clear32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #265: FILE: lib/eal/include/rte_bitops.h:298: + uint32_t *: __rte_bit_atomic_clear32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #266: FILE: lib/eal/include/rte_bitops.h:299: + uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #266: FILE: lib/eal/include/rte_bitops.h:299: + uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #289: FILE: lib/eal/include/rte_bitops.h:322: + uint32_t *: __rte_bit_atomic_assign32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #289: FILE: lib/eal/include/rte_bitops.h:322: + uint32_t *: __rte_bit_atomic_assign32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #290: FILE: lib/eal/include/rte_bitops.h:323: + uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #290: FILE: lib/eal/include/rte_bitops.h:323: + uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #313: FILE: lib/eal/include/rte_bitops.h:346: + uint32_t *: __rte_bit_atomic_flip32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #313: FILE: lib/eal/include/rte_bitops.h:346: + uint32_t *: __rte_bit_atomic_flip32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #314: FILE: lib/eal/include/rte_bitops.h:347: + uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #314: FILE: lib/eal/include/rte_bitops.h:347: + uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #337: FILE: lib/eal/include/rte_bitops.h:370: + uint32_t *: __rte_bit_atomic_test_and_set32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #337: FILE: lib/eal/include/rte_bitops.h:370: + uint32_t *: __rte_bit_atomic_test_and_set32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #338: FILE: lib/eal/include/rte_bitops.h:371: + uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #338: FILE: lib/eal/include/rte_bitops.h:371: + uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #362: FILE: lib/eal/include/rte_bitops.h:395: + uint32_t *: __rte_bit_atomic_test_and_clear32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #362: FILE: lib/eal/include/rte_bitops.h:395: + uint32_t *: __rte_bit_atomic_test_and_clear32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #363: FILE: lib/eal/include/rte_bitops.h:396: + uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #363: FILE: lib/eal/include/rte_bitops.h:396: + uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #390: FILE: lib/eal/include/rte_bitops.h:423: + uint32_t *: __rte_bit_atomic_test_and_assign32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #390: FILE: lib/eal/include/rte_bitops.h:423: + uint32_t *: __rte_bit_atomic_test_and_assign32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #391: FILE: lib/eal/include/rte_bitops.h:424: + uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #391: FILE: lib/eal/include/rte_bitops.h:424: + uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #405: FILE: lib/eal/include/rte_bitops.h:503: + __rte_bit_atomic_test ## size(const uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #410: FILE: lib/eal/include/rte_bitops.h:508: + const RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #419: FILE: lib/eal/include/rte_bitops.h:517: + __rte_bit_atomic_set ## size(uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #424: FILE: lib/eal/include/rte_bitops.h:522: + RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #433: FILE: lib/eal/include/rte_bitops.h:531: + __rte_bit_atomic_clear ## size(uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #438: FILE: lib/eal/include/rte_bitops.h:536: + RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #447: FILE: lib/eal/include/rte_bitops.h:545: + __rte_bit_atomic_flip ## size(uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #452: FILE: lib/eal/include/rte_bitops.h:550: + RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #461: FILE: lib/eal/include/rte_bitops.h:559: + __rte_bit_atomic_assign ## size(uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #475: FILE: lib/eal/include/rte_bitops.h:573: + __rte_bit_atomic_test_and_set ## size(uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #481: FILE: lib/eal/include/rte_bitops.h:579: + RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #495: FILE: lib/eal/include/rte_bitops.h:593: + __rte_bit_atomic_test_and_clear ## size(uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #501: FILE: lib/eal/include/rte_bitops.h:599: + RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:CODE_INDENT: code indent should use tabs where possible #506: FILE: lib/eal/include/rte_bitops.h:604: +^I prev = rte_atomic_fetch_and_explicit(a_addr, ~mask,^I\$ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #515: FILE: lib/eal/include/rte_bitops.h:613: + __rte_bit_atomic_test_and_assign ## size(uint ## size ## _t *addr, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #528: FILE: lib/eal/include/rte_bitops.h:626: +#define __RTE_GEN_BIT_ATOMIC_OPS(size) \ + __RTE_GEN_BIT_ATOMIC_TEST(size) \ + __RTE_GEN_BIT_ATOMIC_SET(size) \ + __RTE_GEN_BIT_ATOMIC_CLEAR(size) \ + __RTE_GEN_BIT_ATOMIC_ASSIGN(size) \ + __RTE_GEN_BIT_ATOMIC_TEST_AND_SET(size) \ + __RTE_GEN_BIT_ATOMIC_TEST_AND_CLEAR(size) \ + __RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(size) \ + __RTE_GEN_BIT_ATOMIC_FLIP(size) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #564: FILE: lib/eal/include/rte_bitops.h:1386: +#define __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, size, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name) \ + static inline ret_type \ + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ + arg2_type arg2_name) \ + { \ + return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name); \ + } ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #567: FILE: lib/eal/include/rte_bitops.h:1389: + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #573: FILE: lib/eal/include/rte_bitops.h:1395: +#define __RTE_BIT_OVERLOAD_3R(fun, qualifier, ret_type, arg1_type, arg1_name, \ + arg2_type, arg2_name) \ + __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 32, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name) \ + __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 64, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name) ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #583: FILE: lib/eal/include/rte_bitops.h:1405: + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #590: FILE: lib/eal/include/rte_bitops.h:1412: +#define __RTE_BIT_OVERLOAD_4(fun, qualifier, arg1_type, arg1_name, arg2_type, \ + arg2_name, arg3_type, arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 32, arg1_type, arg1_name, \ + arg2_type, arg2_name, arg3_type, arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 64, arg1_type, arg1_name, \ + arg2_type, arg2_name, arg3_type, arg3_name) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #597: FILE: lib/eal/include/rte_bitops.h:1419: +#define __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, size, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name, arg3_type, \ + arg3_name) \ + static inline ret_type \ + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ + arg2_type arg2_name, arg3_type arg3_name) \ + { \ + return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name, \ + arg3_name); \ + } ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #601: FILE: lib/eal/include/rte_bitops.h:1423: + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #608: FILE: lib/eal/include/rte_bitops.h:1430: +#define __RTE_BIT_OVERLOAD_4R(fun, qualifier, ret_type, arg1_type, arg1_name, \ + arg2_type, arg2_name, arg3_type, arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 32, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name, arg3_type, \ + arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 64, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name, arg3_type, \ + arg3_name) ERROR:SPACING: space required after that ',' (ctx:VxO) #625: FILE: lib/eal/include/rte_bitops.h:1447: +__RTE_BIT_OVERLOAD_3(atomic_set,, unsigned int, nr, int, memory_order) ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #626: FILE: lib/eal/include/rte_bitops.h:1448: +__RTE_BIT_OVERLOAD_3(atomic_clear,, unsigned int, nr, int, memory_order) ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #627: FILE: lib/eal/include/rte_bitops.h:1449: +__RTE_BIT_OVERLOAD_4(atomic_assign,, unsigned int, nr, bool, value, ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #629: FILE: lib/eal/include/rte_bitops.h:1451: +__RTE_BIT_OVERLOAD_3(atomic_flip,, unsigned int, nr, int, memory_order) ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #630: FILE: lib/eal/include/rte_bitops.h:1452: +__RTE_BIT_OVERLOAD_3R(atomic_test_and_set,, bool, unsigned int, nr, ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #632: FILE: lib/eal/include/rte_bitops.h:1454: +__RTE_BIT_OVERLOAD_3R(atomic_test_and_clear,, bool, unsigned int, nr, ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #634: FILE: lib/eal/include/rte_bitops.h:1456: +__RTE_BIT_OVERLOAD_4R(atomic_test_and_assign,, bool, unsigned int, nr, ^ total: 67 errors, 0 warnings, 450 lines checked __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function.