|WARNING| pw143072 [PATCH v3 5/5] eal: extend bitops to handle volatile pointers

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: |WARNING| pw143072 [PATCH v3 5/5] eal: extend bitops to handle volatile pointers
Date: Mon, 12 Aug 2024 15:00:23 +0200 (CEST)	[thread overview]
Message-ID: <20240812130023.E1B39123EF6@dpdk.org> (raw)
In-Reply-To: <20240812124930.604796-6-mattias.ronnblom@ericsson.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143072

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#184: FILE: app/test/test_bitops.c:44:
+			const mod uint ## size ## _t *const_ptr = &word; \
 			                             ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#193: FILE: app/test/test_bitops.c:62:
+		    rte_bit_assign, rte_bit_flip, rte_bit_test, 32,)
 		                                                  ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#197: FILE: app/test/test_bitops.c:65:
+		    rte_bit_assign, rte_bit_flip, rte_bit_test, 64,)
 		                                                  ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#212: FILE: app/test/test_bitops.c:90:
+		    bit_atomic_flip, bit_atomic_test, 32,)
 		                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#217: FILE: app/test/test_bitops.c:94:
+		    bit_atomic_flip, bit_atomic_test, 64,)
 		                                        ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#258: FILE: lib/eal/include/rte_bitops.h:132:
+		 uint32_t *: __rte_bit_test32,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#258: FILE: lib/eal/include/rte_bitops.h:132:
+		 uint32_t *: __rte_bit_test32,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#259: FILE: lib/eal/include/rte_bitops.h:133:
+		 const uint32_t *: __rte_bit_test32,			\
 		                ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#259: FILE: lib/eal/include/rte_bitops.h:133:
+		 const uint32_t *: __rte_bit_test32,			\
 		                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#260: FILE: lib/eal/include/rte_bitops.h:134:
+		 volatile uint32_t *: __rte_bit_v_test32,		\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#260: FILE: lib/eal/include/rte_bitops.h:134:
+		 volatile uint32_t *: __rte_bit_v_test32,		\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#261: FILE: lib/eal/include/rte_bitops.h:135:
+		 const volatile uint32_t *: __rte_bit_v_test32,		\
 		                         ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#261: FILE: lib/eal/include/rte_bitops.h:135:
+		 const volatile uint32_t *: __rte_bit_v_test32,		\
 		                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#262: FILE: lib/eal/include/rte_bitops.h:136:
+		 uint64_t *: __rte_bit_test64,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#262: FILE: lib/eal/include/rte_bitops.h:136:
+		 uint64_t *: __rte_bit_test64,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#263: FILE: lib/eal/include/rte_bitops.h:137:
+		 const uint64_t *: __rte_bit_test64,			\
 		                ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#263: FILE: lib/eal/include/rte_bitops.h:137:
+		 const uint64_t *: __rte_bit_test64,			\
 		                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#264: FILE: lib/eal/include/rte_bitops.h:138:
+		 volatile uint64_t *: __rte_bit_v_test64,		\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#264: FILE: lib/eal/include/rte_bitops.h:138:
+		 volatile uint64_t *: __rte_bit_v_test64,		\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#265: FILE: lib/eal/include/rte_bitops.h:139:
+		 const volatile uint64_t *: __rte_bit_v_test64)(addr, nr)
 		                         ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#265: FILE: lib/eal/include/rte_bitops.h:139:
+		 const volatile uint64_t *: __rte_bit_v_test64)(addr, nr)
 		                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#279: FILE: lib/eal/include/rte_bitops.h:161:
+		 uint32_t *: __rte_bit_set32,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#279: FILE: lib/eal/include/rte_bitops.h:161:
+		 uint32_t *: __rte_bit_set32,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#280: FILE: lib/eal/include/rte_bitops.h:162:
+		 volatile uint32_t *: __rte_bit_v_set32,		\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#280: FILE: lib/eal/include/rte_bitops.h:162:
+		 volatile uint32_t *: __rte_bit_v_set32,		\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#281: FILE: lib/eal/include/rte_bitops.h:163:
+		 uint64_t *: __rte_bit_set64,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#281: FILE: lib/eal/include/rte_bitops.h:163:
+		 uint64_t *: __rte_bit_set64,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#282: FILE: lib/eal/include/rte_bitops.h:164:
+		 volatile uint64_t *: __rte_bit_v_set64)(addr, nr)
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#282: FILE: lib/eal/include/rte_bitops.h:164:
+		 volatile uint64_t *: __rte_bit_v_set64)(addr, nr)
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#296: FILE: lib/eal/include/rte_bitops.h:186:
+		 uint32_t *: __rte_bit_clear32,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#296: FILE: lib/eal/include/rte_bitops.h:186:
+		 uint32_t *: __rte_bit_clear32,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#297: FILE: lib/eal/include/rte_bitops.h:187:
+		 volatile uint32_t *: __rte_bit_v_clear32,		\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#297: FILE: lib/eal/include/rte_bitops.h:187:
+		 volatile uint32_t *: __rte_bit_v_clear32,		\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#298: FILE: lib/eal/include/rte_bitops.h:188:
+		 uint64_t *: __rte_bit_clear64,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#298: FILE: lib/eal/include/rte_bitops.h:188:
+		 uint64_t *: __rte_bit_clear64,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#299: FILE: lib/eal/include/rte_bitops.h:189:
+		 volatile uint64_t *: __rte_bit_v_clear64)(addr, nr)
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#299: FILE: lib/eal/include/rte_bitops.h:189:
+		 volatile uint64_t *: __rte_bit_v_clear64)(addr, nr)
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#308: FILE: lib/eal/include/rte_bitops.h:213:
+		 volatile uint32_t *: __rte_bit_v_assign32,		\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#308: FILE: lib/eal/include/rte_bitops.h:213:
+		 volatile uint32_t *: __rte_bit_v_assign32,		\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#309: FILE: lib/eal/include/rte_bitops.h:214:
+		 uint64_t *: __rte_bit_assign64,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#309: FILE: lib/eal/include/rte_bitops.h:214:
+		 uint64_t *: __rte_bit_assign64,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#310: FILE: lib/eal/include/rte_bitops.h:215:
+		 volatile uint64_t *: __rte_bit_v_assign64)(addr, nr, value)
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#310: FILE: lib/eal/include/rte_bitops.h:215:
+		 volatile uint64_t *: __rte_bit_v_assign64)(addr, nr, value)
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#319: FILE: lib/eal/include/rte_bitops.h:238:
+		 volatile uint32_t *: __rte_bit_v_flip32,		\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#319: FILE: lib/eal/include/rte_bitops.h:238:
+		 volatile uint32_t *: __rte_bit_v_flip32,		\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#320: FILE: lib/eal/include/rte_bitops.h:239:
+		 uint64_t *: __rte_bit_flip64,				\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#320: FILE: lib/eal/include/rte_bitops.h:239:
+		 uint64_t *: __rte_bit_flip64,				\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#321: FILE: lib/eal/include/rte_bitops.h:240:
+		 volatile uint64_t *: __rte_bit_v_flip64)(addr, nr)
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#321: FILE: lib/eal/include/rte_bitops.h:240:
+		 volatile uint64_t *: __rte_bit_v_flip64)(addr, nr)
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#329: FILE: lib/eal/include/rte_bitops.h:265:
+		 volatile uint32_t *: __rte_bit_atomic_v_test32,	\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#329: FILE: lib/eal/include/rte_bitops.h:265:
+		 volatile uint32_t *: __rte_bit_atomic_v_test32,	\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#330: FILE: lib/eal/include/rte_bitops.h:266:
+		 const volatile uint32_t *: __rte_bit_atomic_v_test32,	\
 		                         ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#330: FILE: lib/eal/include/rte_bitops.h:266:
+		 const volatile uint32_t *: __rte_bit_atomic_v_test32,	\
 		                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#334: FILE: lib/eal/include/rte_bitops.h:268:
+		 const uint64_t *: __rte_bit_atomic_test64,		\
 		                ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#334: FILE: lib/eal/include/rte_bitops.h:268:
+		 const uint64_t *: __rte_bit_atomic_test64,		\
 		                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#335: FILE: lib/eal/include/rte_bitops.h:269:
+		 volatile uint64_t *: __rte_bit_atomic_v_test64,	\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#335: FILE: lib/eal/include/rte_bitops.h:269:
+		 volatile uint64_t *: __rte_bit_atomic_v_test64,	\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#336: FILE: lib/eal/include/rte_bitops.h:270:
+		 const volatile uint64_t *: __rte_bit_atomic_v_test64) \
 		                         ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#336: FILE: lib/eal/include/rte_bitops.h:270:
+		 const volatile uint64_t *: __rte_bit_atomic_v_test64) \
 		                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#346: FILE: lib/eal/include/rte_bitops.h:293:
+		 volatile uint32_t *: __rte_bit_atomic_v_set32,		\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#346: FILE: lib/eal/include/rte_bitops.h:293:
+		 volatile uint32_t *: __rte_bit_atomic_v_set32,		\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#347: FILE: lib/eal/include/rte_bitops.h:294:
+		 uint64_t *: __rte_bit_atomic_set64,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#347: FILE: lib/eal/include/rte_bitops.h:294:
+		 uint64_t *: __rte_bit_atomic_set64,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#348: FILE: lib/eal/include/rte_bitops.h:295:
+		 volatile uint64_t *: __rte_bit_atomic_v_set64)(addr, nr, \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#348: FILE: lib/eal/include/rte_bitops.h:295:
+		 volatile uint64_t *: __rte_bit_atomic_v_set64)(addr, nr, \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#358: FILE: lib/eal/include/rte_bitops.h:318:
+		 volatile uint32_t *: __rte_bit_atomic_v_clear32,	\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#358: FILE: lib/eal/include/rte_bitops.h:318:
+		 volatile uint32_t *: __rte_bit_atomic_v_clear32,	\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#359: FILE: lib/eal/include/rte_bitops.h:319:
+		 uint64_t *: __rte_bit_atomic_clear64,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#359: FILE: lib/eal/include/rte_bitops.h:319:
+		 uint64_t *: __rte_bit_atomic_clear64,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#360: FILE: lib/eal/include/rte_bitops.h:320:
+		 volatile uint64_t *: __rte_bit_atomic_v_clear64)(addr, nr, \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#360: FILE: lib/eal/include/rte_bitops.h:320:
+		 volatile uint64_t *: __rte_bit_atomic_v_clear64)(addr, nr, \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#371: FILE: lib/eal/include/rte_bitops.h:345:
+		 volatile uint32_t *: __rte_bit_atomic_v_assign32,	\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#371: FILE: lib/eal/include/rte_bitops.h:345:
+		 volatile uint32_t *: __rte_bit_atomic_v_assign32,	\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#372: FILE: lib/eal/include/rte_bitops.h:346:
+		 uint64_t *: __rte_bit_atomic_assign64,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#372: FILE: lib/eal/include/rte_bitops.h:346:
+		 uint64_t *: __rte_bit_atomic_assign64,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#373: FILE: lib/eal/include/rte_bitops.h:347:
+		 volatile uint64_t *: __rte_bit_atomic_v_assign64)(addr, nr, \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#373: FILE: lib/eal/include/rte_bitops.h:347:
+		 volatile uint64_t *: __rte_bit_atomic_v_assign64)(addr, nr, \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#384: FILE: lib/eal/include/rte_bitops.h:372:
+		 volatile uint32_t *: __rte_bit_atomic_v_flip32,	\
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#384: FILE: lib/eal/include/rte_bitops.h:372:
+		 volatile uint32_t *: __rte_bit_atomic_v_flip32,	\
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#385: FILE: lib/eal/include/rte_bitops.h:373:
+		 uint64_t *: __rte_bit_atomic_flip64,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#385: FILE: lib/eal/include/rte_bitops.h:373:
+		 uint64_t *: __rte_bit_atomic_flip64,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#386: FILE: lib/eal/include/rte_bitops.h:374:
+		 volatile uint64_t *: __rte_bit_atomic_v_flip64)(addr, nr, \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#386: FILE: lib/eal/include/rte_bitops.h:374:
+		 volatile uint64_t *: __rte_bit_atomic_v_flip64)(addr, nr, \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#397: FILE: lib/eal/include/rte_bitops.h:399:
+		 volatile uint32_t *: __rte_bit_atomic_v_test_and_set32, \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#397: FILE: lib/eal/include/rte_bitops.h:399:
+		 volatile uint32_t *: __rte_bit_atomic_v_test_and_set32, \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#398: FILE: lib/eal/include/rte_bitops.h:400:
+		 uint64_t *: __rte_bit_atomic_test_and_set64,		\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#398: FILE: lib/eal/include/rte_bitops.h:400:
+		 uint64_t *: __rte_bit_atomic_test_and_set64,		\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#399: FILE: lib/eal/include/rte_bitops.h:401:
+		 volatile uint64_t *: __rte_bit_atomic_v_test_and_set64) \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#399: FILE: lib/eal/include/rte_bitops.h:401:
+		 volatile uint64_t *: __rte_bit_atomic_v_test_and_set64) \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#410: FILE: lib/eal/include/rte_bitops.h:426:
+		 volatile uint32_t *: __rte_bit_atomic_v_test_and_clear32, \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#410: FILE: lib/eal/include/rte_bitops.h:426:
+		 volatile uint32_t *: __rte_bit_atomic_v_test_and_clear32, \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#411: FILE: lib/eal/include/rte_bitops.h:427:
+		 uint64_t *: __rte_bit_atomic_test_and_clear64,		\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#411: FILE: lib/eal/include/rte_bitops.h:427:
+		 uint64_t *: __rte_bit_atomic_test_and_clear64,		\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#412: FILE: lib/eal/include/rte_bitops.h:428:
+		 volatile uint64_t *: __rte_bit_atomic_v_test_and_clear64) \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#412: FILE: lib/eal/include/rte_bitops.h:428:
+		 volatile uint64_t *: __rte_bit_atomic_v_test_and_clear64) \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#424: FILE: lib/eal/include/rte_bitops.h:456:
+		 volatile uint32_t *: __rte_bit_atomic_v_test_and_assign32, \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#424: FILE: lib/eal/include/rte_bitops.h:456:
+		 volatile uint32_t *: __rte_bit_atomic_v_test_and_assign32, \
 		                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#425: FILE: lib/eal/include/rte_bitops.h:457:
+		 uint64_t *: __rte_bit_atomic_test_and_assign64,	\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#425: FILE: lib/eal/include/rte_bitops.h:457:
+		 uint64_t *: __rte_bit_atomic_test_and_assign64,	\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#426: FILE: lib/eal/include/rte_bitops.h:458:
+		 volatile uint64_t *: __rte_bit_atomic_v_test_and_assign64) \
 		                   ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#426: FILE: lib/eal/include/rte_bitops.h:458:
+		 volatile uint64_t *: __rte_bit_atomic_v_test_and_assign64) \
 		                    ^

ERROR:SPACING: space required after that ',' (ctx:BxO)
#436: FILE: lib/eal/include/rte_bitops.h:529:
+	__RTE_GEN_BIT_OPS(,, size) \
 	                  ^

ERROR:SPACING: space required after that ',' (ctx:BxO)
#446: FILE: lib/eal/include/rte_bitops.h:670:
+	__RTE_GEN_BIT_ATOMIC_OPS(,, size) \
 	                         ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#460: FILE: lib/eal/include/rte_bitops.h:1382:
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
 	                                               ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#470: FILE: lib/eal/include/rte_bitops.h:1388:
+#define __RTE_BIT_OVERLOAD_SZ_2(family, fun, c, size, arg1_type, arg1_name) \
+	__RTE_BIT_OVERLOAD_V_2(family,, fun, c, size, arg1_type,	\
+			       arg1_name)				\
+	__RTE_BIT_OVERLOAD_V_2(family, v_, fun, c volatile, size, \
+			       arg1_type, arg1_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#471: FILE: lib/eal/include/rte_bitops.h:1389:
+	__RTE_BIT_OVERLOAD_V_2(family,, fun, c, size, arg1_type,	\
 	                             ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#478: FILE: lib/eal/include/rte_bitops.h:1394:
+#define __RTE_BIT_OVERLOAD_2(family, fun, c, arg1_type, arg1_name)	\
+	__RTE_BIT_OVERLOAD_SZ_2(family, fun, c, 32, arg1_type, arg1_name) \
+	__RTE_BIT_OVERLOAD_SZ_2(family, fun, c, 64, arg1_type, arg1_name)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#482: FILE: lib/eal/include/rte_bitops.h:1398:
+#define __RTE_BIT_OVERLOAD_V_2R(family, v, fun, c, size, ret_type, arg1_type, \
+				arg1_name)				\
 	static inline ret_type						\
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
 			arg1_type arg1_name)				\
 	{								\
+		return __rte_bit_ ## family ## v ## fun ## size(addr,	\
+								arg1_name); \
 	}

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#486: FILE: lib/eal/include/rte_bitops.h:1401:
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
 	                                               ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#496: FILE: lib/eal/include/rte_bitops.h:1408:
+#define __RTE_BIT_OVERLOAD_SZ_2R(family, fun, c, size, ret_type, arg1_type, \
+				 arg1_name)				\
+	__RTE_BIT_OVERLOAD_V_2R(family,, fun, c, size, ret_type, arg1_type, \
+				arg1_name)				\
+	__RTE_BIT_OVERLOAD_V_2R(family, v_, fun, c volatile,		\
+				size, ret_type, arg1_type, arg1_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#498: FILE: lib/eal/include/rte_bitops.h:1410:
+	__RTE_BIT_OVERLOAD_V_2R(family,, fun, c, size, ret_type, arg1_type, \
 	                              ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#503: FILE: lib/eal/include/rte_bitops.h:1415:
+#define __RTE_BIT_OVERLOAD_2R(family, fun, c, ret_type, arg1_type, arg1_name) \
+	__RTE_BIT_OVERLOAD_SZ_2R(family, fun, c, 32, ret_type, arg1_type, \
 				 arg1_name)				\
+	__RTE_BIT_OVERLOAD_SZ_2R(family, fun, c, 64, ret_type, arg1_type, \
 				 arg1_name)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#517: FILE: lib/eal/include/rte_bitops.h:1424:
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
 	                                               ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#526: FILE: lib/eal/include/rte_bitops.h:1431:
+#define __RTE_BIT_OVERLOAD_SZ_3(family, fun, c, size, arg1_type, arg1_name, \
+				arg2_type, arg2_name)			\
+	__RTE_BIT_OVERLOAD_V_3(family,, fun, c, size, arg1_type, arg1_name, \
+			       arg2_type, arg2_name)			\
+	__RTE_BIT_OVERLOAD_V_3(family, v_, fun, c volatile, size, arg1_type, \
+			       arg1_name, arg2_type, arg2_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#528: FILE: lib/eal/include/rte_bitops.h:1433:
+	__RTE_BIT_OVERLOAD_V_3(family,, fun, c, size, arg1_type, arg1_name, \
 	                             ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#533: FILE: lib/eal/include/rte_bitops.h:1438:
+#define __RTE_BIT_OVERLOAD_3(family, fun, c, arg1_type, arg1_name, arg2_type, \
 			     arg2_name)					\
+	__RTE_BIT_OVERLOAD_SZ_3(family, fun, c, 32, arg1_type, arg1_name, \
 				arg2_type, arg2_name)			\
+	__RTE_BIT_OVERLOAD_SZ_3(family, fun, c, 64, arg1_type, arg1_name, \
 				arg2_type, arg2_name)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#544: FILE: lib/eal/include/rte_bitops.h:1445:
+#define __RTE_BIT_OVERLOAD_V_3R(family, v, fun, c, size, ret_type, arg1_type, \
+				arg1_name, arg2_type, arg2_name)	\
 	static inline ret_type						\
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
+				  arg1_type arg1_name, arg2_type arg2_name) \
 	{								\
+		return __rte_bit_ ## family ## v ## fun ## size(addr,	\
+								arg1_name, \
+								arg2_name); \
 	}

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#549: FILE: lib/eal/include/rte_bitops.h:1448:
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
 	                                               ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#561: FILE: lib/eal/include/rte_bitops.h:1456:
+#define __RTE_BIT_OVERLOAD_SZ_3R(family, fun, c, size, ret_type, arg1_type, \
 				 arg1_name, arg2_type, arg2_name)	\
+	__RTE_BIT_OVERLOAD_V_3R(family,, fun, c, size, ret_type, \
+				arg1_type, arg1_name, arg2_type, arg2_name) \
+	__RTE_BIT_OVERLOAD_V_3R(family, v_, fun, c volatile, size, \
+				ret_type, arg1_type, arg1_name, arg2_type, \
+				arg2_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#565: FILE: lib/eal/include/rte_bitops.h:1458:
+	__RTE_BIT_OVERLOAD_V_3R(family,, fun, c, size, ret_type, \
 	                              ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#573: FILE: lib/eal/include/rte_bitops.h:1464:
+#define __RTE_BIT_OVERLOAD_3R(family, fun, c, ret_type, arg1_type, arg1_name, \
+			      arg2_type, arg2_name)			\
+	__RTE_BIT_OVERLOAD_SZ_3R(family, fun, c, 32, ret_type,		\
+				 arg1_type, arg1_name, arg2_type, arg2_name) \
+	__RTE_BIT_OVERLOAD_SZ_3R(family, fun, c, 64, ret_type, \
+				 arg1_type, arg1_name, arg2_type, arg2_name)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#585: FILE: lib/eal/include/rte_bitops.h:1474:
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
 	                                               ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#599: FILE: lib/eal/include/rte_bitops.h:1483:
+#define __RTE_BIT_OVERLOAD_SZ_4(family, fun, c, size, arg1_type, arg1_name, \
 				arg2_type, arg2_name, arg3_type, arg3_name) \
+	__RTE_BIT_OVERLOAD_V_4(family,, fun, c, size, arg1_type,	\
+			       arg1_name, arg2_type, arg2_name, arg3_type, \
+			       arg3_name)				\
+	__RTE_BIT_OVERLOAD_V_4(family, v_, fun, c volatile, size,	\
+			       arg1_type, arg1_name, arg2_type, arg2_name, \
+			       arg3_type, arg3_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#607: FILE: lib/eal/include/rte_bitops.h:1485:
+	__RTE_BIT_OVERLOAD_V_4(family,, fun, c, size, arg1_type,	\
 	                             ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#614: FILE: lib/eal/include/rte_bitops.h:1492:
+#define __RTE_BIT_OVERLOAD_4(family, fun, c, arg1_type, arg1_name, arg2_type, \
+			     arg2_name, arg3_type, arg3_name)		\
+	__RTE_BIT_OVERLOAD_SZ_4(family, fun, c, 32, arg1_type,		\
+				arg1_name, arg2_type, arg2_name, arg3_type, \
+				arg3_name)				\
+	__RTE_BIT_OVERLOAD_SZ_4(family, fun, c, 64, arg1_type,		\
+				arg1_name, arg2_type, arg2_name, arg3_type, \
+				arg3_name)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#623: FILE: lib/eal/include/rte_bitops.h:1501:
+#define __RTE_BIT_OVERLOAD_V_4R(family, v, fun, c, size, ret_type, arg1_type, \
+				arg1_name, arg2_type, arg2_name, arg3_type, \
+				arg3_name)				\
 	static inline ret_type						\
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
+				  arg1_type arg1_name, arg2_type arg2_name, \
+				  arg3_type arg3_name)			\
 	{								\
+		return __rte_bit_ ## family ## v ## fun ## size(addr,	\
+								arg1_name, \
+								arg2_name, \
+								arg3_name); \
 	}

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#629: FILE: lib/eal/include/rte_bitops.h:1505:
+	rte_bit_ ## family ## fun(c uint ## size ## _t *addr,		\
 	                                               ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#644: FILE: lib/eal/include/rte_bitops.h:1515:
+#define __RTE_BIT_OVERLOAD_SZ_4R(family, fun, c, size, ret_type, arg1_type, \
 				 arg1_name, arg2_type, arg2_name, arg3_type, \
 				 arg3_name)				\
+	__RTE_BIT_OVERLOAD_V_4R(family,, fun, c, size, ret_type, arg1_type, \
+				arg1_name, arg2_type, arg2_name, arg3_type, \
+				arg3_name)				\
+	__RTE_BIT_OVERLOAD_V_4R(family, v_, fun, c volatile, size,	\
+				ret_type, arg1_type, arg1_name, arg2_type, \
+				arg2_name, arg3_type, arg3_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#658: FILE: lib/eal/include/rte_bitops.h:1518:
+	__RTE_BIT_OVERLOAD_V_4R(family,, fun, c, size, ret_type, arg1_type, \
 	                              ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#665: FILE: lib/eal/include/rte_bitops.h:1525:
+#define __RTE_BIT_OVERLOAD_4R(family, fun, c, ret_type, arg1_type, arg1_name, \
+			      arg2_type, arg2_name, arg3_type, arg3_name) \
+	__RTE_BIT_OVERLOAD_SZ_4R(family, fun, c, 32, ret_type,		\
+				 arg1_type, arg1_name, arg2_type, arg2_name, \
+				 arg3_type, arg3_name)			\
+	__RTE_BIT_OVERLOAD_SZ_4R(family, fun, c, 64, ret_type,		\
+				 arg1_type, arg1_name, arg2_type, arg2_name, \
+				 arg3_type, arg3_name)

ERROR:SPACING: space required after that ',' (ctx:VxO)
#675: FILE: lib/eal/include/rte_bitops.h:1535:
+__RTE_BIT_OVERLOAD_2(, set,, unsigned int, nr)
                           ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#676: FILE: lib/eal/include/rte_bitops.h:1536:
+__RTE_BIT_OVERLOAD_2(, clear,, unsigned int, nr)
                             ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#677: FILE: lib/eal/include/rte_bitops.h:1537:
+__RTE_BIT_OVERLOAD_3(, assign,, unsigned int, nr, bool, value)
                              ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#678: FILE: lib/eal/include/rte_bitops.h:1538:
+__RTE_BIT_OVERLOAD_2(, flip,, unsigned int, nr)
                            ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#685: FILE: lib/eal/include/rte_bitops.h:1542:
+__RTE_BIT_OVERLOAD_3(atomic_, set,, unsigned int, nr, int, memory_order)
                                  ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#686: FILE: lib/eal/include/rte_bitops.h:1543:
+__RTE_BIT_OVERLOAD_3(atomic_, clear,, unsigned int, nr, int, memory_order)
                                    ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#687: FILE: lib/eal/include/rte_bitops.h:1544:
+__RTE_BIT_OVERLOAD_4(atomic_, assign,, unsigned int, nr, bool, value,
                                     ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#691: FILE: lib/eal/include/rte_bitops.h:1546:
+__RTE_BIT_OVERLOAD_3(atomic_, flip,, unsigned int, nr, int, memory_order)
                                   ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#692: FILE: lib/eal/include/rte_bitops.h:1547:
+__RTE_BIT_OVERLOAD_3R(atomic_, test_and_set,, bool, unsigned int, nr,
                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#695: FILE: lib/eal/include/rte_bitops.h:1549:
+__RTE_BIT_OVERLOAD_3R(atomic_, test_and_clear,, bool, unsigned int, nr,
                                              ^

ERROR:SPACING: space required after that ',' (ctx:VxO)
#698: FILE: lib/eal/include/rte_bitops.h:1551:
+__RTE_BIT_OVERLOAD_4R(atomic_, test_and_assign,, bool, unsigned int, nr,
                                               ^

total: 141 errors, 0 warnings, 514 lines checked

next prev parent reply	other threads:[~2024-08-12 13:00 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240812124930.604796-6-mattias.ronnblom@ericsson.com>
2024-08-12 12:33 ` |SUCCESS| pw143071-143072 " qemudev
2024-08-12 12:38 ` qemudev
2024-08-12 13:00 ` checkpatch [this message]
2024-08-12 13:24 ` |SUCCESS| pw143071-143072 [PATCH] [v3,5/5] eal: extend bitops to han dpdklab
2024-08-12 13:33 ` dpdklab
2024-08-12 13:36 ` dpdklab
2024-08-12 13:36 ` |PENDING| " dpdklab
2024-08-12 13:37 ` dpdklab
2024-08-12 13:37 ` dpdklab
2024-08-12 13:38 ` |SUCCESS| " dpdklab
2024-08-12 13:43 ` |PENDING| " dpdklab
2024-08-12 13:44 ` dpdklab
2024-08-12 13:46 ` dpdklab
2024-08-12 13:46 ` dpdklab
2024-08-12 13:49 ` dpdklab
2024-08-12 13:49 ` |SUCCESS| " dpdklab
2024-08-12 13:49 ` |PENDING| " dpdklab
2024-08-12 13:50 ` dpdklab
2024-08-12 13:51 ` |SUCCESS| " dpdklab
2024-08-12 13:52 ` |PENDING| " dpdklab
2024-08-12 13:54 ` dpdklab
2024-08-12 13:54 ` dpdklab
2024-08-12 13:55 ` |SUCCESS| " dpdklab
2024-08-12 13:55 ` dpdklab
2024-08-12 13:57 ` |PENDING| " dpdklab
2024-08-12 14:00 ` dpdklab
2024-08-12 14:01 ` dpdklab
2024-08-12 14:02 ` dpdklab
2024-08-12 14:02 ` |FAILURE| pw143072 [PATCH v3 5/5] eal: extend bitops to handle volatile pointers 0-day Robot
2024-08-12 14:02 ` |PENDING| pw143071-143072 [PATCH] [v3,5/5] eal: extend bitops to han dpdklab
2024-08-12 14:04 ` dpdklab
2024-08-12 14:04 ` |SUCCESS| " dpdklab
2024-08-12 14:07 ` dpdklab
2024-08-12 14:08 ` |PENDING| " dpdklab
2024-08-12 14:08 ` dpdklab
2024-08-12 14:09 ` dpdklab
2024-08-12 14:09 ` dpdklab
2024-08-12 14:09 ` dpdklab
2024-08-12 14:11 ` dpdklab
2024-08-12 14:11 ` |FAILURE| " dpdklab
2024-08-12 14:12 ` dpdklab
2024-08-12 14:12 ` |PENDING| " dpdklab
2024-08-12 14:13 ` dpdklab
2024-08-12 14:13 ` |SUCCESS| " dpdklab
2024-08-12 14:14 ` |PENDING| " dpdklab
2024-08-12 14:14 ` |FAILURE| " dpdklab
2024-08-12 14:15 ` |PENDING| " dpdklab
2024-08-12 14:15 ` |SUCCESS| " dpdklab
2024-08-12 14:16 ` dpdklab
2024-08-12 14:16 ` |FAILURE| " dpdklab
2024-08-12 14:16 ` |PENDING| " dpdklab
2024-08-12 14:17 ` dpdklab
2024-08-12 14:17 ` dpdklab
2024-08-12 14:17 ` |SUCCESS| " dpdklab
2024-08-12 14:18 ` |FAILURE| " dpdklab
2024-08-12 14:20 ` |PENDING| " dpdklab
2024-08-12 14:22 ` |FAILURE| " dpdklab
2024-08-12 14:24 ` |PENDING| " dpdklab
2024-08-12 14:26 ` |FAILURE| " dpdklab
2024-08-12 14:27 ` |PENDING| " dpdklab
2024-08-12 14:27 ` |FAILURE| " dpdklab
2024-08-12 14:28 ` |SUCCESS| " dpdklab
2024-08-12 14:31 ` |PENDING| " dpdklab
2024-08-12 14:32 ` |FAILURE| " dpdklab
2024-08-12 14:35 ` dpdklab
2024-08-12 14:36 ` |PENDING| " dpdklab
2024-08-12 14:36 ` |SUCCESS| " dpdklab
2024-08-12 14:37 ` |PENDING| " dpdklab
2024-08-12 14:39 ` |FAILURE| " dpdklab
2024-08-12 14:40 ` dpdklab
2024-08-12 14:40 ` |SUCCESS| " dpdklab
2024-08-12 14:42 ` |PENDING| " dpdklab
2024-08-12 14:43 ` |FAILURE| " dpdklab
2024-08-12 14:44 ` |PENDING| " dpdklab
2024-08-12 14:48 ` |FAILURE| " dpdklab
2024-08-12 14:49 ` |PENDING| " dpdklab
2024-08-12 14:50 ` |FAILURE| " dpdklab
2024-08-12 14:50 ` |SUCCESS| " dpdklab
2024-08-12 14:52 ` |PENDING| " dpdklab
2024-08-12 14:52 ` dpdklab
2024-08-12 14:52 ` |FAILURE| " dpdklab
2024-08-12 14:58 ` |PENDING| " dpdklab
2024-08-12 15:00 ` dpdklab
2024-08-12 15:06 ` dpdklab
2024-08-12 15:08 ` dpdklab
2024-08-12 15:08 ` dpdklab
2024-08-12 15:08 ` dpdklab
2024-08-12 15:26 ` dpdklab
2024-08-12 15:28 ` dpdklab
2024-08-12 15:33 ` dpdklab
2024-08-12 15:34 ` dpdklab
2024-08-12 15:36 ` dpdklab
2024-08-12 15:41 ` dpdklab
2024-08-12 15:43 ` dpdklab
2024-08-12 15:44 ` |SUCCESS| " dpdklab
2024-08-12 15:44 ` |PENDING| " dpdklab
2024-08-12 15:59 ` dpdklab
2024-08-12 16:08 ` dpdklab
2024-08-12 16:22 ` dpdklab
2024-08-12 16:52 ` |SUCCESS| " dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240812130023.E1B39123EF6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).