From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Junlong Wang <wang.junlong1@zte.com.cn>
Subject: |WARNING| pw143420 [PATCH v1 2/2] net/zxdh: provided zxdh basic init
Date: Wed, 28 Aug 2024 09:26:51 +0200 (CEST) [thread overview]
Message-ID: <20240828072652.0452B120778@dpdk.org> (raw)
In-Reply-To: <20240828072526.2777230-1-wang.junlong1@zte.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143420
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->use_msix != ZXDH_MSIX_NONE'
#504: FILE: drivers/net/zxdh/zxdh_ethdev.c:308:
+ if (vtpci_with_feature(hw, ZXDH_NET_F_STATUS) && (hw->use_msix != ZXDH_MSIX_NONE)) {
WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#730: FILE: drivers/net/zxdh/zxdh_ethdev.c:534:
+ hw->vqs[i * 2], i + ZXDH_QUE_INTR_VEC_BASE);
WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#732: FILE: drivers/net/zxdh/zxdh_ethdev.c:536:
+ i * 2, i + ZXDH_QUE_INTR_VEC_BASE, vec);
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#968: FILE: drivers/net/zxdh/zxdh_ethdev.c:772:
+ hw->vlan_fiter = (uint64_t *)rte_malloc("vlan_filter", 64 * sizeof(uint64_t), 1);
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#969: FILE: drivers/net/zxdh/zxdh_ethdev.c:773:
+ memset(hw->vlan_fiter, 0, 64 * sizeof(uint64_t));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'g_dtb_data.init_done'
#1081: FILE: drivers/net/zxdh/zxdh_ethdev.c:885:
+ if ((g_dtb_data.init_done) && (g_dtb_data.bind_device == dev)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'g_dtb_data.bind_device == dev'
#1081: FILE: drivers/net/zxdh/zxdh_ethdev.c:885:
+ if ((g_dtb_data.init_done) && (g_dtb_data.bind_device == dev)) {
CHECK:CAMELCASE: Avoid CamelCase: <HashResInit>
#1219: FILE: drivers/net/zxdh/zxdh_ethdev.c:1023:
+ DPP_APT_HASH_RES_INIT_T HashResInit = {0};
CHECK:CAMELCASE: Avoid CamelCase: <EramResInit>
#1220: FILE: drivers/net/zxdh/zxdh_ethdev.c:1024:
+ DPP_APT_ERAM_RES_INIT_T EramResInit = {0};
CHECK:CAMELCASE: Avoid CamelCase: <StatResInit>
#1221: FILE: drivers/net/zxdh/zxdh_ethdev.c:1025:
+ DPP_APT_STAT_RES_INIT_T StatResInit = {0};
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'zxdh_shared_data != NULL'
#1310: FILE: drivers/net/zxdh/zxdh_ethdev.c:1114:
+ if ((zxdh_shared_data != NULL) && zxdh_shared_data->npsdk_init_done) {
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1339: FILE: drivers/net/zxdh/zxdh_ethdev.c:1143:
+ rte_free(priv->vlan_fiter);
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1340: FILE: drivers/net/zxdh/zxdh_ethdev.c:1144:
+ priv->vlan_fiter = NULL;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!g_dtb_data.init_done'
#1383: FILE: drivers/net/zxdh/zxdh_ethdev.c:1187:
+ if ((!g_dtb_data.init_done) && (!g_dtb_data.dev_refcnt))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!g_dtb_data.dev_refcnt'
#1383: FILE: drivers/net/zxdh/zxdh_ethdev.c:1187:
+ if ((!g_dtb_data.init_done) && (!g_dtb_data.dev_refcnt))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pcie_id' may be better as '(pcie_id)' to avoid precedence issues
#1543: FILE: drivers/net/zxdh/zxdh_ethdev.h:16:
+#define PF_PCIE_ID(pcie_id) ((pcie_id & 0xff00) | 1 << 11)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pcie_id' may be better as '(pcie_id)' to avoid precedence issues
#1544: FILE: drivers/net/zxdh/zxdh_ethdev.h:17:
+#define VF_PCIE_ID(pcie_id, vf_idx) ((pcie_id & 0xff00) | (1 << 11) | (vf_idx & 0xff))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'vf_idx' may be better as '(vf_idx)' to avoid precedence issues
#1544: FILE: drivers/net/zxdh/zxdh_ethdev.h:17:
+#define VF_PCIE_ID(pcie_id, vf_idx) ((pcie_id & 0xff00) | (1 << 11) | (vf_idx & 0xff))
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1679: FILE: drivers/net/zxdh/zxdh_ethdev.h:152:
+ uint64_t *vlan_fiter;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#2054: FILE: drivers/net/zxdh/zxdh_pci.c:318:
+ PMD_INIT_LOG(ERR, "invalid cap: overflows bar space: %u > %" PRIu64,
total: 0 errors, 7 warnings, 13 checks, 2698 lines checked
next prev parent reply other threads:[~2024-08-28 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240828072526.2777230-1-wang.junlong1@zte.com.cn>
2024-08-28 6:59 ` |FAILURE| pw143419-143420 " qemudev
2024-08-28 7:26 ` checkpatch [this message]
2024-08-28 7:56 ` |FAILURE| pw143419-143420 [PATCH] [v1, " dpdklab
2024-08-28 8:03 ` |FAILURE| pw143420 [PATCH v1 " 0-day Robot
2024-08-28 8:09 ` |FAILURE| pw143419-143420 [PATCH] [v1, " dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828072652.0452B120778@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wang.junlong1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).