From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 761FB45882
for <public@inbox.dpdk.org>; Wed, 28 Aug 2024 09:28:56 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id F157841611;
Wed, 28 Aug 2024 09:28:55 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
by mails.dpdk.org (Postfix) with ESMTP id 2912140265
for <test-report@dpdk.org>; Wed, 28 Aug 2024 09:26:52 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
id 0452B120778; Wed, 28 Aug 2024 09:26:51 +0200 (CEST)
Subject: |WARNING| pw143420 [PATCH v1 2/2] net/zxdh: provided zxdh basic init
In-Reply-To: <20240828072526.2777230-1-wang.junlong1@zte.com.cn>
References: <20240828072526.2777230-1-wang.junlong1@zte.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Junlong Wang <wang.junlong1@zte.com.cn>
Message-Id: <20240828072652.0452B120778@dpdk.org>
Date: Wed, 28 Aug 2024 09:26:51 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
<mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
<mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143420
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->use_msix != ZXDH_MSIX_NONE'
#504: FILE: drivers/net/zxdh/zxdh_ethdev.c:308:
+ if (vtpci_with_feature(hw, ZXDH_NET_F_STATUS) && (hw->use_msix != ZXDH_MSIX_NONE)) {
WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#730: FILE: drivers/net/zxdh/zxdh_ethdev.c:534:
+ hw->vqs[i * 2], i + ZXDH_QUE_INTR_VEC_BASE);
WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#732: FILE: drivers/net/zxdh/zxdh_ethdev.c:536:
+ i * 2, i + ZXDH_QUE_INTR_VEC_BASE, vec);
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#968: FILE: drivers/net/zxdh/zxdh_ethdev.c:772:
+ hw->vlan_fiter = (uint64_t *)rte_malloc("vlan_filter", 64 * sizeof(uint64_t), 1);
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#969: FILE: drivers/net/zxdh/zxdh_ethdev.c:773:
+ memset(hw->vlan_fiter, 0, 64 * sizeof(uint64_t));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'g_dtb_data.init_done'
#1081: FILE: drivers/net/zxdh/zxdh_ethdev.c:885:
+ if ((g_dtb_data.init_done) && (g_dtb_data.bind_device == dev)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'g_dtb_data.bind_device == dev'
#1081: FILE: drivers/net/zxdh/zxdh_ethdev.c:885:
+ if ((g_dtb_data.init_done) && (g_dtb_data.bind_device == dev)) {
CHECK:CAMELCASE: Avoid CamelCase: <HashResInit>
#1219: FILE: drivers/net/zxdh/zxdh_ethdev.c:1023:
+ DPP_APT_HASH_RES_INIT_T HashResInit = {0};
CHECK:CAMELCASE: Avoid CamelCase: <EramResInit>
#1220: FILE: drivers/net/zxdh/zxdh_ethdev.c:1024:
+ DPP_APT_ERAM_RES_INIT_T EramResInit = {0};
CHECK:CAMELCASE: Avoid CamelCase: <StatResInit>
#1221: FILE: drivers/net/zxdh/zxdh_ethdev.c:1025:
+ DPP_APT_STAT_RES_INIT_T StatResInit = {0};
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'zxdh_shared_data != NULL'
#1310: FILE: drivers/net/zxdh/zxdh_ethdev.c:1114:
+ if ((zxdh_shared_data != NULL) && zxdh_shared_data->npsdk_init_done) {
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1339: FILE: drivers/net/zxdh/zxdh_ethdev.c:1143:
+ rte_free(priv->vlan_fiter);
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1340: FILE: drivers/net/zxdh/zxdh_ethdev.c:1144:
+ priv->vlan_fiter = NULL;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!g_dtb_data.init_done'
#1383: FILE: drivers/net/zxdh/zxdh_ethdev.c:1187:
+ if ((!g_dtb_data.init_done) && (!g_dtb_data.dev_refcnt))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!g_dtb_data.dev_refcnt'
#1383: FILE: drivers/net/zxdh/zxdh_ethdev.c:1187:
+ if ((!g_dtb_data.init_done) && (!g_dtb_data.dev_refcnt))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pcie_id' may be better as '(pcie_id)' to avoid precedence issues
#1543: FILE: drivers/net/zxdh/zxdh_ethdev.h:16:
+#define PF_PCIE_ID(pcie_id) ((pcie_id & 0xff00) | 1 << 11)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pcie_id' may be better as '(pcie_id)' to avoid precedence issues
#1544: FILE: drivers/net/zxdh/zxdh_ethdev.h:17:
+#define VF_PCIE_ID(pcie_id, vf_idx) ((pcie_id & 0xff00) | (1 << 11) | (vf_idx & 0xff))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'vf_idx' may be better as '(vf_idx)' to avoid precedence issues
#1544: FILE: drivers/net/zxdh/zxdh_ethdev.h:17:
+#define VF_PCIE_ID(pcie_id, vf_idx) ((pcie_id & 0xff00) | (1 << 11) | (vf_idx & 0xff))
WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1679: FILE: drivers/net/zxdh/zxdh_ethdev.h:152:
+ uint64_t *vlan_fiter;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#2054: FILE: drivers/net/zxdh/zxdh_pci.c:318:
+ PMD_INIT_LOG(ERR, "invalid cap: overflows bar space: %u > %" PRIu64,
total: 0 errors, 7 warnings, 13 checks, 2698 lines checked