|WARNING| pw143419 [PATCH v1 1/2] net/zxdh: provided zxdh npsdk and msg chan

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Junlong Wang <wang.junlong1@zte.com.cn>
Subject: |WARNING| pw143419 [PATCH v1 1/2] net/zxdh: provided zxdh npsdk and msg chan
Date: Wed, 28 Aug 2024 09:27:25 +0200 (CEST)	[thread overview]
Message-ID: <20240828072725.707B0120778@dpdk.org> (raw)
In-Reply-To: <20240828072509.2777207-1-wang.junlong1@zte.com.cn>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143419

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'bus' may be better as '(bus)' to avoid precedence issues
#334: FILE: drivers/net/zxdh/zxdh_msg.c:17:
+#define BDF_ECAM(bus, devid, func)   (((bus & 0xff) << 8) | (func & 0x07) | ((devid & 0x1f) << 3))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'devid' may be better as '(devid)' to avoid precedence issues
#334: FILE: drivers/net/zxdh/zxdh_msg.c:17:
+#define BDF_ECAM(bus, devid, func)   (((bus & 0xff) << 8) | (func & 0x07) | ((devid & 0x1f) << 3))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#334: FILE: drivers/net/zxdh/zxdh_msg.c:17:
+#define BDF_ECAM(bus, devid, func)   (((bus & 0xff) << 8) | (func & 0x07) | ((devid & 0x1f) << 3))

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#480: FILE: drivers/net/zxdh/zxdh_msg.c:163:
+#define LOCK_MASTER_ID_MASK                (0x8000)

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#641: FILE: drivers/net/zxdh/zxdh_msg.c:324:
+		PMD_MSG_LOG(ERR, "write addr: 0x%" PRIu64 " + %" PRIu64 "",

WARNING:TYPO_SPELLING: 'mininal' may be misspelled - perhaps 'minimal'?
#840: FILE: drivers/net/zxdh/zxdh_msg.c:523:
+			"recv buffer's len: %" PRIu64 " is short than mininal 4 bytes
",

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#888: FILE: drivers/net/zxdh/zxdh_msg.c:571:
+					uint64_t label_addr, uint16_t master_id)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#897: FILE: drivers/net/zxdh/zxdh_msg.c:580:
+			label_write((uint64_t)label_addr, virt_lock_id, master_id);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#945: FILE: drivers/net/zxdh/zxdh_msg.c:628:
+					src_pcieid | LOCK_MASTER_ID_MASK);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#949: FILE: drivers/net/zxdh/zxdh_msg.c:632:
+					src_pcieid | LOCK_MASTER_ID_MASK);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'time_out_cnt == BAR_MSG_TIMEOUT_TH'
#1094: FILE: drivers/net/zxdh/zxdh_msg.c:777:
+	if ((time_out_cnt == BAR_MSG_TIMEOUT_TH) && (valid != BAR_MSG_CHAN_USABLE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'valid != BAR_MSG_CHAN_USABLE'
#1094: FILE: drivers/net/zxdh/zxdh_msg.c:777:
+	if ((time_out_cnt == BAR_MSG_TIMEOUT_TH) && (valid != BAR_MSG_CHAN_USABLE)) {

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#1172: FILE: drivers/net/zxdh/zxdh_msg.c:855:
+					uint8_t *reciver_buff, void *dev)

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#1182: FILE: drivers/net/zxdh/zxdh_msg.c:865:
+	recv_func(reciver_buff, msg_header->len, reps_buffer, &reps_len, dev);

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#1191: FILE: drivers/net/zxdh/zxdh_msg.c:874:
+static void __bar_msg_ack_async_msg_proc(struct bar_msg_header *msg_header, uint8_t *reciver_buff)

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#1206: FILE: drivers/net/zxdh/zxdh_msg.c:889:
+	memcpy(reps_buffer + 4, reciver_buff, msg_header->len);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around g_seqid_ring.reps_info_tbl[seq_id]
#1488: FILE: drivers/net/zxdh/zxdh_msg.c:1171:
+		struct seqid_item *reps_info = &(g_seqid_ring.reps_info_tbl[seq_id]);

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#1544: FILE: drivers/net/zxdh/zxdh_msg.h:33:
+#define ZXDH_QUE_INTR_VEC_BASE      (ZXDH_MSIX_INTR_DTB_VEC + ZXDH_MSIX_INTR_DTB_VEC_NUM) /* 5 */

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#1545: FILE: drivers/net/zxdh/zxdh_msg.h:34:
+#define ZXDH_QUE_INTR_VEC_NUM       256

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1951: FILE: drivers/net/zxdh/zxdh_npsdk.c:26:
+				DPP_APT_HASH_RES_INIT_T *HashResInit __rte_unused)
 				                        ^

CHECK:CAMELCASE: Avoid CamelCase: <HashResInit>
#1951: FILE: drivers/net/zxdh/zxdh_npsdk.c:26:
+				DPP_APT_HASH_RES_INIT_T *HashResInit __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1958: FILE: drivers/net/zxdh/zxdh_npsdk.c:33:
+				DPP_APT_ERAM_RES_INIT_T *EramResInit __rte_unused)
 				                        ^

CHECK:CAMELCASE: Avoid CamelCase: <EramResInit>
#1958: FILE: drivers/net/zxdh/zxdh_npsdk.c:33:
+				DPP_APT_ERAM_RES_INIT_T *EramResInit __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1965: FILE: drivers/net/zxdh/zxdh_npsdk.c:40:
+				DPP_APT_STAT_RES_INIT_T *StatResInit __rte_unused)
 				                        ^

CHECK:CAMELCASE: Avoid CamelCase: <StatResInit>
#1965: FILE: drivers/net/zxdh/zxdh_npsdk.c:40:
+				DPP_APT_STAT_RES_INIT_T *StatResInit __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1979: FILE: drivers/net/zxdh/zxdh_npsdk.c:54:
+					DPP_APT_HASH_FUNC_RES_T *HashFuncRes __rte_unused)
 					                        ^

CHECK:CAMELCASE: Avoid CamelCase: <HashFuncRes>
#1979: FILE: drivers/net/zxdh/zxdh_npsdk.c:54:
+					DPP_APT_HASH_FUNC_RES_T *HashFuncRes __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1987: FILE: drivers/net/zxdh/zxdh_npsdk.c:62:
+					DPP_APT_HASH_BULK_RES_T *BulkRes __rte_unused)
 					                        ^

CHECK:CAMELCASE: Avoid CamelCase: <BulkRes>
#1987: FILE: drivers/net/zxdh/zxdh_npsdk.c:62:
+					DPP_APT_HASH_BULK_RES_T *BulkRes __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1995: FILE: drivers/net/zxdh/zxdh_npsdk.c:70:
+					DPP_APT_HASH_TABLE_T *HashTbl __rte_unused)
 					                     ^

CHECK:CAMELCASE: Avoid CamelCase: <HashTbl>
#1995: FILE: drivers/net/zxdh/zxdh_npsdk.c:70:
+					DPP_APT_HASH_TABLE_T *HashTbl __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#2003: FILE: drivers/net/zxdh/zxdh_npsdk.c:78:
+				DPP_APT_ERAM_TABLE_T *EramTbl __rte_unused)
 				                     ^

CHECK:CAMELCASE: Avoid CamelCase: <EramTbl>
#2003: FILE: drivers/net/zxdh/zxdh_npsdk.c:78:
+				DPP_APT_ERAM_TABLE_T *EramTbl __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#2035: FILE: drivers/net/zxdh/zxdh_npsdk.c:110:
+			DPP_DEV_INIT_CTRL_T *p_dev_init_ctrl __rte_unused)
 			                    ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#2060: FILE: drivers/net/zxdh/zxdh_npsdk.c:135:
+		 DPP_DTB_USER_ENTRY_T *GetEntry __rte_unused,
 		                      ^

CHECK:CAMELCASE: Avoid CamelCase: <GetEntry>
#2060: FILE: drivers/net/zxdh/zxdh_npsdk.c:135:
+		 DPP_DTB_USER_ENTRY_T *GetEntry __rte_unused,

CHECK:CAMELCASE: Avoid CamelCase: <entryNum>
#2068: FILE: drivers/net/zxdh/zxdh_npsdk.c:143:
+			uint32_t entryNum __rte_unused,

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#2069: FILE: drivers/net/zxdh/zxdh_npsdk.c:144:
+			DPP_DTB_USER_ENTRY_T *DownEntrys __rte_unused)
 			                     ^

CHECK:CAMELCASE: Avoid CamelCase: <DownEntrys>
#2069: FILE: drivers/net/zxdh/zxdh_npsdk.c:144:
+			DPP_DTB_USER_ENTRY_T *DownEntrys __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#2077: FILE: drivers/net/zxdh/zxdh_npsdk.c:152:
+			 DPP_DTB_USER_ENTRY_T *DeleteEntrys __rte_unused)
 			                      ^

CHECK:CAMELCASE: Avoid CamelCase: <DeleteEntrys>
#2077: FILE: drivers/net/zxdh/zxdh_npsdk.c:152:
+			 DPP_DTB_USER_ENTRY_T *DeleteEntrys __rte_unused)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'hash_idx' may be better as '(hash_idx)' to avoid precedence issues
#2125: FILE: drivers/net/zxdh/zxdh_npsdk.h:36:
+#define MK_SDT_NO(table, hash_idx) \
+	(ZXDH_SDT_##table##_TABLE0 + hash_idx)

CHECK:CAMELCASE: Avoid CamelCase: <Data>
#2196: FILE: drivers/net/zxdh/zxdh_npsdk.h:107:
+typedef uint32_t (*DPP_APT_HASH_ENTRY_SET_FUNC)(void *Data, DPP_HASH_ENTRY *Entry);

CHECK:CAMELCASE: Avoid CamelCase: <Entry>
#2196: FILE: drivers/net/zxdh/zxdh_npsdk.h:107:
+typedef uint32_t (*DPP_APT_HASH_ENTRY_SET_FUNC)(void *Data, DPP_HASH_ENTRY *Entry);

CHECK:CAMELCASE: Avoid CamelCase: <sdtNo>
#2200: FILE: drivers/net/zxdh/zxdh_npsdk.h:111:
+	uint32_t sdtNo;

CHECK:CAMELCASE: Avoid CamelCase: <hashSdt>
#2202: FILE: drivers/net/zxdh/zxdh_npsdk.h:113:
+	DPP_SDTTBL_HASH_T hashSdt;

CHECK:CAMELCASE: Avoid CamelCase: <ERamSdt>
#2230: FILE: drivers/net/zxdh/zxdh_npsdk.h:141:
+	DPP_SDTTBL_ERAM_T ERamSdt;

total: 0 errors, 12 warnings, 35 checks, 2154 lines checked
Warning in drivers/net/zxdh/zxdh_logs.h:
Do not use variadic argument pack in macros

          parent reply	other threads:[~2024-08-28  7:28 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20240828072509.2777207-1-wang.junlong1@zte.com.cn>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828072725.707B0120778@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=wang.junlong1@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).