From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D20C45945 for ; Mon, 9 Sep 2024 17:10:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 885E840E4F; Mon, 9 Sep 2024 17:10:46 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 6C5D440291 for ; Mon, 9 Sep 2024 17:10:44 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 677AB121D10; Mon, 9 Sep 2024 17:10:44 +0200 (CEST) Subject: |WARNING| pw143822 [PATCH v4 4/6] eal: add atomic bit operations In-Reply-To: <20240909145743.697342-5-mattias.ronnblom@ericsson.com> References: <20240909145743.697342-5-mattias.ronnblom@ericsson.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= Message-Id: <20240909151044.677AB121D10@dpdk.org> Date: Mon, 9 Sep 2024 17:10:44 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/143822 _coding style issues_ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #258: FILE: lib/eal/include/rte_bitops.h:251: + uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #258: FILE: lib/eal/include/rte_bitops.h:251: + uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #259: FILE: lib/eal/include/rte_bitops.h:252: + const uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #259: FILE: lib/eal/include/rte_bitops.h:252: + const uint32_t *: __rte_bit_atomic_test32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #260: FILE: lib/eal/include/rte_bitops.h:253: + uint64_t *: __rte_bit_atomic_test64, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #260: FILE: lib/eal/include/rte_bitops.h:253: + uint64_t *: __rte_bit_atomic_test64, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #261: FILE: lib/eal/include/rte_bitops.h:254: + const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #261: FILE: lib/eal/include/rte_bitops.h:254: + const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #283: FILE: lib/eal/include/rte_bitops.h:276: + uint32_t *: __rte_bit_atomic_set32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #283: FILE: lib/eal/include/rte_bitops.h:276: + uint32_t *: __rte_bit_atomic_set32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #284: FILE: lib/eal/include/rte_bitops.h:277: + uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #284: FILE: lib/eal/include/rte_bitops.h:277: + uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #305: FILE: lib/eal/include/rte_bitops.h:298: + uint32_t *: __rte_bit_atomic_clear32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #305: FILE: lib/eal/include/rte_bitops.h:298: + uint32_t *: __rte_bit_atomic_clear32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #306: FILE: lib/eal/include/rte_bitops.h:299: + uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #306: FILE: lib/eal/include/rte_bitops.h:299: + uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #329: FILE: lib/eal/include/rte_bitops.h:322: + uint32_t *: __rte_bit_atomic_assign32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #329: FILE: lib/eal/include/rte_bitops.h:322: + uint32_t *: __rte_bit_atomic_assign32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #330: FILE: lib/eal/include/rte_bitops.h:323: + uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #330: FILE: lib/eal/include/rte_bitops.h:323: + uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #353: FILE: lib/eal/include/rte_bitops.h:346: + uint32_t *: __rte_bit_atomic_flip32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #353: FILE: lib/eal/include/rte_bitops.h:346: + uint32_t *: __rte_bit_atomic_flip32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #354: FILE: lib/eal/include/rte_bitops.h:347: + uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order) ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #354: FILE: lib/eal/include/rte_bitops.h:347: + uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order) ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #377: FILE: lib/eal/include/rte_bitops.h:370: + uint32_t *: __rte_bit_atomic_test_and_set32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #377: FILE: lib/eal/include/rte_bitops.h:370: + uint32_t *: __rte_bit_atomic_test_and_set32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #378: FILE: lib/eal/include/rte_bitops.h:371: + uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #378: FILE: lib/eal/include/rte_bitops.h:371: + uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #402: FILE: lib/eal/include/rte_bitops.h:395: + uint32_t *: __rte_bit_atomic_test_and_clear32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #402: FILE: lib/eal/include/rte_bitops.h:395: + uint32_t *: __rte_bit_atomic_test_and_clear32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #403: FILE: lib/eal/include/rte_bitops.h:396: + uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #403: FILE: lib/eal/include/rte_bitops.h:396: + uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #430: FILE: lib/eal/include/rte_bitops.h:423: + uint32_t *: __rte_bit_atomic_test_and_assign32, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #430: FILE: lib/eal/include/rte_bitops.h:423: + uint32_t *: __rte_bit_atomic_test_and_assign32, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxO) #431: FILE: lib/eal/include/rte_bitops.h:424: + uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \ ^ ERROR:SPACING: spaces required around that ':' (ctx:OxW) #431: FILE: lib/eal/include/rte_bitops.h:424: + uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #445: FILE: lib/eal/include/rte_bitops.h:504: + __rte_bit_atomic_ ## variant ## test ## size(const qualifier uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #450: FILE: lib/eal/include/rte_bitops.h:509: + const qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #459: FILE: lib/eal/include/rte_bitops.h:518: + __rte_bit_atomic_ ## variant ## set ## size(qualifier uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #464: FILE: lib/eal/include/rte_bitops.h:523: + qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #473: FILE: lib/eal/include/rte_bitops.h:532: + __rte_bit_atomic_ ## variant ## clear ## size(qualifier uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #478: FILE: lib/eal/include/rte_bitops.h:537: + qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #487: FILE: lib/eal/include/rte_bitops.h:546: + __rte_bit_atomic_ ## variant ## flip ## size(qualifier uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #492: FILE: lib/eal/include/rte_bitops.h:551: + qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #501: FILE: lib/eal/include/rte_bitops.h:560: + __rte_bit_atomic_## variant ## assign ## size(qualifier uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #515: FILE: lib/eal/include/rte_bitops.h:574: + __rte_bit_atomic_ ## variant ## test_and_set ## size(qualifier uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #521: FILE: lib/eal/include/rte_bitops.h:580: + qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #535: FILE: lib/eal/include/rte_bitops.h:594: + __rte_bit_atomic_ ## variant ## test_and_clear ## size(qualifier uint ## size ## _t *addr, \ ^ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #541: FILE: lib/eal/include/rte_bitops.h:600: + qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \ ^ ERROR:CODE_INDENT: code indent should use tabs where possible #546: FILE: lib/eal/include/rte_bitops.h:605: +^I prev = rte_atomic_fetch_and_explicit(a_addr, ~mask,^I\$ WARNING:LONG_LINE: line length of 101 exceeds 100 columns #555: FILE: lib/eal/include/rte_bitops.h:614: + __rte_bit_atomic_ ## variant ## test_and_assign ## size(qualifier uint ## size ## _t *addr, \ ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #555: FILE: lib/eal/include/rte_bitops.h:614: + __rte_bit_atomic_ ## variant ## test_and_assign ## size(qualifier uint ## size ## _t *addr, \ ^ WARNING:LONG_LINE: line length of 110 exceeds 100 columns #561: FILE: lib/eal/include/rte_bitops.h:620: + return __rte_bit_atomic_ ## variant ## test_and_set ## size(addr, nr, memory_order); \ WARNING:LONG_LINE: line length of 112 exceeds 100 columns #563: FILE: lib/eal/include/rte_bitops.h:622: + return __rte_bit_atomic_ ## variant ## test_and_clear ## size(addr, nr, memory_order); \ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #566: FILE: lib/eal/include/rte_bitops.h:625: +#define __RTE_GEN_BIT_ATOMIC_OPS(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_TEST(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_SET(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_CLEAR(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_ASSIGN(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_TEST_AND_SET(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_TEST_AND_CLEAR(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(variant, qualifier, size) \ + __RTE_GEN_BIT_ATOMIC_FLIP(variant, qualifier, size) ERROR:SPACING: space required after that ',' (ctx:BxO) #577: FILE: lib/eal/include/rte_bitops.h:636: + __RTE_GEN_BIT_ATOMIC_OPS(,, size) ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #605: FILE: lib/eal/include/rte_bitops.h:1388: +#define __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, size, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name) \ + static inline ret_type \ + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ + arg2_type arg2_name) \ + { \ + return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name); \ + } ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #608: FILE: lib/eal/include/rte_bitops.h:1391: + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #614: FILE: lib/eal/include/rte_bitops.h:1397: +#define __RTE_BIT_OVERLOAD_3R(fun, qualifier, ret_type, arg1_type, arg1_name, \ + arg2_type, arg2_name) \ + __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 32, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name) \ + __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 64, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name) ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #624: FILE: lib/eal/include/rte_bitops.h:1407: + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #631: FILE: lib/eal/include/rte_bitops.h:1414: +#define __RTE_BIT_OVERLOAD_4(fun, qualifier, arg1_type, arg1_name, arg2_type, \ + arg2_name, arg3_type, arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 32, arg1_type, arg1_name, \ + arg2_type, arg2_name, arg3_type, arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 64, arg1_type, arg1_name, \ + arg2_type, arg2_name, arg3_type, arg3_name) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #638: FILE: lib/eal/include/rte_bitops.h:1421: +#define __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, size, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name, arg3_type, \ + arg3_name) \ + static inline ret_type \ + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ + arg2_type arg2_name, arg3_type arg3_name) \ + { \ + return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name, \ + arg3_name); \ + } ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #642: FILE: lib/eal/include/rte_bitops.h:1425: + rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \ ^ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #649: FILE: lib/eal/include/rte_bitops.h:1432: +#define __RTE_BIT_OVERLOAD_4R(fun, qualifier, ret_type, arg1_type, arg1_name, \ + arg2_type, arg2_name, arg3_type, arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 32, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name, arg3_type, \ + arg3_name) \ + __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 64, ret_type, arg1_type, \ + arg1_name, arg2_type, arg2_name, arg3_type, \ + arg3_name) ERROR:SPACING: space required after that ',' (ctx:VxO) #666: FILE: lib/eal/include/rte_bitops.h:1449: +__RTE_BIT_OVERLOAD_3(atomic_set,, unsigned int, nr, int, memory_order) ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #667: FILE: lib/eal/include/rte_bitops.h:1450: +__RTE_BIT_OVERLOAD_3(atomic_clear,, unsigned int, nr, int, memory_order) ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #668: FILE: lib/eal/include/rte_bitops.h:1451: +__RTE_BIT_OVERLOAD_4(atomic_assign,, unsigned int, nr, bool, value, ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #670: FILE: lib/eal/include/rte_bitops.h:1453: +__RTE_BIT_OVERLOAD_3(atomic_flip,, unsigned int, nr, int, memory_order) ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #671: FILE: lib/eal/include/rte_bitops.h:1454: +__RTE_BIT_OVERLOAD_3R(atomic_test_and_set,, bool, unsigned int, nr, ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #673: FILE: lib/eal/include/rte_bitops.h:1456: +__RTE_BIT_OVERLOAD_3R(atomic_test_and_clear,, bool, unsigned int, nr, ^ ERROR:SPACING: space required after that ',' (ctx:VxO) #675: FILE: lib/eal/include/rte_bitops.h:1458: +__RTE_BIT_OVERLOAD_4R(atomic_test_and_assign,, bool, unsigned int, nr, ^ total: 68 errors, 3 warnings, 474 lines checked __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function. __rte_experimental must appear alone on the line immediately preceding the return type of a function.