From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: |WARNING| pw143856 [PATCH v6 2/6] eal: extend bit manipulation functionality
Date: Tue, 10 Sep 2024 10:44:45 +0200 (CEST) [thread overview]
Message-ID: <20240910084445.BED41121D10@dpdk.org> (raw)
In-Reply-To: <20240910083139.699291-3-mattias.ronnblom@ericsson.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143856
_coding style issues_
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#235: FILE: lib/eal/include/rte_bitops.h:131:
+ uint32_t *: __rte_bit_test32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#235: FILE: lib/eal/include/rte_bitops.h:131:
+ uint32_t *: __rte_bit_test32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#236: FILE: lib/eal/include/rte_bitops.h:132:
+ const uint32_t *: __rte_bit_test32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#236: FILE: lib/eal/include/rte_bitops.h:132:
+ const uint32_t *: __rte_bit_test32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#237: FILE: lib/eal/include/rte_bitops.h:133:
+ uint64_t *: __rte_bit_test64, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#237: FILE: lib/eal/include/rte_bitops.h:133:
+ uint64_t *: __rte_bit_test64, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#238: FILE: lib/eal/include/rte_bitops.h:134:
+ const uint64_t *: __rte_bit_test64)(addr, nr)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#238: FILE: lib/eal/include/rte_bitops.h:134:
+ const uint64_t *: __rte_bit_test64)(addr, nr)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#260: FILE: lib/eal/include/rte_bitops.h:156:
+ uint32_t *: __rte_bit_set32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#260: FILE: lib/eal/include/rte_bitops.h:156:
+ uint32_t *: __rte_bit_set32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#261: FILE: lib/eal/include/rte_bitops.h:157:
+ uint64_t *: __rte_bit_set64)(addr, nr)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#261: FILE: lib/eal/include/rte_bitops.h:157:
+ uint64_t *: __rte_bit_set64)(addr, nr)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#283: FILE: lib/eal/include/rte_bitops.h:179:
+ uint32_t *: __rte_bit_clear32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#283: FILE: lib/eal/include/rte_bitops.h:179:
+ uint32_t *: __rte_bit_clear32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#284: FILE: lib/eal/include/rte_bitops.h:180:
+ uint64_t *: __rte_bit_clear64)(addr, nr)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#284: FILE: lib/eal/include/rte_bitops.h:180:
+ uint64_t *: __rte_bit_clear64)(addr, nr)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#307: FILE: lib/eal/include/rte_bitops.h:203:
+ uint32_t *: __rte_bit_assign32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#307: FILE: lib/eal/include/rte_bitops.h:203:
+ uint32_t *: __rte_bit_assign32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#308: FILE: lib/eal/include/rte_bitops.h:204:
+ uint64_t *: __rte_bit_assign64)(addr, nr, value)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#308: FILE: lib/eal/include/rte_bitops.h:204:
+ uint64_t *: __rte_bit_assign64)(addr, nr, value)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#330: FILE: lib/eal/include/rte_bitops.h:226:
+ uint32_t *: __rte_bit_flip32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#330: FILE: lib/eal/include/rte_bitops.h:226:
+ uint32_t *: __rte_bit_flip32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#331: FILE: lib/eal/include/rte_bitops.h:227:
+ uint64_t *: __rte_bit_flip64)(addr, nr)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#331: FILE: lib/eal/include/rte_bitops.h:227:
+ uint64_t *: __rte_bit_flip64)(addr, nr)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#336: FILE: lib/eal/include/rte_bitops.h:232:
+ __rte_bit_ ## variant ## test ## size(const qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#348: FILE: lib/eal/include/rte_bitops.h:244:
+ __rte_bit_ ## variant ## set ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#360: FILE: lib/eal/include/rte_bitops.h:256:
+ __rte_bit_ ## variant ## clear ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#372: FILE: lib/eal/include/rte_bitops.h:268:
+ __rte_bit_ ## variant ## assign ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#384: FILE: lib/eal/include/rte_bitops.h:280:
+ __rte_bit_ ## variant ## flip ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#393: FILE: lib/eal/include/rte_bitops.h:289:
+#define __RTE_GEN_BIT_OPS(v, qualifier, size) \
+ __RTE_GEN_BIT_TEST(v, qualifier, size) \
+ __RTE_GEN_BIT_SET(v, qualifier, size) \
+ __RTE_GEN_BIT_CLEAR(v, qualifier, size) \
+ __RTE_GEN_BIT_ASSIGN(v, qualifier, size) \
+ __RTE_GEN_BIT_FLIP(v, qualifier, size)
ERROR:SPACING: space required after that ',' (ctx:BxO)
#401: FILE: lib/eal/include/rte_bitops.h:297:
+ __RTE_GEN_BIT_OPS(,, size)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#428: FILE: lib/eal/include/rte_bitops.h:999:
+ rte_bit_ ## fun(qualifier uint ## size ## _t *addr, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#434: FILE: lib/eal/include/rte_bitops.h:1005:
+#define __RTE_BIT_OVERLOAD_2(fun, qualifier, arg1_type, arg1_name) \
+ __RTE_BIT_OVERLOAD_SZ_2(fun, qualifier, 32, arg1_type, arg1_name) \
+ __RTE_BIT_OVERLOAD_SZ_2(fun, qualifier, 64, arg1_type, arg1_name)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#438: FILE: lib/eal/include/rte_bitops.h:1009:
+#define __RTE_BIT_OVERLOAD_SZ_2R(fun, qualifier, size, ret_type, arg1_type, \
+ arg1_name) \
+ static inline ret_type \
+ rte_bit_ ## fun(qualifier uint ## size ## _t *addr, \
+ arg1_type arg1_name) \
+ { \
+ return __rte_bit_ ## fun ## size(addr, arg1_name); \
+ }
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#441: FILE: lib/eal/include/rte_bitops.h:1012:
+ rte_bit_ ## fun(qualifier uint ## size ## _t *addr, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#447: FILE: lib/eal/include/rte_bitops.h:1018:
+#define __RTE_BIT_OVERLOAD_2R(fun, qualifier, ret_type, arg1_type, arg1_name) \
+ __RTE_BIT_OVERLOAD_SZ_2R(fun, qualifier, 32, ret_type, arg1_type, \
+ arg1_name) \
+ __RTE_BIT_OVERLOAD_SZ_2R(fun, qualifier, 64, ret_type, arg1_type, \
+ arg1_name)
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#456: FILE: lib/eal/include/rte_bitops.h:1027:
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#462: FILE: lib/eal/include/rte_bitops.h:1033:
+#define __RTE_BIT_OVERLOAD_3(fun, qualifier, arg1_type, arg1_name, arg2_type, \
+ arg2_name) \
+ __RTE_BIT_OVERLOAD_SZ_3(fun, qualifier, 32, arg1_type, arg1_name, \
+ arg2_type, arg2_name) \
+ __RTE_BIT_OVERLOAD_SZ_3(fun, qualifier, 64, arg1_type, arg1_name, \
+ arg2_type, arg2_name)
ERROR:SPACING: space required after that ',' (ctx:VxO)
#470: FILE: lib/eal/include/rte_bitops.h:1041:
+__RTE_BIT_OVERLOAD_2(set,, unsigned int, nr)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#471: FILE: lib/eal/include/rte_bitops.h:1042:
+__RTE_BIT_OVERLOAD_2(clear,, unsigned int, nr)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#472: FILE: lib/eal/include/rte_bitops.h:1043:
+__RTE_BIT_OVERLOAD_3(assign,, unsigned int, nr, bool, value)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#473: FILE: lib/eal/include/rte_bitops.h:1044:
+__RTE_BIT_OVERLOAD_2(flip,, unsigned int, nr)
^
total: 42 errors, 0 warnings, 288 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
parent reply other threads:[~2024-09-10 8:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240910083139.699291-3-mattias.ronnblom@ericsson.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910084445.BED41121D10@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).