|WARNING| pw143914 [PATCH v4] net/zxdh: Provided zxdh basic init

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Junlong Wang <wang.junlong1@zte.com.cn>
Subject: |WARNING| pw143914 [PATCH v4] net/zxdh: Provided zxdh basic init
Date: Tue, 10 Sep 2024 14:06:50 +0200 (CEST)	[thread overview]
Message-ID: <20240910120650.B3700121D10@dpdk.org> (raw)
In-Reply-To: <20240910120020.4031035-1-wang.junlong1@zte.com.cn>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143914

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->use_msix != ZXDH_MSIX_NONE'
#640: FILE: drivers/net/zxdh/zxdh_ethdev.c:317:
+	if (vtpci_with_feature(hw, ZXDH_NET_F_STATUS) && (hw->use_msix != ZXDH_MSIX_NONE)) {

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#866: FILE: drivers/net/zxdh/zxdh_ethdev.c:543:
+					hw->vqs[i * 2], i + ZXDH_QUE_INTR_VEC_BASE);

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#868: FILE: drivers/net/zxdh/zxdh_ethdev.c:545:
+					i * 2, i + ZXDH_QUE_INTR_VEC_BASE, vec);

WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1092: FILE: drivers/net/zxdh/zxdh_ethdev.c:769:
+	hw->vlan_fiter = (uint64_t *)rte_malloc("vlan_filter", 64 * sizeof(uint64_t), 1);

WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1093: FILE: drivers/net/zxdh/zxdh_ethdev.c:770:
+	memset(hw->vlan_fiter, 0, 64 * sizeof(uint64_t));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'g_dtb_data.init_done'
#1205: FILE: drivers/net/zxdh/zxdh_ethdev.c:882:
+	if ((g_dtb_data.init_done) && (g_dtb_data.bind_device == dev))  {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'g_dtb_data.bind_device == dev'
#1205: FILE: drivers/net/zxdh/zxdh_ethdev.c:882:
+	if ((g_dtb_data.init_done) && (g_dtb_data.bind_device == dev))  {

CHECK:CAMELCASE: Avoid CamelCase: <HashResInit>
#1342: FILE: drivers/net/zxdh/zxdh_ethdev.c:1019:
+	DPP_APT_HASH_RES_INIT_T HashResInit = {0};

CHECK:CAMELCASE: Avoid CamelCase: <EramResInit>
#1343: FILE: drivers/net/zxdh/zxdh_ethdev.c:1020:
+	DPP_APT_ERAM_RES_INIT_T EramResInit = {0};

CHECK:CAMELCASE: Avoid CamelCase: <StatResInit>
#1344: FILE: drivers/net/zxdh/zxdh_ethdev.c:1021:
+	DPP_APT_STAT_RES_INIT_T StatResInit = {0};

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'zxdh_shared_data != NULL'
#1433: FILE: drivers/net/zxdh/zxdh_ethdev.c:1110:
+	if ((zxdh_shared_data != NULL) && zxdh_shared_data->npsdk_init_done) {

WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1462: FILE: drivers/net/zxdh/zxdh_ethdev.c:1139:
+	rte_free(priv->vlan_fiter);

WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1463: FILE: drivers/net/zxdh/zxdh_ethdev.c:1140:
+	priv->vlan_fiter = NULL;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!g_dtb_data.init_done'
#1506: FILE: drivers/net/zxdh/zxdh_ethdev.c:1183:
+	if ((!g_dtb_data.init_done) && (!g_dtb_data.dev_refcnt))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!g_dtb_data.dev_refcnt'
#1506: FILE: drivers/net/zxdh/zxdh_ethdev.c:1183:
+	if ((!g_dtb_data.init_done) && (!g_dtb_data.dev_refcnt))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pcie_id' may be better as '(pcie_id)' to avoid precedence issues
#1673: FILE: drivers/net/zxdh/zxdh_ethdev.h:16:
+#define PF_PCIE_ID(pcie_id)         ((pcie_id & 0xff00) | 1 << 11)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pcie_id' may be better as '(pcie_id)' to avoid precedence issues
#1674: FILE: drivers/net/zxdh/zxdh_ethdev.h:17:
+#define VF_PCIE_ID(pcie_id, vf_idx) ((pcie_id & 0xff00) | (1 << 11) | (vf_idx & 0xff))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'vf_idx' may be better as '(vf_idx)' to avoid precedence issues
#1674: FILE: drivers/net/zxdh/zxdh_ethdev.h:17:
+#define VF_PCIE_ID(pcie_id, vf_idx) ((pcie_id & 0xff00) | (1 << 11) | (vf_idx & 0xff))

WARNING:TYPO_SPELLING: 'fiter' may be misspelled - perhaps 'filter'?
#1809: FILE: drivers/net/zxdh/zxdh_ethdev.h:152:
+	uint64_t *vlan_fiter;

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'bus' may be better as '(bus)' to avoid precedence issues
#1929: FILE: drivers/net/zxdh/zxdh_msg.c:20:
+#define BDF_ECAM(bus, devid, func)   (((bus & 0xff) << 8) | (func & 0x07) | ((devid & 0x1f) << 3))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'devid' may be better as '(devid)' to avoid precedence issues
#1929: FILE: drivers/net/zxdh/zxdh_msg.c:20:
+#define BDF_ECAM(bus, devid, func)   (((bus & 0xff) << 8) | (func & 0x07) | ((devid & 0x1f) << 3))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1929: FILE: drivers/net/zxdh/zxdh_msg.c:20:
+#define BDF_ECAM(bus, devid, func)   (((bus & 0xff) << 8) | (func & 0x07) | ((devid & 0x1f) << 3))

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#2075: FILE: drivers/net/zxdh/zxdh_msg.c:166:
+#define LOCK_MASTER_ID_MASK                (0x8000)

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#2236: FILE: drivers/net/zxdh/zxdh_msg.c:327:
+		PMD_MSG_LOG(ERR, "subchan addr: %" PRIu64 "offset: %" PRIu32,

CHECK:CAMELCASE: Avoid CamelCase: <PRIu32>
#2236: FILE: drivers/net/zxdh/zxdh_msg.c:327:
+		PMD_MSG_LOG(ERR, "subchan addr: %" PRIu64 "offset: %" PRIu32,

WARNING:TYPO_SPELLING: 'mininal' may be misspelled - perhaps 'minimal'?
#2438: FILE: drivers/net/zxdh/zxdh_msg.c:529:
+			"recv buffer len: %" PRIu64 " is short than mininal 4 bytes
",

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#2486: FILE: drivers/net/zxdh/zxdh_msg.c:577:
+					uint64_t label_addr, uint16_t master_id)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#2495: FILE: drivers/net/zxdh/zxdh_msg.c:586:
+			label_write((uint64_t)label_addr, virt_lock_id, master_id);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#2543: FILE: drivers/net/zxdh/zxdh_msg.c:634:
+					src_pcieid | LOCK_MASTER_ID_MASK);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#2547: FILE: drivers/net/zxdh/zxdh_msg.c:638:
+					src_pcieid | LOCK_MASTER_ID_MASK);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'time_out_cnt == BAR_MSG_TIMEOUT_TH'
#2673: FILE: drivers/net/zxdh/zxdh_msg.c:764:
+	if ((time_out_cnt == BAR_MSG_TIMEOUT_TH) && (valid != BAR_MSG_CHAN_USABLE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'valid != BAR_MSG_CHAN_USABLE'
#2673: FILE: drivers/net/zxdh/zxdh_msg.c:764:
+	if ((time_out_cnt == BAR_MSG_TIMEOUT_TH) && (valid != BAR_MSG_CHAN_USABLE)) {

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#2753: FILE: drivers/net/zxdh/zxdh_msg.c:844:
+					uint8_t *reciver_buff, void *dev)

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#2763: FILE: drivers/net/zxdh/zxdh_msg.c:854:
+	recv_func(reciver_buff, msg_header->len, reps_buffer, &reps_len, dev);

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#2772: FILE: drivers/net/zxdh/zxdh_msg.c:863:
+static void __bar_msg_ack_async_msg_proc(struct bar_msg_header *msg_header, uint8_t *reciver_buff)

WARNING:TYPO_SPELLING: 'reciver' may be misspelled - perhaps 'receiver'?
#2787: FILE: drivers/net/zxdh/zxdh_msg.c:878:
+	rte_memcpy(reps_buffer + 4, reciver_buff, msg_header->len);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around g_seqid_ring.reps_info_tbl[seq_id]
#3069: FILE: drivers/net/zxdh/zxdh_msg.c:1160:
+		struct seqid_item *reps_info = &(g_seqid_ring.reps_info_tbl[seq_id]);

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#3125: FILE: drivers/net/zxdh/zxdh_msg.h:33:
+#define ZXDH_QUE_INTR_VEC_BASE      (ZXDH_MSIX_INTR_DTB_VEC + ZXDH_MSIX_INTR_DTB_VEC_NUM) /* 5 */

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#3126: FILE: drivers/net/zxdh/zxdh_msg.h:34:
+#define ZXDH_QUE_INTR_VEC_NUM       256

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#3560: FILE: drivers/net/zxdh/zxdh_npsdk.c:54:
+					DPP_APT_HASH_FUNC_RES_T *HashFuncRes __rte_unused)
 					                        ^

CHECK:CAMELCASE: Avoid CamelCase: <HashFuncRes>
#3560: FILE: drivers/net/zxdh/zxdh_npsdk.c:54:
+					DPP_APT_HASH_FUNC_RES_T *HashFuncRes __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#3568: FILE: drivers/net/zxdh/zxdh_npsdk.c:62:
+					DPP_APT_HASH_BULK_RES_T *BulkRes __rte_unused)
 					                        ^

CHECK:CAMELCASE: Avoid CamelCase: <BulkRes>
#3568: FILE: drivers/net/zxdh/zxdh_npsdk.c:62:
+					DPP_APT_HASH_BULK_RES_T *BulkRes __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#3576: FILE: drivers/net/zxdh/zxdh_npsdk.c:70:
+					DPP_APT_HASH_TABLE_T *HashTbl __rte_unused)
 					                     ^

CHECK:CAMELCASE: Avoid CamelCase: <HashTbl>
#3576: FILE: drivers/net/zxdh/zxdh_npsdk.c:70:
+					DPP_APT_HASH_TABLE_T *HashTbl __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#3584: FILE: drivers/net/zxdh/zxdh_npsdk.c:78:
+				DPP_APT_ERAM_TABLE_T *EramTbl __rte_unused)
 				                     ^

CHECK:CAMELCASE: Avoid CamelCase: <EramTbl>
#3584: FILE: drivers/net/zxdh/zxdh_npsdk.c:78:
+				DPP_APT_ERAM_TABLE_T *EramTbl __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#3641: FILE: drivers/net/zxdh/zxdh_npsdk.c:135:
+		 DPP_DTB_USER_ENTRY_T *GetEntry __rte_unused,
 		                      ^

CHECK:CAMELCASE: Avoid CamelCase: <GetEntry>
#3641: FILE: drivers/net/zxdh/zxdh_npsdk.c:135:
+		 DPP_DTB_USER_ENTRY_T *GetEntry __rte_unused,

CHECK:CAMELCASE: Avoid CamelCase: <entryNum>
#3649: FILE: drivers/net/zxdh/zxdh_npsdk.c:143:
+			uint32_t entryNum __rte_unused,

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#3650: FILE: drivers/net/zxdh/zxdh_npsdk.c:144:
+			DPP_DTB_USER_ENTRY_T *DownEntrys __rte_unused)
 			                     ^

CHECK:CAMELCASE: Avoid CamelCase: <DownEntrys>
#3650: FILE: drivers/net/zxdh/zxdh_npsdk.c:144:
+			DPP_DTB_USER_ENTRY_T *DownEntrys __rte_unused)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#3658: FILE: drivers/net/zxdh/zxdh_npsdk.c:152:
+			 DPP_DTB_USER_ENTRY_T *DeleteEntrys __rte_unused)
 			                      ^

CHECK:CAMELCASE: Avoid CamelCase: <DeleteEntrys>
#3658: FILE: drivers/net/zxdh/zxdh_npsdk.c:152:
+			 DPP_DTB_USER_ENTRY_T *DeleteEntrys __rte_unused)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'hash_idx' may be better as '(hash_idx)' to avoid precedence issues
#3706: FILE: drivers/net/zxdh/zxdh_npsdk.h:36:
+#define MK_SDT_NO(table, hash_idx) \
+	(ZXDH_SDT_##table##_TABLE0 + hash_idx)

CHECK:CAMELCASE: Avoid CamelCase: <Data>
#3777: FILE: drivers/net/zxdh/zxdh_npsdk.h:107:
+typedef uint32_t (*DPP_APT_HASH_ENTRY_SET_FUNC)(void *Data, DPP_HASH_ENTRY *Entry);

CHECK:CAMELCASE: Avoid CamelCase: <Entry>
#3777: FILE: drivers/net/zxdh/zxdh_npsdk.h:107:
+typedef uint32_t (*DPP_APT_HASH_ENTRY_SET_FUNC)(void *Data, DPP_HASH_ENTRY *Entry);

CHECK:CAMELCASE: Avoid CamelCase: <sdtNo>
#3781: FILE: drivers/net/zxdh/zxdh_npsdk.h:111:
+	uint32_t sdtNo;

CHECK:CAMELCASE: Avoid CamelCase: <hashSdt>
#3783: FILE: drivers/net/zxdh/zxdh_npsdk.h:113:
+	DPP_SDTTBL_HASH_T hashSdt;

CHECK:CAMELCASE: Avoid CamelCase: <ERamSdt>
#3811: FILE: drivers/net/zxdh/zxdh_npsdk.h:141:
+	DPP_SDTTBL_ERAM_T ERamSdt;

total: 0 errors, 19 warnings, 41 checks, 4775 lines checked
Warning in drivers/net/zxdh/zxdh_logs.h:
Do not use variadic argument pack in macros

next prev parent reply	other threads:[~2024-09-10 12:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240910120020.4031035-1-wang.junlong1@zte.com.cn>
2024-09-10 11:47 ` |SUCCESS| " qemudev
2024-09-10 11:52 ` qemudev
2024-09-10 12:06 ` checkpatch [this message]
2024-09-10 13:05 ` 0-day Robot
2024-09-10 21:42 ` |SUCCESS| pw143914 [PATCH] [v4] " dpdklab
2024-09-10 21:48 ` dpdklab
2024-09-10 22:22 ` dpdklab
2024-09-10 23:21 ` dpdklab
2024-09-10 23:36 ` |PENDING| " dpdklab
2024-09-10 23:40 ` |SUCCESS| " dpdklab
2024-09-10 23:45 ` dpdklab
2024-09-10 23:49 ` dpdklab
2024-09-10 23:53 ` |PENDING| " dpdklab
2024-09-10 23:54 ` |SUCCESS| " dpdklab
2024-09-11  0:01 ` |PENDING| " dpdklab
2024-09-11  0:09 ` |SUCCESS| " dpdklab
2024-09-11  0:13 ` dpdklab
2024-09-11  0:23 ` dpdklab
2024-09-11  0:23 ` dpdklab
2024-09-11  0:26 ` dpdklab
2024-09-11  0:50 ` dpdklab
2024-09-11  1:04 ` dpdklab
2024-09-11  2:38 ` dpdklab
2024-09-16  0:42 ` dpdklab
2024-09-16  6:28 ` dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910120650.B3700121D10@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=wang.junlong1@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).