From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Subject: |WARNING| pw143990 [PATCH v2 10/14] drivers: replace logging helpers
Date: Thu, 12 Sep 2024 10:29:18 +0200 (CEST) [thread overview]
Message-ID: <20240912082918.1D57C121D10@dpdk.org> (raw)
In-Reply-To: <20240912082643.1532679-11-david.marchand@redhat.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143990
_coding style issues_
ERROR:SPACING: space required after that ',' (ctx:VxB)
#329: FILE: drivers/bus/platform/private.h:38:
+ RTE_LOG(level, PLATFORM_BUS, RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "
", \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#330: FILE: drivers/bus/platform/private.h:39:
+ RTE_FMT_TAIL(__VA_ARGS__,)))
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#608: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:340:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#652: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:366:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#657: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:371:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#665: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:376:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#685: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:391:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#704: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:405:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#723: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:419:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#736: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:424:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#741: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:429:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#769: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:439:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#774: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:444:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#782: FILE: drivers/compress/nitrox/nitrox_comp_reqmgr.c:452:
+ NITROX_LOG_LINE(DEBUG,);
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#1241: FILE: drivers/dma/odm/odm.h:71:
+ RTE_FMT("%s(): %u" RTE_FMT_HEAD(__VA_ARGS__,) "
", __func__, __LINE__, \
^
WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1287: FILE: drivers/event/dlb2/dlb2.c:835:
+ DLB2_LOG_LINE_DBG("sched domain create - ldb_qs=%d, ldb_ports=%d, dir_ports=%d, atomic_inflights=%d, hist_list_entries=%d, credits=%d",
WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1296: FILE: drivers/event/dlb2/dlb2.c:843:
+ DLB2_LOG_LINE_DBG("sched domain create - ldb_qs=%d, ldb_ports=%d, dir_ports=%d, atomic_inflights=%d, hist_list_entries=%d, ldb_credits=%d, dir_credits=%d",
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#3709: FILE: drivers/net/axgbe/axgbe_ethdev.c:1777:
+ "flags = 0x%x nsec = %"PRIu64,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#3725: FILE: drivers/net/axgbe/axgbe_ethdev.c:1810:
+ PMD_DRV_LOG_LINE(DEBUG, "nsec = %"PRIu64" tx_ssr = %d tx_snr = %d",
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3916: FILE: drivers/net/axgbe/axgbe_i2c.c:235:
+ PMD_DRV_LOG_LINE(ERR, "failed to disable i2c master");
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3925: FILE: drivers/net/axgbe/axgbe_i2c.c:252:
+ PMD_DRV_LOG_LINE(ERR, "failed to enable i2c master");
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3961: FILE: drivers/net/axgbe/axgbe_i2c.c:324:
+ PMD_DRV_LOG_LINE(ERR, "failed to disable i2c master");
CHECK:CAMELCASE: Avoid CamelCase: <PRIu32>
#10903: FILE: drivers/net/ena/ena_ethdev.c:2887:
+ "mbuf[%" PRIu32 "] has unsupported offloads flags set: 0x%" PRIu64,
CHECK:CAMELCASE: Avoid CamelCase: <PRIu16>
#10914: FILE: drivers/net/ena/ena_ethdev.c:2898:
+ "mbuf[%" PRIu32 "] has too many segments: %" PRIu16,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#11432: FILE: drivers/net/ena/ena_rss.c:427:
+ "Setting RSS hash fields is not supported. Using default values: 0x%"PRIx64,
total: 15 errors, 5 warnings, 5 checks, 10498 lines checked
parent reply other threads:[~2024-09-12 8:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240912082643.1532679-11-david.marchand@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912082918.1D57C121D10@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).